[dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

[dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

[Shreyansh Jain]

From: Hemant Agrawal <hemant.agrawal@nxp.com>

fle is already in virtual addressing mode - no need to perform
address conversion for it.

Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
Cc: akhil.goyal@nxp.com

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 58cbce868..56fa969d3 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -1261,8 +1261,7 @@ sec_fd_to_mbuf(const struct qbman_fd *fd, uint8_t driver_id)
 		DPAA2_SEC_ERR("error: non inline buffer");
 		return NULL;
 	}
-	op = (struct rte_crypto_op *)DPAA2_IOVA_TO_VADDR(
-			DPAA2_GET_FLE_ADDR((fle - 1)));
+	op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1));
 
 	/* Prefeth op */
 	src = op->sym->m_src;
-- 
2.17.0

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

[Akhil Goyal]

On 5/9/2018 2:56 PM, Shreyansh Jain wrote:
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> fle is already in virtual addressing mode - no need to perform
> address conversion for it.
>
> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
> Cc: akhil.goyal@nxp.com
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> index 58cbce868..56fa969d3 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> @@ -1261,8 +1261,7 @@ sec_fd_to_mbuf(const struct qbman_fd *fd, uint8_t driver_id)
>  		DPAA2_SEC_ERR("error: non inline buffer");
>  		return NULL;
>  	}
> -	op = (struct rte_crypto_op *)DPAA2_IOVA_TO_VADDR(
> -			DPAA2_GET_FLE_ADDR((fle - 1)));
> +	op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1));
>
>  	/* Prefeth op */
>  	src = op->sym->m_src;
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, May 9, 2018 10:14 AM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: akhil.goyal@nxp.com; dev@dpdk.org; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for
> fle address
> 
> On 5/9/2018 2:56 PM, Shreyansh Jain wrote:
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> >
> > fle is already in virtual addressing mode - no need to perform address
> > conversion for it.
> >
> > Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
> > Cc: akhil.goyal@nxp.com
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

...

> >
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Added Cc: stable@dpdk.org (try remembering this for next time, please).

Applied to dpdk-next-crypto.
Thanks,

Pablo

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

[Shreyansh Jain]

On Wednesday 09 May 2018 03:54 PM, De Lara Guarch, Pablo wrote:
> 
> 
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>> Sent: Wednesday, May 9, 2018 10:14 AM
>> To: Shreyansh Jain <shreyansh.jain@nxp.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>
>> Cc: akhil.goyal@nxp.com; dev@dpdk.org; Hemant Agrawal
>> <hemant.agrawal@nxp.com>
>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for
>> fle address
>>
>> On 5/9/2018 2:56 PM, Shreyansh Jain wrote:
>>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>
>>> fle is already in virtual addressing mode - no need to perform address
>>> conversion for it.
>>>
>>> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
>>> Cc: akhil.goyal@nxp.com
>>>
>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> ...
> 
>>>
>> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Added Cc: stable@dpdk.org (try remembering this for next time, please).

Thanks for doing it this time. I'll take care of this next time.

> 
> Applied to dpdk-next-crypto.
> Thanks,
> 
> Pablo
> 

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

[De Lara Guarch, Pablo]

Hi,

> -----Original Message-----
> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]
> Sent: Wednesday, May 9, 2018 12:40 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for
> fle address
> 
> On Wednesday 09 May 2018 03:54 PM, De Lara Guarch, Pablo wrote:
> >
> >
> >> -----Original Message-----
> >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> >> Sent: Wednesday, May 9, 2018 10:14 AM
> >> To: Shreyansh Jain <shreyansh.jain@nxp.com>; De Lara Guarch, Pablo
> >> <pablo.de.lara.guarch@intel.com>
> >> Cc: akhil.goyal@nxp.com; dev@dpdk.org; Hemant Agrawal
> >> <hemant.agrawal@nxp.com>
> >> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova
> >> conversion for fle address
> >>
> >> On 5/9/2018 2:56 PM, Shreyansh Jain wrote:
> >>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> >>>
> >>> fle is already in virtual addressing mode - no need to perform
> >>> address conversion for it.
> >>>
> >>> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
> >>> Cc: akhil.goyal@nxp.com
> >>>
> >>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> >
> > ...
> >
> >>>
> >> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> >
> > Added Cc: stable@dpdk.org (try remembering this for next time, please).
> 
> Thanks for doing it this time. I'll take care of this next time.

No worries. Actually, gcc 32 bits is broken:

drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1264:7:
error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
  op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1));

Is this PMD supposed to be compatible for 32-bit targets?

Thanks,
Pablo

> 
> >
> > Applied to dpdk-next-crypto.
> > Thanks,
> >
> > Pablo
> >

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

[Shreyansh Jain]

On Wednesday 09 May 2018 05:00 PM, De Lara Guarch, Pablo wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]
>> Sent: Wednesday, May 9, 2018 12:40 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Cc: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; Hemant Agrawal
>> <hemant.agrawal@nxp.com>
>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for
>> fle address
>>
>> On Wednesday 09 May 2018 03:54 PM, De Lara Guarch, Pablo wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>>>> Sent: Wednesday, May 9, 2018 10:14 AM
>>>> To: Shreyansh Jain <shreyansh.jain@nxp.com>; De Lara Guarch, Pablo
>>>> <pablo.de.lara.guarch@intel.com>
>>>> Cc: akhil.goyal@nxp.com; dev@dpdk.org; Hemant Agrawal
>>>> <hemant.agrawal@nxp.com>
>>>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova
>>>> conversion for fle address
>>>>
>>>> On 5/9/2018 2:56 PM, Shreyansh Jain wrote:
>>>>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>>>
>>>>> fle is already in virtual addressing mode - no need to perform
>>>>> address conversion for it.
>>>>>
>>>>> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
>>>>> Cc: akhil.goyal@nxp.com
>>>>>
>>>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>
>>> ...
>>>
>>>>>
>>>> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>>>
>>> Added Cc: stable@dpdk.org (try remembering this for next time, please).
>>
>> Thanks for doing it this time. I'll take care of this next time.
> 
> No worries. Actually, gcc 32 bits is broken:
> 
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1264:7:
> error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>    op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1));
> 
> Is this PMD supposed to be compatible for 32-bit targets?

Oh! This is bad. I will send you an update on this in a few minutes.
Ideally, the code was written for 64bit in mind - though, it should 
still be able to work (at least compile) for 32 bit.

> 
> Thanks,
> Pablo
> 
>>
>>>
>>> Applied to dpdk-next-crypto.
>>> Thanks,
>>>
>>> Pablo
>>>
> 

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

[Shreyansh Jain]

On Wednesday 09 May 2018 05:59 PM, Shreyansh Jain wrote:
> On Wednesday 09 May 2018 05:00 PM, De Lara Guarch, Pablo wrote:
>> Hi,
>>
>>> -----Original Message-----
>>> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]
>>> Sent: Wednesday, May 9, 2018 12:40 PM
>>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>>> Cc: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; Hemant Agrawal
>>> <hemant.agrawal@nxp.com>
>>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova 
>>> conversion for
>>> fle address
>>>
>>> On Wednesday 09 May 2018 03:54 PM, De Lara Guarch, Pablo wrote:
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>>>>> Sent: Wednesday, May 9, 2018 10:14 AM
>>>>> To: Shreyansh Jain <shreyansh.jain@nxp.com>; De Lara Guarch, Pablo
>>>>> <pablo.de.lara.guarch@intel.com>
>>>>> Cc: akhil.goyal@nxp.com; dev@dpdk.org; Hemant Agrawal
>>>>> <hemant.agrawal@nxp.com>
>>>>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova
>>>>> conversion for fle address
>>>>>
>>>>> On 5/9/2018 2:56 PM, Shreyansh Jain wrote:
>>>>>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>>>>
>>>>>> fle is already in virtual addressing mode - no need to perform
>>>>>> address conversion for it.
>>>>>>
>>>>>> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
>>>>>> Cc: akhil.goyal@nxp.com
>>>>>>
>>>>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>>
>>>> ...
>>>>
>>>>>>
>>>>> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>>>>
>>>> Added Cc: stable@dpdk.org (try remembering this for next time, please).
>>>
>>> Thanks for doing it this time. I'll take care of this next time.
>>
>> No worries. Actually, gcc 32 bits is broken:
>>
>> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1264:7:
>> error: cast to pointer from integer of different size 
>> [-Werror=int-to-pointer-cast]
>>    op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1));
>>
>> Is this PMD supposed to be compatible for 32-bit targets?
> 
> Oh! This is bad. I will send you an update on this in a few minutes.
> Ideally, the code was written for 64bit in mind - though, it should 
> still be able to work (at least compile) for 32 bit.

I have sent the v2 but I observe that the patchwork for v1 states 
'accepted' - not sure if I can change that back to 'superseded'.

If you have already applied and issued the pull request for next (and 
you won't be changing it), I will send a fix against that.

> 
>>
>> Thanks,
>> Pablo
>>
>>>
>>>>
>>>> Applied to dpdk-next-crypto.
>>>> Thanks,
>>>>
>>>> Pablo
>>>>
>>
> 

[dpdk-dev] [PATCH v2] crypto/dpaa2_sec: remove iova conversion for fle address

[Shreyansh Jain]

From: Hemant Agrawal <hemant.agrawal@nxp.com>

fle is already in virtual addressing mode - no need to perform
address conversion for it.

Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
Cc: akhil.goyal@nxp.com
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
v2:
 - fix 32 bit compilation issue

 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h     | 2 +-
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
index b09218f27..820759360 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
@@ -199,7 +199,7 @@ enum qbman_fd_format {
 } while (0)
 #define DPAA2_SET_FLE_INTERNAL_JD(fle, len) ((fle)->frc = (0x80000000 | (len)))
 #define DPAA2_GET_FLE_ADDR(fle)					\
-	(uint64_t)((((uint64_t)((fle)->addr_hi)) << 32) + (fle)->addr_lo)
+	(size_t)((((uint64_t)((fle)->addr_hi)) << 32) + (fle)->addr_lo)
 #define DPAA2_SET_FLE_ADDR(fle, addr) do { \
 	(fle)->addr_lo = lower_32_bits((size_t)addr);		\
 	(fle)->addr_hi = upper_32_bits((uint64_t)addr);		\
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 58cbce868..56fa969d3 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -1261,8 +1261,7 @@ sec_fd_to_mbuf(const struct qbman_fd *fd, uint8_t driver_id)
 		DPAA2_SEC_ERR("error: non inline buffer");
 		return NULL;
 	}
-	op = (struct rte_crypto_op *)DPAA2_IOVA_TO_VADDR(
-			DPAA2_GET_FLE_ADDR((fle - 1)));
+	op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1));
 
 	/* Prefeth op */
 	src = op->sym->m_src;
-- 
2.17.0

Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: remove iova conversion for fle address

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]
> Sent: Wednesday, May 9, 2018 1:43 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; akhil.goyal@nxp.com; stable@dpdk.org;
> hemant.agrawal@nxp.com
> Subject: [PATCH v2] crypto/dpaa2_sec: remove iova conversion for fle address
> 
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> fle is already in virtual addressing mode - no need to perform address conversion
> for it.
> 
> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
> Cc: akhil.goyal@nxp.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo