From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D416A034F; Thu, 29 Jul 2021 15:48:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B3CE410F5; Thu, 29 Jul 2021 15:48:24 +0200 (CEST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id DC92F410FC for ; Thu, 29 Jul 2021 15:48:22 +0200 (CEST) Received: by mail-wm1-f43.google.com with SMTP id m20-20020a05600c4f54b029024e75a15716so4093048wmq.2 for ; Thu, 29 Jul 2021 06:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=G/jfCtcbJ6BLOaGpVjVWJOm/TP/N6y7OQh8Cqcb1O/c=; b=poicuWIQDT3I5xY0fcqsryFikzC8Yiaqjv7Joa6Y+F1cy736ik/6ZVG0Y8gyvFqnp5 n7ByoOTZGB0lFjk0BBLclyzSde0C5q9jw4nRvezL8uIxMA/Kn8A0w4qWANij2CCYI65r zvYpCHtfRax27eVzqfuO6q9CH3j0Gn4VBht3Tol6uEUvyaLyxmCZcQqs7xuA+k4QZidy FzoyWLuqPSYtF/3BZfOEO1wru3kra+C3nKPVeudXDRpEvqa9yyVw3ruTcyUJo1je6MQV cBHZyKfiDg3mwCL35/PdF2zGrl/TVufsVIa4t5+aWGnaY6V7s4/4EKNO/ibfY6iqZGIP EBhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=G/jfCtcbJ6BLOaGpVjVWJOm/TP/N6y7OQh8Cqcb1O/c=; b=gVVHSVa1hnD6lxpOijdc79OfDJDefBhoVPuESYuvSq0zQKg6XL+ray14caY5tSBzTY zvSx2n+hjc0ErZU/ReEhozbDv6MhAoDYz/Ucq22SCQsK1yK+WdbghDmNZ8qARfa3hJcq Z1+dbpKaU7iKwaXco9pPRvfq3ZifnZVCJCNpC1ArCP+VekDjL+54pZ2IUZzuSLwtmO86 PD3CIk0AvJwXFEk/iBhkY11OMZ0P27SUooQZJkLXcVqhPhl6S/bgw7VKr1D6lJVS3+tZ C0EePrYVcMhPTGWwuyepBtAYIhig5SYedUwY0uixyeVlyCCcZMOHIoCQ5SltmdROYmeP YBYw== X-Gm-Message-State: AOAM53278RLJ0yiK9a53gKITS8mM+8AHMFjoGIHE7yXh0sGeiAexW1jm WZrLkm31Vk0YZauZMI67ns5W X-Google-Smtp-Source: ABdhPJy0fArNHPEciyX3Q6ygIVpojeiSWYK24AmiGF2RZxA6LvqFsJ4WB5r7gDAzZbPlMqc0W3uZ8A== X-Received: by 2002:a05:600c:19cb:: with SMTP id u11mr14640256wmq.1.1627566502691; Thu, 29 Jul 2021 06:48:22 -0700 (PDT) Received: from [192.168.1.63] (dsl-197-245-41-228.voxdsl.co.za. [197.245.41.228]) by smtp.gmail.com with UTF8SMTPSA id e3sm3490421wrw.51.2021.07.29.06.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 06:48:22 -0700 (PDT) Message-ID: Date: Thu, 29 Jul 2021 15:48:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Thomas Monjalon , Simon Horman Cc: dev@dpdk.org, david.marchand@redhat.com References: <20210716082314.33865-1-heinrich.kuhn@netronome.com> <20210716083545.34444-1-heinrich.kuhn@netronome.com> <2316407.RpMWIsvfqF@thomas> From: Heinrich Kuhn In-Reply-To: <2316407.RpMWIsvfqF@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 0/7] Refactor the NFP PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/07/23 11:18, Thomas Monjalon wrote: > 16/07/2021 10:35, Heinrich Kuhn: >> This patch set restructures the NFP PMD, aligning it more with the >> common layout adopted by most other PMD's. Although the changes look >> fairly large, functionally nothing is added or removed from the driver >> and the existing code is mostly just reorganized into the familiar >> structure seen in other PMD's. > > It seems this refactoring is destroying this firmware improvement: > https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781 > > Please rebase carefully, keeping the behaviour really intact. > >> Apart form adopting the common PMD layout >> this change should also aid in future feature development to the NFP >> PMD. The previous layout where most of the logic resided in a single >> file (nfp_net.c) would have become tedious to support going forward. > > Thanks Thomas, I actually finished this work earlier in the month and just missed your firmware helper addition. I posted v3 of this rework