From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C71243CB2; Thu, 14 Mar 2024 10:23:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 778E342E75; Thu, 14 Mar 2024 10:23:13 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2067.outbound.protection.outlook.com [40.107.94.67]) by mails.dpdk.org (Postfix) with ESMTP id 20299400D5; Thu, 14 Mar 2024 10:23:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=StIRqPpnN/qDgTc9kw4NAseoSTO5T9nNuVbVOfrIDnln9JUGCyLDGwOPrgwA+KVKLkAkhoBJqwrwxLAGrpmTI/+82A6o7UEcB5HEMDk+og8nIE4RpG4HGjd4YcyzzOHrAvNAcv8udMp4yydf/1SwFlpcJWczpkjYF08z0ZLJK+rod7GUEZZJeQ18S26OCzsuBQfH8HRkki3ZhY/SXSIhtAXqToPdCnip8MqR/nGt/pqNFPCwi8TJ2N8M4XHUuhWilJck8jbTtN/R9LB0NKVGEYkOXB29QWpbXUOZLCB589ulHrEMNg75O+KLJpXiI7D6NJ7hBZMXMmmpIU7UBjCrFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eAOFGJJAW/28/VCLCgQ5Dv7QTirZk1/5UYiGn5/PL7M=; b=AhSfL2b1UPutSbJdEpGeat2NI1aeeJZ0i/PWmEqIoiyIUwyIubs+Rrd+lzYawo7g/Pm7NRVG32QQH0Lc9Ct7dRD/rkZGVsragbNKDQnZxJKwwsQTMxYzB8wZzsQuxNa+SFNQ++HQNIJhiFFCvvv+VpHQirhqslZS8WT63++XNmNKSIhE4TX6k0bPONPt9Z9s8QlB9uJe83I7XMX0h0lYKThGpUwbPjD3yCHfvBa4MyP2vLiqTgbcFGN8IgTH3UE3SW1hw/RCrJHpeHbq9xFZ97gzT2gdGuffv/NYt1UmESpaevnfUfFoeNMUuhyPzpp5pDecOR7oqxdp7W1nRpmXuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eAOFGJJAW/28/VCLCgQ5Dv7QTirZk1/5UYiGn5/PL7M=; b=Kj6kItBWjG1JdguLteZXGpXBYqCuMmy3O5BLT20DzUGPJqwQh1HQDaSssz3dKNSnZqbQB2FBsDj5PjJ3iz0FeIIddR3Ac0pjYhdNfLrmvqKiUT51cKhJI+J9tvqGkh/bKjzGNyX4bfIJJu6fCxB9p9Z4PWtSXRJS6koQThy8IdY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB6120.namprd12.prod.outlook.com (2603:10b6:8:98::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Thu, 14 Mar 2024 09:23:09 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 09:23:08 +0000 Message-ID: Date: Thu, 14 Mar 2024 09:23:07 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] app/testpmd: fix error message for invalid option Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Aman Singh , Yuying Zhang , Ferruh Yigit References: <20240308144841.3615262-1-david.marchand@redhat.com> <20240314091708.1542769-1-david.marchand@redhat.com> <20240314091708.1542769-4-david.marchand@redhat.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240314091708.1542769-4-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0208.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB6120:EE_ X-MS-Office365-Filtering-Correlation-Id: 6054a0b7-9635-423b-e645-08dc44085cd3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7nPCIu2cVrFr1OlFA5woac17xKhGmGS+0a9vw3CQ4dRL1AdqWYsDA10yTWZ8nfoaO7dSzYFdwtWLLecs5QUriem1RnMXo56Ht6rqgSFwSaCX+WEZUsSuV9CcYXFVso5/c3xcvgcoMYa/9fo3Ty89YPaQCamye7qAAc8n9ywIeZHw7caPnvCBqQ/zPNgYlXOdUw5pkjK69nObzZHRl+91FMrYRi29mTcET3GWM5Gu3nQ4L8yijahDK9SA50ldiwO9dlg7K3q1bAZEeWouWVRS8BKQ2eKdbBZTIP13iPhCuXTeXyJu/ncmlxdXGxfZreVCzfW1efEpw+AuR6yHp37iL9+aL5tEIVHy9d5qZrNK+qxFIsngPk6WB68kK/Qqr0f9JSr7QIbWjvSO0F1PYUbbvyGr7MhBISUwssGXKuQ5MJXYnkbb7JdFc0KxWu61WXgiSX/kQE8OsY99QQB+GTKaaA7KF0hEJoWd3TSH9Gp6xwBsPezueatOqsfjvmx86Lkpy0WCHEhxtw6fqnu/NM29reM6RhuY2KHtVkgb61aTYk8uHbsL1Pp3V5ZZJYpuAK3wjx3sWZlzgrcGOFKzvuNtDUoIdP6z/A8z7BxuwImE5SX2keJDT4TRxQgkJIDSU+0WLbv5NJx+mkEL8cjrDB+9/xSz4/h3p/K6x0zuenHvST0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVNKV0xhcFJZcXVjQkZLNERmWlNBbFBxVUtlYlZjVHFZOWRCaG43QStwRzBP?= =?utf-8?B?aXN0VE1WUjhqbTQwQjhrVExudXBBcjNXUFlKMloxYzB3V1NyYlU3WDNoT1RL?= =?utf-8?B?YVlUNU12alF6Ly9QcmJ3VnQybnVmQTV0ekM0Y0d1TDdOekxZZWhoUDNzcVU0?= =?utf-8?B?L1lLZ2Y5eWlEandmUDlPLzhpbldmZWJDb0R4eGN0NUpKUlRidnVzai9HZSti?= =?utf-8?B?Z3M3aWtUOHlpUEk0bDI4YmZNZHd4cCtNYjNubmhmWUZzOERsRkdkdWRDbmM2?= =?utf-8?B?T3Z0ZWxDbkpxSWJRT2hzTjljNks4dHBxdUtJZVBOd3k0K25ncDZPM21lUlpV?= =?utf-8?B?bTZVZzlHcTcweXpFQ1B6MzlWVDlBb0NRUmhWY0laV3VjNHVjbDRueXJndzQ2?= =?utf-8?B?em53c1FTWmNWRzlzUHZBVG5BRkpFOGxpdlQ3SENVaUlraStoYjlYdEFRQ2xO?= =?utf-8?B?VklmTU1QaEYwZDFjVFVoaENKdzRSaXBhclQ4bGJycVdzNkpGdjBWUXNWdW1P?= =?utf-8?B?S1RTclVkV09QeFhKbXBzcGdTVXd3Z2w0VU5kSHBremdHR3pEdTNtZVhGSjFi?= =?utf-8?B?Z3pJTi9lNFVpUUxQdkFidUFiK1c0OUE2bUpxaG40NHFKTk9qNURRVnRkclU1?= =?utf-8?B?VmpiZCtSbjl6djhKREtlZUZBem8xWWVoNThxN2NDZzhGald4WEtteUM2WUtp?= =?utf-8?B?aW9yQ3lvWTVORWpIYzBhdCtzNnROSWF5NzVUMHErTlJyVGI3WDAwc21tamlo?= =?utf-8?B?eDFkWlhGMEVQM3lET0NRdkU1RXN3dHp3enhBSHU4bEJUYXM3Z21jbCtOcEo2?= =?utf-8?B?T1hTeXpYWWErZ3RWVkFMeWcyd3dOOVprTHM4UklEWDNaclN5bDFZdTk0THBI?= =?utf-8?B?aVRkVEJQWEZZRmdDbVZHcVRxd0dhMnExWmdwbHB0ZVVKcnVYUGcvMzJtd0FF?= =?utf-8?B?ODlOTDhmdE5JdGVCRkh3OGNnUmUwc2JmTjVmYmZWOFhvbmdyMWFqby9vaHJo?= =?utf-8?B?YW1idmZadmpSd1JkTW9STXFGQ2hXRkdZSm9QajNRRGx2Zi9lRFRMYmVmL2Q0?= =?utf-8?B?bnRaVWx0bnVDK0pLMkZBdHlRNnF4Ulh6NFRZOFpxckNWektjLzhmQWRVMXFh?= =?utf-8?B?YnhjRS95WmViT1lva2FoYTNUQWFyL04xRWJuMEFwcFMrVzl5YlQwUUdTQnJZ?= =?utf-8?B?UVhKU1YzVlJ2Y0RrcUFjZk1iRFpMRHp1azFLZ0Mrd1pCZlBkZk44ODRBWXVq?= =?utf-8?B?Nk9LRElwUjJwSkdyQ3I3RTZhVGtCM3V3ZXhPTWszT00rajdDZE9LMlh5cXM2?= =?utf-8?B?aDRLSit4VXNMVU9SRFdMQVlzZGxlRVdBRVE0aVBrZGVXSUNjRm5wN3VVbCsx?= =?utf-8?B?MHlKejRLL0hmWHJwVnpyS1RWTWJRbmZvNmVLaGR2cUpEL2hWQUxOWEpabWJl?= =?utf-8?B?OHIwam0yZURLWGc5azVuZzdSMFlrTStDRDZ0cU81SjZrYW4yT1VkZmFMalE2?= =?utf-8?B?WWR4dEpMY1h0TWJ0RG9OekYvT2gyWElpV3FiRUpKeEU0eEgyeDNqMjAvQ043?= =?utf-8?B?UkUyNVpZWTlINDRrT1hKVDFMSi9qRWtKd21lQkd5NEV0M3p6OHg3d1dSYkFT?= =?utf-8?B?MHFVaGRaTkMvVDVrMElxbjhLQ0NBZVQyYmlpSmhyMGhzNlVOdDNwbjVVMGJP?= =?utf-8?B?bDU0UFpVeEJnYkEvanRFd2dYZEpHTVdvMTRQRkdxaEhIekJHNnpJY2VrTWtS?= =?utf-8?B?V0NsTG5iYlhKWiswNnpyOFJMcFc0bUVvNG15bXNqTHpCR3BVN3lCaGpIZlRY?= =?utf-8?B?RU5ycHVkV2RQQTR3ZndtRTZNSDAzbTlZdzlOR3BTbVRCZnFaWFJMakljOGpa?= =?utf-8?B?eThlMGRZQkFUMXFUUmxXRGM3L2w0VXdoTHBCWnRwckFoMUpHQWZVaTd1aDJC?= =?utf-8?B?RFhiQjNSQWczdW5aVS9mS3RkSSsza280TWJKSjM3Nk5JcWE2YlVyMFVWYXNR?= =?utf-8?B?YmRQcjBzc0tOWjVvTUtMeTRYcjIvUkd2Zm9IZE9JSVN3VllzSU1vckhyL1Mv?= =?utf-8?B?NWxXMkRXTmQwQjFCM2lZa3VUS01oZzNQNFZCWG1TeW95Uzh6a2JOeWY3WXpN?= =?utf-8?Q?ikDJBcv2Z9KrzNKGtG/L+ig7Q?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6054a0b7-9635-423b-e645-08dc44085cd3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 09:23:08.9304 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yTjPCTSHu3m7HfMF39VFa9g2xeSYVKeQ0qjzKizjWj+m6sYCqc/3LX+vadZFguNb X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6120 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/14/2024 9:17 AM, David Marchand wrote: > """ > The variable optind is the index of the next element to be processed in > argv. The system initializes this value to 1. The caller can reset it > to 1 to restart scanning of the same argv, or when scanning a new > argument vector. > """ > > Hence, if an invalid option is passed through testpmd cmdline, getopt > returns '?' and increments optind to the next index in argv for a > subsequent call. > The message should log the previous index. > > Fixes: 8fad2e5ab2c5 ("app/testpmd: report invalid command line parameter") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > Acked-by: Ferruh Yigit