From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F824A034C; Mon, 12 Dec 2022 19:38:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22C1940687; Mon, 12 Dec 2022 19:38:43 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id 3C8DF40684 for ; Mon, 12 Dec 2022 19:38:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZbIQbz6hiuIISG7cLrShXXmzllEh4Xin/d7M6m5Yw8FWIWPd/+6nZyXnCTD2z3B8oceL/LdDgEjkxFGKZ4cZYBnh6iqjk03QM6NYWoxQhoVFnkYzT4a9aAydF9K0y0Kfv1fD2g5SAmDM4RHMEMt+KkCHcNdJX8ziuE/CbjO3JV8Kp72YB3+CIp2QWR2axR2hRc2DXWEIeM/jTj7AZlMKVkIp9dUtiDTc4QWOBWyfJvMi6JrGLR6Q0KYyONOF49BpgR1I/1g7an5+tpzjnuQkfZ08zm2BZ0fi1Kj3lyvmwIFRNjYA7wmzF9EyVBX27mtL8VMbZ+8b3fjRUTGQR0CUNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qZWjtV7LOVOtUMVqcyqvYb5AG4yTZaVyfUPMqn2olOU=; b=E/kxsGC1GXgPCiUOmddraK1aE7lg4xQZiGS+V2rVSf1WI6XyBwglRWPJ1c+X2r7yMPYvfLpfYJPr1K4LjlVzgXcHuGL5dV0nCuRDS70LxnUFnbLaLZVZo7/jaG3ul1siLmcFjYiLqsWsKxFdikgVObfKPmnJlqmrB/5pR3kKogquJz5eRr5Rc+PX6lFHHmrMaV0eII8Qyjtg05HTpuB2USWamx/h31xhTiZ9BSI3wU+LyIKGgkmAUZG+SquhTfuNkl3yQZPvRwB7cckw4kHEY/P5r+o2nhZL+duZjmwOBPZ64lwDzT8ofxb5g1hHjcLQcYFY5Ev+u9OeQqaD8RifYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qZWjtV7LOVOtUMVqcyqvYb5AG4yTZaVyfUPMqn2olOU=; b=N5AZ8TGwVthSq3WBl6Aw/hQQw5mUNxoB4O7gpG5Q9hc3jrI95EpZOKuveiFr/MGXSiZPEI9soS1CgH4PEEOU+k2H6ogxaYZCbnj3rF9njwhgyQQeNChONbA5SdfA3MBXB3rsoj6+J2a4KkEjuZNNf3nF022rVFDwK8MzuFSvo1I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4157.namprd12.prod.outlook.com (2603:10b6:208:1db::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Mon, 12 Dec 2022 18:38:36 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5880.019; Mon, 12 Dec 2022 18:38:36 +0000 Message-ID: Date: Mon, 12 Dec 2022 18:38:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 1/4] ethdev: add trace points Content-Language: en-US To: Ankur Dwivedi , dev@dpdk.org Cc: thomas@monjalon.net, mdr@ashroe.eu, orika@nvidia.com, ferruh.yigit@xilinx.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerinj@marvell.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, andrew.rybchenko@oktetlabs.ru, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, bruce.richardson@intel.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com References: <20220929102936.5490-1-adwivedi@marvell.com> <20221006151844.23483-1-adwivedi@marvell.com> <20221006151844.23483-2-adwivedi@marvell.com> From: Ferruh Yigit In-Reply-To: <20221006151844.23483-2-adwivedi@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0256.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4157:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d2529d4-0344-40c6-94fd-08dadc70142d X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y+m7luO0kLdmAHgfsIgWzs5d8jWLswdkOauXlEE1gB+BK6Lx48Avhom/zdRMfJ6sIlgAoqzoe8DiblPTDHGer/BCnBvXqVdJ5fWV4ra5bK8U6C9sqGu2vx+V+UTMjxra3zUiDVNrPVJ2X9A0PVtsoUk6k303BReXFJwRAgSLVVfC3WmWhsTGmLaWN1Pr0nXKIISItylZR/o/9zE58HZ2SXoWX1XhgTi6Ah9P8CroYagJ8YZu+t6Afs/r32I0QhOM5oCdKhBj1RYNKebWEnUCGdpJr/LpWnZuJohvc34+z3qpiQlFuVMMmsC83cEY2Hc2n6kuXUu8QWtajJ3mm2XzqAvLs58EilAJ+NBv0Oe7aRGYeR3sIIBnWenYXcO28g0tyqvGBl4p+anFMKQ1ZjUj67IwwjmxWvOMehnpgr2xNCxzjbhB+b1EI2AfSOG+Ek/QEn4sxtxytlGCJw8FbU9y8OrrukNDIPdR6IaMTZ1agG1cR4s2zDBMXdXpYx5mUBaBkJzPQrjf6PQ59zQ7wsL8mYcrUX954+ckhXIN3/K1SYXJq4JSjEH28UHMAkYIdv+8/WCRuBqsFazfCZ1iV9TM+wNYZlD7ywAMQ+NWvPH/wHxZVgtMvjyhQMG/tSKp2lIchNX0MvULEgiqHPDR73fj5jMahVqLqHJ7jkfIBUnOAU67ZWTjnjWr7lALTAlzEnnmsALtALsHieMJW1+PuG6xRV1Yk2FEBzR28BhHInuuGlY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(396003)(366004)(346002)(136003)(451199015)(31686004)(36756003)(31696002)(86362001)(83380400001)(38100700002)(478600001)(2616005)(6666004)(186003)(6512007)(6486002)(53546011)(26005)(6506007)(41300700001)(5660300002)(8676002)(66556008)(8936002)(66946007)(7406005)(7416002)(44832011)(66476007)(7336002)(7366002)(4326008)(4744005)(2906002)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajUxMlgzZEpFOHZ4MWczQ08vaUk5RTUzQVlwY2dsZEk2cDlLVXVBNEswMjUv?= =?utf-8?B?WUdOb3IvOGVSSUdKUXBCUXplNCtsbkNiNHFtdFk4Y1FNSFc2dzU2N1dJZUlj?= =?utf-8?B?WnlQelAwVVk1YktxMDgvUEFDK0IyRGlyYnZ3SW1yMm9TZzBtYWxWeFNFVFEv?= =?utf-8?B?cFBVSmZua250UzlnUFd3YTQrSlVjUGJpVUIrUWhlSUVua0pQRzR5d0E5QkFn?= =?utf-8?B?ZlBVdWRSTHJUY2M0bU8rcWlkQWZsd2hlWFBFaTJBQ0F4UzlNaGV1QWU0OHRq?= =?utf-8?B?OUo3L2tYZ2FqRjdXcytBSVlFbTFCb01pYjBtUEZhK1liRFJoV1RZU0FaQk8v?= =?utf-8?B?MDJFVm9DWWhIQmtvMG5LdFBNMTlPVVdTU0thZDErZVQvS28wbnhYUEkvWktU?= =?utf-8?B?RjhVbWpTc2JwVmJib2VSMlU0REN5ejlsejd2T1JZdXkzVmFPN2Zkb3lQd2hJ?= =?utf-8?B?N1dQTjlXTkhENE5kYm45WGJzMVNhUDFNV1JLemd3UWtCMHUyQnNETThqUUJY?= =?utf-8?B?amliTTNNbGlqRVdPY0Y2c0dmVkE1d3FRcVBKNXFUM1p3dDV1RjU1SmVKRnpx?= =?utf-8?B?WjFlOW5MQldUa0pIOGN6ZEw3Vzc0SkVESW9iZHZJL2pJYkYvY3VZY3ZlSUpC?= =?utf-8?B?aU54TnJKRmRWL013bG5TWS9SRmV2OWJETURNZ2dmNm9NZVlvWGtMVlk3dmpw?= =?utf-8?B?MGo2WWdhTHNRVTk5bUZpOEE4dERWU2FXQXdlSFR5eGdhNTZUM2lKdnJJVWVx?= =?utf-8?B?UjRPRjZTM25nZ3ZMdy9Sd2RidGRCT3hhN3plS3E1ajk5ajZqRk85QldyUWEy?= =?utf-8?B?M0xBcGJaWXowa3B6ZGhoRDQwcDFGVmlCeDVoRGk1K2YzUEFuSTRyZkQ3K3Bn?= =?utf-8?B?VTZ5THFYWUYrZlllK0JKLzVxWkZKcUhnQzV4d0hFendMbElwQktHZVVQa2lF?= =?utf-8?B?THU2UUYyZkxyWlpteEJDTkw1Y3hJNUptSlIwSGRZWlRyQVFkZzN1VmpVYUdh?= =?utf-8?B?V2lJUWRZWUJ0cXdLallmVU1wd0dwMG9uck4yYldXK09YeVB4cW02dXNHNWxF?= =?utf-8?B?QnZ6TmxUTDVDTzQ3NW5iUXhSdFBpSExYYTlaKzNkN2tKcURVYlBSWWQ3MlJP?= =?utf-8?B?RXB4bkIwd1JRRVF0KzRqNEllNVhtQ2NLcmQvRFRSZ3dVR1huWlpjN3BkaFJJ?= =?utf-8?B?Q0NjVElBRWFxaWxzUVdGQktTM0UrbVA2amx3enBkZHZ3djJXU0l3Uk8xUThx?= =?utf-8?B?WDd2cmpqM2dRUjhFY2cxWVdlRUtpeFBWSGl4QXdvUzNXZm5WQk01UGx3TjB5?= =?utf-8?B?OGMrSFJZYlBNUUY1QkpzUFNvN1Y2dmh3Ym83ck9GSWxselF1a0kyci9kdzlB?= =?utf-8?B?T1luazIyYzNseEhlWEN0bFRGNWs0LzZJcmxDNGlSNUFzb2gvRVVVaCs4UVF0?= =?utf-8?B?MTRIWTZXaFNTd0xCMkZ1STcweFNoOE5jQWdYQTdsVExuQ0lIdnRUSHoyZndB?= =?utf-8?B?N2V3aEZvYk13WThCWFJvT25TVXBWTE04Z3hSaUZMdHJSWDdFTjEvQThpNEhH?= =?utf-8?B?ci9sSkVaOHQ4VkZYWTlYMGhjUFJQV1E5Zm5qamZVbkFZTnhNSmVmRlJNYitS?= =?utf-8?B?S2VVT1IzTVlJTVNYUWVxOUI5VFMvWFo4eVhBenI0RFhMVnQ1bDVjZmpkWUlo?= =?utf-8?B?UEQ3L3R4T1ptRzJSU2lHQW8zaXFLS2QrTmhaRThqZC9XZFlKaHI1aFIyS0Z1?= =?utf-8?B?Zjc2bWhCVVFTSTNzTWlDNWZSZDdUcEcyeDF0b1hQbmRKdFAzOXRuVTdSck9t?= =?utf-8?B?TGlSVk9CZklhU2xaQ0d4T1g2RGJwKzNjR0dPWjFITTZqcHVTcnFiSjZhdUxs?= =?utf-8?B?dG5oblRFMWV1RWl6LzVBdGdZNGtxVVZ5N3BYU3VFMlVWSkRWWnR1a2JYOTd3?= =?utf-8?B?SExQRkRGM3BBaTUrbFBhTGhEeXhGYzI5NVR1TGs3aDJPYkFOd0NJSndxYzQ1?= =?utf-8?B?Si80Y044MkY4bUtjMnZ6NkJWTjlLcmNxSEtCQUllSFVQOEVLRXhQN1NVZGlO?= =?utf-8?B?V0RTcTV3L3lhTDIycm9jd0JGWGs3Y2JqbHNlR2Ntb21wdkM0Z0RTeGFSSXR2?= =?utf-8?Q?MBuLHeSnuEvIJzIW2A0Pk5YhP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d2529d4-0344-40c6-94fd-08dadc70142d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2022 18:38:36.1981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: afXEbNNcTKmSxSnwtTkAH6EaiLkuwx0J+sng4zkorJZLBZO+R0ySd09AoxiSM+di X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4157 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/6/2022 4:18 PM, Ankur Dwivedi wrote: > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map > index 3651ceb234..79d0b2ee1f 100644 > --- a/lib/ethdev/version.map > +++ b/lib/ethdev/version.map > @@ -319,4 +319,148 @@ INTERNAL { > rte_eth_representor_id_get; > rte_eth_switch_domain_alloc; > rte_eth_switch_domain_free; > + __rte_eth_trace_add_first_rx_callback; > + __rte_eth_trace_add_rx_callback; > + __rte_eth_trace_add_tx_callback; > + __rte_eth_trace_allmulticast_disable; These are not trace functions, but trace point objects, I see this is common usage in other libraries too, but can you please explain why we need to export the trace point objects from the .so file? For some datapath functions, which are static inline functions, trace point objects are need to be accessible by application, it is OK to export them, but they are very limited, but I am not clear why exporting all of them is required.