From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id 2E8F22BCE for ; Wed, 15 May 2019 18:53:28 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 904E640002 for ; Wed, 15 May 2019 18:53:27 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 7D85940003; Wed, 15 May 2019 18:53:27 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.1 X-Spam-Score: -0.9 Received: from [192.168.1.59] (host-90-232-127-248.mobileonline.telia.com [90.232.127.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 9895240002; Wed, 15 May 2019 18:53:25 +0200 (CEST) To: Bruce Richardson , dev@dpdk.org References: <20190514133702.2993-1-bruce.richardson@intel.com> <20190514133702.2993-2-bruce.richardson@intel.com> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: Date: Wed, 15 May 2019 18:53:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190514133702.2993-2-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [PATCH 2/2] build: add rdrand and rdseed checks to build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2019 16:53:28 -0000 On 2019-05-14 15:37, Bruce Richardson wrote: > The meson build never checked for the presence of rdrand and rdseed > instructions, while make build never checked for rdseed. Ensure builds > always have the appropriate checks - and therefore defines - for these > instructions. For runtime, we also add in rdseed to the list of known > bits returned from cpuid() instruction, so we can confirm its presence at > application init time. > > Signed-off-by: Bruce Richardson > --- Tested-by: Mattias Rönnblom From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 157A9A00E6 for ; Wed, 15 May 2019 18:53:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB2944C9D; Wed, 15 May 2019 18:53:29 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id 2E8F22BCE for ; Wed, 15 May 2019 18:53:28 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 904E640002 for ; Wed, 15 May 2019 18:53:27 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 7D85940003; Wed, 15 May 2019 18:53:27 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.1 X-Spam-Score: -0.9 Received: from [192.168.1.59] (host-90-232-127-248.mobileonline.telia.com [90.232.127.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 9895240002; Wed, 15 May 2019 18:53:25 +0200 (CEST) To: Bruce Richardson , dev@dpdk.org References: <20190514133702.2993-1-bruce.richardson@intel.com> <20190514133702.2993-2-bruce.richardson@intel.com> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: Date: Wed, 15 May 2019 18:53:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190514133702.2993-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [PATCH 2/2] build: add rdrand and rdseed checks to build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190515165324.fc__2L6l0UZO0bxL-ckRl-9p_VTleMvuqESfWpwEKQE@z> On 2019-05-14 15:37, Bruce Richardson wrote: > The meson build never checked for the presence of rdrand and rdseed > instructions, while make build never checked for rdseed. Ensure builds > always have the appropriate checks - and therefore defines - for these > instructions. For runtime, we also add in rdseed to the list of known > bits returned from cpuid() instruction, so we can confirm its presence at > application init time. > > Signed-off-by: Bruce Richardson > --- Tested-by: Mattias Rönnblom