From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D75F9A04B5; Wed, 30 Sep 2020 14:12:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B7401D41F; Wed, 30 Sep 2020 14:12:58 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 29F871D412 for ; Wed, 30 Sep 2020 14:12:56 +0200 (CEST) IronPort-SDR: UEa3ey8NpwWgeoq/T6yXqqVrOUNicZWuC+frWFKQmNr4mTILWx5SOOzAu//KlV7vTKeuTi9mEc wN6BwjUD5rdA== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="159769361" X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="159769361" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 05:12:47 -0700 IronPort-SDR: 2/7IcUjO9rzaegt7fJXdJ/Lk3yD9hAphjfHYT9ADeRg8h53oYwm6s1GYyu6Ies/EibL1SYO6B8 ZmiL0xxRLNzA== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="497265501" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.251.186]) ([10.213.251.186]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 05:12:34 -0700 To: Andrew Rybchenko , Thomas Monjalon , dev@dpdk.org Cc: Rosen Xu , Sachin Saxena , Liron Himi , "John W. Linville" , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Rahul Lakkireddy , Hemant Agrawal , Jeff Guo , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Akhil Goyal , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang References: <20200913220711.3768597-1-thomas@monjalon.net> <20200928231437.414489-1-thomas@monjalon.net> <20200928231437.414489-3-thomas@monjalon.net> <7a385eed-10e3-a807-5193-82aa3d99b292@solarflare.com> From: Ferruh Yigit Message-ID: Date: Wed, 30 Sep 2020 13:12:31 +0100 MIME-Version: 1.0 In-Reply-To: <7a385eed-10e3-a807-5193-82aa3d99b292@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 02/29] ethdev: allow drivers to return error on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2020 11:53 AM, Andrew Rybchenko wrote: > On 9/29/20 2:14 AM, Thomas Monjalon wrote: >> The device operation .dev_close was returning void. >> This driver interface is changed to return an int. >> >> Note that the API rte_eth_dev_close() is still returning void, >> although a deprecation notice is pending to change it as well. >> >> Signed-off-by: Thomas Monjalon >> Reviewed-by: Rosen Xu >> Reviewed-by: Sachin Saxena >> Reviewed-by: Liron Himi > > Reviewed-by: Andrew Rybchenko > Reviewed-by: Ferruh Yigit