From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 226024404F; Wed, 12 Jun 2024 17:07:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B1904111C; Wed, 12 Jun 2024 17:03:45 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 2CBAC40395 for ; Wed, 12 Jun 2024 17:03:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718204621; x=1749740621; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0I8XTws03SRy5uDP2F1TJXouzRzvCxfsajO4/pOgYPI=; b=KzPPkikiARmCUFVlKNKiN1ebpLnnVbFUjTm8CnaP2sYRA4gXZyT/qwJC ySHh+J700RvYFKJzk4DpzBj3/g8WDejKmS1w0QPdoNUJ+HQ/DWiSadL+c ZRbUyhdzCJw7KJ0SeGcxLT9pLkL9SNjKTQETg6lKAu5ECkd6Yb4ujxYVA t7iudrk/c5ZT0THyHQcPYpZzFPBY8QDREicLFDLqZOwU2LmmFh/D5ZYcT VHs0pEra5mHohwssE8qOJnGfkncJSrD7sjXH2VUP60Xl0rvZ4mxbV9Oij DtOEnCWeQOQao/sohFAZnAgZD954mPFRerOB6O2TYhGlLRM6/QhI905ST g==; X-CSE-ConnectionGUID: XAK7ipvxQLObYKxSNZz9IQ== X-CSE-MsgGUID: 9SiBAhtCRsasc4wWLULPfw== X-IronPort-AV: E=McAfee;i="6700,10204,11101"; a="32459175" X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="32459175" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2024 08:03:40 -0700 X-CSE-ConnectionGUID: bOyaTGgcQDiIb/ZlV40dOQ== X-CSE-MsgGUID: h2V5w6ScQGK8K3xpdVvc7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="39924912" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 12 Jun 2024 08:03:39 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Ian Stokes , bruce.richardson@intel.com, Jesse Brandeburg Subject: [PATCH v2 015/148] net/ice/base: refactor (non) bitmap declarations Date: Wed, 12 Jun 2024 16:00:09 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20240430154014.1026-1-ian.stokes@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Ian Stokes The firmware interface definition file mistakenly started using bitmap declarations for its storage in a couple of structures. The data structure contains a "bit-map" of bits that the hardware/firmware sets or reads but it's not a DECLARE_BITMAP style bitmap and it's not accessed with the set_bit/clear_bit operators, so stop declaring them that way. Signed-off-by: Jesse Brandeburg Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_adminq_cmd.h index a6a8210dd5..aaa4045d38 100644 --- a/drivers/net/ice/base/ice_adminq_cmd.h +++ b/drivers/net/ice/base/ice_adminq_cmd.h @@ -796,7 +796,7 @@ struct ice_aqc_recipe_data_elem { struct ice_aqc_recipe_to_profile { __le16 profile_id; u8 rsvd[6]; - ice_declare_bitmap(recipe_assoc, ICE_MAX_NUM_RECIPES); + u8 recipe_assoc[DIVIDE_AND_ROUND_UP(ICE_MAX_NUM_RECIPES, BITS_PER_BYTE)]; }; /* Add/Update/Remove/Get switch rules (indirect 0x02A0, 0x02A1, 0x02A2, 0x02A3) @@ -972,7 +972,7 @@ struct ice_sw_rule_vsi_list { /* Query VSI list command/response entry */ struct ice_sw_rule_vsi_list_query { __le16 index; - ice_declare_bitmap(vsi_list, ICE_MAX_VSI); + u8 vsi_list[DIVIDE_AND_ROUND_UP(ICE_MAX_VSI, BITS_PER_BYTE)]; }; #pragma pack() -- 2.43.0