* [dpdk-dev] [PATCH] net/nfp: fix resource leak
@ 2019-04-08 10:49 Alejandro Lucero
2019-04-08 10:49 ` Alejandro Lucero
2019-04-08 16:50 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 2 replies; 4+ messages in thread
From: Alejandro Lucero @ 2019-04-08 10:49 UTC (permalink / raw)
To: dev; +Cc: stable
Coverity issue: 32806
Fixes: ef28aa96e53b ("net/nfp: support multiprocess")
Cc: stable@dpdk.org
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index 33baa989b..0b9db974e 100644
--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
@@ -690,12 +690,16 @@ nfp_acquire_secondary_process_lock(struct nfp_pcie_user *desc)
lockfile = calloc(strlen(home_path) + strlen(lockname) + 1,
sizeof(char));
+ if (!lockfile)
+ return -ENOMEM;
+
strcat(lockfile, home_path);
strcat(lockfile, "/.lock_nfp_secondary");
desc->secondary_lock = open(lockfile, O_RDWR | O_CREAT | O_NONBLOCK,
0666);
if (desc->secondary_lock < 0) {
RTE_LOG(ERR, PMD, "NFP lock for secondary process failed\n");
+ free(lockfile);
return desc->secondary_lock;
}
@@ -707,6 +711,7 @@ nfp_acquire_secondary_process_lock(struct nfp_pcie_user *desc)
close(desc->secondary_lock);
}
+ free(lockfile);
return rc;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH] net/nfp: fix resource leak
2019-04-08 10:49 [dpdk-dev] [PATCH] net/nfp: fix resource leak Alejandro Lucero
@ 2019-04-08 10:49 ` Alejandro Lucero
2019-04-08 16:50 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
1 sibling, 0 replies; 4+ messages in thread
From: Alejandro Lucero @ 2019-04-08 10:49 UTC (permalink / raw)
To: dev; +Cc: stable
Coverity issue: 32806
Fixes: ef28aa96e53b ("net/nfp: support multiprocess")
Cc: stable@dpdk.org
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index 33baa989b..0b9db974e 100644
--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
@@ -690,12 +690,16 @@ nfp_acquire_secondary_process_lock(struct nfp_pcie_user *desc)
lockfile = calloc(strlen(home_path) + strlen(lockname) + 1,
sizeof(char));
+ if (!lockfile)
+ return -ENOMEM;
+
strcat(lockfile, home_path);
strcat(lockfile, "/.lock_nfp_secondary");
desc->secondary_lock = open(lockfile, O_RDWR | O_CREAT | O_NONBLOCK,
0666);
if (desc->secondary_lock < 0) {
RTE_LOG(ERR, PMD, "NFP lock for secondary process failed\n");
+ free(lockfile);
return desc->secondary_lock;
}
@@ -707,6 +711,7 @@ nfp_acquire_secondary_process_lock(struct nfp_pcie_user *desc)
close(desc->secondary_lock);
}
+ free(lockfile);
return rc;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix resource leak
2019-04-08 10:49 [dpdk-dev] [PATCH] net/nfp: fix resource leak Alejandro Lucero
2019-04-08 10:49 ` Alejandro Lucero
@ 2019-04-08 16:50 ` Ferruh Yigit
2019-04-08 16:50 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2019-04-08 16:50 UTC (permalink / raw)
To: Alejandro Lucero, dev; +Cc: stable
On 4/8/2019 11:49 AM, Alejandro Lucero wrote:
> Coverity issue: 32806
> Fixes: ef28aa96e53b ("net/nfp: support multiprocess")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-08 16:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 10:49 [dpdk-dev] [PATCH] net/nfp: fix resource leak Alejandro Lucero
2019-04-08 10:49 ` Alejandro Lucero
2019-04-08 16:50 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-08 16:50 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).