From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46650A00C3; Wed, 21 Sep 2022 19:55:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B30C41181; Wed, 21 Sep 2022 19:55:33 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2089.outbound.protection.outlook.com [40.107.243.89]) by mails.dpdk.org (Postfix) with ESMTP id 21654410E8 for ; Wed, 21 Sep 2022 19:55:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dz1HjiOlFb1uJQSRa0bQtiFdDbN3RcEyFzGzpLTbiaa7xfs13+YVTjN/6d9aWAU8A7yGvSuZ0XLIlZMAwzb0C2/9wEwnXZUHQjv108JONibpjO3/UaMsowGvcWC1dq6wxq0gJNJE9ElXt9s8iu0K0Tiow2P/l7mER+SzC08xVUh0DVDJPhxPMPGX479S+AE0DDChR7WxWqwEVcZfIPKw6ighLzOTOXk8yxlxmt0SVy/WosQO6el4bjZ8vKogmXbicp4QyTlFCPsJEAgNZB0U4wKBZgyAy8tusqpEkM0r5J05Urz0XXE/AyOULI1TbTrWBV4Woa1R+KZKZqkM1KMaPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fDdW43EkpIMDqEgLTQGHjOjkqNQ8oR1iRO36Q18wdu4=; b=ONSnSYYezLE89OhYNYX5LXmk6qlO+LaFbqIJdDGhgFPy9yiN0S1hmExApWtyhJi9VgtFYg1j/w67YR6vuSmpNSpPG1BfJ4IZcjbDLuhY2VZRUSjxHdyXfjxaBlJ8UYnfb2JRGpo3zANC+vjcoqGbJ18n1fqF6vAX62u7qK+aVja2fimqY545m7Yrz28XStcv1mEfjaFqvyt5/61ym3Wjodn8mATxV+CcMTHnEhoF0wA3OqRvyGDtiGcawKKFOQ7lpG/lW0fTsddMywCBzXyhUwpsvGWlGI0H12Ltc3BQhGe+y1Rg8DL+hajbKqTLixg1Jkqnm6/ND8aLe5p9GP0k9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=microsoft.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fDdW43EkpIMDqEgLTQGHjOjkqNQ8oR1iRO36Q18wdu4=; b=FQDX2yyh6mfa16aho9A430EfM2AwAb5G/rmtRbCDQwvfJfDXhY3gVkZdc+EbOTrFwnz/oxXxLQ92Gisk28yEDHusvli2OqU47NmfyaRvP5eKKu+eyPLZJ4AUDeYyfsKbFiEHeZlt1FsPIAsf3dqRHkDWYVfKbrUMYHiFUdJkOC4= Received: from BN9PR03CA0554.namprd03.prod.outlook.com (2603:10b6:408:138::19) by IA1PR02MB9205.namprd02.prod.outlook.com (2603:10b6:208:427::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 17:55:29 +0000 Received: from BN1NAM02FT025.eop-nam02.prod.protection.outlook.com (2603:10b6:408:138:cafe::60) by BN9PR03CA0554.outlook.office365.com (2603:10b6:408:138::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.17 via Frontend Transport; Wed, 21 Sep 2022 17:55:29 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT025.mail.protection.outlook.com (10.13.2.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 17:55:28 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 21 Sep 2022 18:55:27 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 21 Sep 2022 18:55:27 +0100 Envelope-to: ferruh.yigit@xilinx.com, longli@microsoft.com, dev@dpdk.org, sharmaajay@microsoft.com, sthemmin@microsoft.com Received: from [10.71.194.74] (port=26947) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1ob3wV-00073i-Pv; Wed, 21 Sep 2022 18:55:27 +0100 Message-ID: Date: Wed, 21 Sep 2022 18:55:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [Patch v7 11/18] net/mana: implement the hardware layer operations Content-Language: en-US To: , Ferruh Yigit CC: , Ajay Sharma , Stephen Hemminger References: <1662169260-4953-1-git-send-email-longli@linuxonhyperv.com> <1662169260-4953-12-git-send-email-longli@linuxonhyperv.com> From: Ferruh Yigit In-Reply-To: <1662169260-4953-12-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1NAM02FT025:EE_|IA1PR02MB9205:EE_ X-MS-Office365-Filtering-Correlation-Id: d62094a4-4e83-46a6-1b5c-08da9bfa785e X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zwmZ3g3rgWiv1USuSkRm2qVU7rxkAoKRDl0WVAOrVbazrqsBfSCLsc4Y/oDpY5kWH8faTz3uYqF0Qa3+kFj6Y/ugrhWrvuf6W+CU9q+mIpY99+JzVgt6ECkWQJooWguriNa5cOZnRce7UUEn+5uUIT58nlODjBx9hf1fpR8W9MD1JaGrq48phMMbgwt7UyXY4mbZey4BiQVl0slai6A8pM1zZAwzmQRyfG+CwaX3aiNxMCho1u9JTkV7Fy5aYpfbXlkYdDSXXDpiRVtOx+wfsWN0/ZwUqssN4Vs8KFxhsTSOHfklsIrqYj+hr5HsevJmrCvH904vdFdNUUKPiq147DPpAmo+jxJSK6CGnZFJvNZ13A5YG09QaMzMv8c+m1pcMzsKQHOBVWbrVP0t57sYeHkQ7Lc5EFfqmNlJ2sPdGmc0s/VfN2WPcZlOgjt9gqlyA65KL/8aCtRlOBNEQYjzOVDHKq+qf3oZG2kepHRrpu/cyNQwe540bbaEHNlEu6jTuLR8DNujpFmdrynX4FMIWnLs+BUrCXl0EMF+Aq1vgtd39HBZWhi4mjEbb8nPkW5yY6mZ1HkWqsL/4qmRyXEMZQYJy4pAqVlScZXtzosctfZScKlycn58fykumqZfnI0OW5BJ2rbV64E1Ohdi1UOhVra11XEzpuQltIn1Ivk0EWkfOfArz5X4Vu0LLF4nKW+TMEYh/S7TnFOTH0YzasUMhhsbMT4UwHruJk4pl5jO0YdooeKzwgLKrmlye2OCdo892kT6Gfobulo7TMTcU77Km+b0rqECclE0u59b1YNC9Zil+rsBaJYGorYKUIoOgFs4 X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(136003)(396003)(346002)(451199015)(46966006)(40470700004)(2616005)(336012)(47076005)(53546011)(40460700003)(44832011)(26005)(35950700001)(2906002)(9786002)(5660300002)(40480700001)(70586007)(498600001)(82310400005)(45080400002)(110136005)(54906003)(70206006)(41300700001)(8676002)(316002)(8936002)(4326008)(356005)(7636003)(82740400003)(31686004)(86362001)(31696002)(36756003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 17:55:28.8190 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d62094a4-4e83-46a6-1b5c-08da9bfa785e X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT025.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR02MB9205 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/3/2022 2:40 AM, longli@linuxonhyperv.com wrote: > > From: Long Li > > The hardware layer of MANA understands the device queue and doorbell > formats. Those functions are implemented for use by packet RX/TX code. > > Signed-off-by: Long Li > --- > Change log: > v2: > Remove unused header files. > Rename a camel case. > v5: > Use RTE_BIT32() instead of defining a new BIT() > v6: > add rte_rmb() after reading owner bits > > drivers/net/mana/gdma.c | 289 +++++++++++++++++++++++++++++++++++ > drivers/net/mana/mana.h | 183 ++++++++++++++++++++++ > drivers/net/mana/meson.build | 1 + > 3 files changed, 473 insertions(+) > create mode 100644 drivers/net/mana/gdma.c > <...> > + > +/* NDIS HASH Types */ > +#define BIT(nr) (1 << (nr)) > +#define NDIS_HASH_IPV4 BIT(0) > +#define NDIS_HASH_TCP_IPV4 BIT(1) > +#define NDIS_HASH_UDP_IPV4 BIT(2) > +#define NDIS_HASH_IPV6 BIT(3) > +#define NDIS_HASH_TCP_IPV6 BIT(4) > +#define NDIS_HASH_UDP_IPV6 BIT(5) > +#define NDIS_HASH_IPV6_EX BIT(6) > +#define NDIS_HASH_TCP_IPV6_EX BIT(7) > +#define NDIS_HASH_UDP_IPV6_EX BIT(8) v5 chagelog mentions that BIT converted to RTE_BIT32(), but I guess something went wrong and turned back to old code.