From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4204443F68; Thu, 2 May 2024 15:47:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B36D9402B2; Thu, 2 May 2024 15:47:52 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2084.outbound.protection.outlook.com [40.107.243.84]) by mails.dpdk.org (Postfix) with ESMTP id D94BA40299 for ; Thu, 2 May 2024 15:47:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gh5VuDH5F5VpdIfKZKkLFhgLgfPSW2h/42dOjpV+/ELLzKYAUoda/hVZmv+fR8kcVBF7kbX+CYa1HoC3s0SZQXzz/SItIn8/Sao4nYYZRd03PKgB/iDTt8RCJST2Zx00jJybGomeXJ8l40LWtO8V5aM4hWflFxTchxpTO4h//J7DXtlvgEAIeWZlov7SyuYS+0HGv/qMFYyjm1SGx3/q4227Fz7Ra1bEjnEfcEqLoZYDVGm+cTyn6ra/nTwkDSTkARLC7YaFUgcXr6CvGU4Tl6JyNzUYtsquZ0Vez/Bns1oj6LAxMVtJlyNjiIL/bUhrPmOzkC30CW1ZIwcvk+8e0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lTXbZHttmIjMo1XCumDhQh97A1IRrUoxsLui24TQM5c=; b=kBG8CVcm1EGUWWvw116JXtcR0HIkr/r+xYmp/PT9JBsqAnvSRLHARp0r56m+sX1V8FJ/jmVBkYOrVDLezzp5Hqf00WGsBXo195fxt2bFIAnTjnkq/9lMEJ2AOw/uimKY+mSq4FddKdeMn/F90IciqfDzzngn07f0NKbjHt1Z/si/XFNWj/ZyxxOo0Ba2nhxZLqt70KbNUdQY+/Vr+GP0cswQ1IA6RzyBy65WMFrKGq/uWXzAGDaAWV4vsrnNBQzsJGXIsm3Age23XIO5hT5Q9SvihV6C3FGVVvu1E6/VHn0HyEmLrzaLwyQiUDVA9Zfq8/Yc9BuK7I4jTDSKlpu28Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lTXbZHttmIjMo1XCumDhQh97A1IRrUoxsLui24TQM5c=; b=tNKz0Ej2265VO62QDhIDkKnkwlQEgskyB+g+9tH1TzMsXhCGSbc7ius1KiIUTU4/fv7W/xp/bL0zSkVs7QHXaxH9z0B5S5dD8a6l0dRVo7Jz18KBdOVJ7XTs9vx1bj3LG2OW9yOe2RqMtGPHucZSuOdzGtdjjVxL9Sx9v/5xABU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB7083.namprd12.prod.outlook.com (2603:10b6:a03:4ae::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.37; Thu, 2 May 2024 13:47:49 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7544.029; Thu, 2 May 2024 13:47:49 +0000 Message-ID: Date: Thu, 2 May 2024 14:47:45 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/af_packet: fix statistics To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , Stephen Hemminger Cc: dev@dpdk.org, "John W. Linville" , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= References: <20240430154129.7347-1-stephen@networkplumber.org> <9025199c-585c-4779-9f4e-360845707088@amd.com> <20240501094436.17ac8f00@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F411@smartserver.smartshare.dk> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F411@smartserver.smartshare.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0071.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB7083:EE_ X-MS-Office365-Filtering-Correlation-Id: b95eb9cf-09ce-45cf-3cca-08dc6aae7474 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YUdjeXNFWTVrR29OcHFVY0tQVEtjMUZ4VDRycFJuTVV5R25mbXNoUkxlTlRN?= =?utf-8?B?aWNTMmlzVnUrMFZTVnBOQXZWT1NxUzhMRWFQcm4rRmZrbmRRdkwvdFF3emda?= =?utf-8?B?Sk0rRGZPaUZpN1VTSjIyMjdnTitUeWlYSG9OSmI3SEZFdStUc09CL1ltSTlH?= =?utf-8?B?OTlEY3FveWl4WGZuSTZTQjQ3RElrMG0zN2lkTmRNZ29rcy94cVFWOHRLcFVn?= =?utf-8?B?eWdER2Vob2Y0QlJsenJjMUhUbGdCcUpQQWFxQXh1Y0FYUDRIRHc0NG0rMUNT?= =?utf-8?B?Zjhwemc3SWJvSXg1UUN6M3pjdWFnZWt6TnBzRG10Wm43NG4xcXoxZUp2eWtq?= =?utf-8?B?bVF6Rk1QVCtZOHVsaGdUdVdzR1dUbm42angzczhoK1pKbk1mL09jNGlzelZh?= =?utf-8?B?djAyNjZlWVdLQXlsd0VQSUhxd3Q1N0Uxei9BVkdiK1dDYjJnam11RzV6dXlP?= =?utf-8?B?cVJlNkdGaGRCRlZXSzZuTEFDSUNyQUZVR0tVbnNERGUrbUF2Z3dGWXFZNXdZ?= =?utf-8?B?Y0hoU1RZcHJ6cnhHOTd4OVFZUTI5bFJZYldmSUJEcGc4MllEdFNVK3d4Nndk?= =?utf-8?B?cXJUeG5hTVV5cHU4eW1GM09aRWw4c1BWZW5yaW1LNC9EOElKQzhMd3JsTkVZ?= =?utf-8?B?R0lCdUhXT3FtTFhweHF4TnA1RlB6SHpFWVI1RGhjT2praWVFSEFzNHJJazRY?= =?utf-8?B?Y01odEtPcDBKSzFqT3gxVjQyK2lNdk0xWHk4WUUxb2FMWTlrQVh3cmFWYXJD?= =?utf-8?B?YjkrMWJiR1diMHhTSGIwSGNoNWVnR21lNXRBU0tXK3hxSFZoL2FETXlxRmZt?= =?utf-8?B?RmtCeVgraUNxL25kUlZ1TUdCVDNJTmRUSk5XeWtKTHN2eThFajBqK3RBZHE2?= =?utf-8?B?Z0ltR1FnN3BPUy9mN3gwK3g4a1JoTCtEaEptMGxuK20rZmJzcjUrTlNPK1Vl?= =?utf-8?B?a0RScU5YSDF5WGd3MFk3dW01LzlUY3laQnV2UnBQd0RjdGsyR1NkVnJmQnhM?= =?utf-8?B?Q2tlWnUvNTU0ZUhVUS9pNlc4YndNRVlhM2FJbVBERkFRZ2FMVHp4Y3ppLytP?= =?utf-8?B?YnRkRGFjbVVZTEU4RVhuTXdZZHdrblVpemV1YmpOdXBHazJyYzJpdzNIMHUv?= =?utf-8?B?RmVqc3hzSU9JREZSVEtEWXVRZ3hKSm1nbVI1ME5kbWowa3FMbGYxSU5mWkJ6?= =?utf-8?B?Z1VFaUJXaS9rZ1RlM2FCZlY1R2hWOURmTnhjQzF5TlpaMkZkNWUzNWVQeVQy?= =?utf-8?B?RDgvTnBlTlZXb3hyeGNuN2dUd2NQL1llWVRzWnJVQ05DT1NORjd2S3h3eUVX?= =?utf-8?B?L0FjdU1IZzFRUkVVTE9SNktOeldXZWFSeVViYjlyUUxDYkY3TDNIV2ppa05u?= =?utf-8?B?RDNGS1VIbFNkZUJnR1NOM2NOUHRpVkV1cFljWk01dTVWL0h0SHdWdFIwNVRn?= =?utf-8?B?eG80MHUya3JmMDd0aXRiaHdCb2g3K21TVS82VmJvNDN6Z2txQ0lMTnVtQnpx?= =?utf-8?B?b0VRZTgvdDlzT1VwSm0xZFpGVDlBcmV2V25WMHNnOU9PNGpkR1dUWW5KYTgw?= =?utf-8?B?WVpIbEEyN0pYcEFCbDY3VUdkczhTUDk5QzBVRTZIUFpMTWJWd0xuVkcwWk81?= =?utf-8?B?U0dzZTcyRGdvdTVBRFhNMEZuTHcwS2svYzFqNXUwOEhPdml2UHRBdUErSTl6?= =?utf-8?B?bUlVSGVYUHNlWmVvWFVpTHVpMDZrU2dWNU1MZjQrRUdLNUxzSkhGU0xBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGtqaXJZVENLbXFyMEN5UjJITk9vbUMzdTVxQk5QdFdFTENHT2ZCRjZCS0tt?= =?utf-8?B?SHR2cTdJNkpadEhXbCtQSVpMQ0V3QmhtdWxtdG90STk5TlhJQ0tiVmZrY1lR?= =?utf-8?B?eXFMS09KTmhySGwrMzZqOVZDWS9oYS94Y2VEdUxEZVV6TlBsOUN0RkJYNTcw?= =?utf-8?B?cnRmSUcxejlUMVZPckk1Sm1mWW9DUm05NFArYnJDVFc2ZzBlR0JySkpXQkJY?= =?utf-8?B?aUYwbGZwN05UZW9PYTRRRnFsZnRtdDNmSVpBaFNSSDBZRitMS0lVTG92LzZa?= =?utf-8?B?VkR1M2tGbUwxQ2drbE4wZVkzSnpmWDh2SnBrZGJBeFRLbGU2bXhIT1RibERB?= =?utf-8?B?Y3AzejRLaWFva0YvVi96VmF6Z2hSUkJHUTd5bm1oN3BiZXNnVm1FVk5FSDl1?= =?utf-8?B?d1JBaVpWUkU4ajcrUHRLM3l3Z0RUOUkvVURnWjV0N3AxZHRpc1hYejFMNkRH?= =?utf-8?B?NitPdFd2MFErK1F0cmZFaW50Wm9Db1Y5eStqaUhGeWQwd1hhcE5GUFloZWQv?= =?utf-8?B?VEV1SFgzOW9qc3hWQkI0TmRMT29PM0FnMmhlSm1QeE9DQVpaaVAwWHV3dG4r?= =?utf-8?B?d2tCWVFXMlgweDB4L2lzU1l4c2F2S0gzYmpEMk5xd1F0VFZRakNLSUlXZ0JF?= =?utf-8?B?Wit3RXdrdW1uRFZCNTVDSVNDTVllRGZmSjRkbXdMNHdPSVZidnVNK25ORXBu?= =?utf-8?B?WGx3ZkwvVk5IbVhKenZMTm1KQmNXU05nTW1QVU1KMG4wV2JpSmNnTlNMdElW?= =?utf-8?B?QTNiTlE3L2g1aVJoeDFXUXBoNmd0djlOeW5WQ0duR0VNN0tTbUpyczZ6RnV3?= =?utf-8?B?T05jWkE3TUs2aVpHMEVjakVWOGVQMTRkNkFKZ08wT1IyOUJ3OFowNHlNdVc1?= =?utf-8?B?ckVuMGpBTEhUSHlKenl2SHpaTGZqSzc4b0xZbzViaCszeGtpTmQ4L0l6RkRE?= =?utf-8?B?eDJ4bVJ0dHhiQ0dCM3lXQVlzcW5ncC8xOG91cGtYYWFTNWo5bUZEM2kxcC9z?= =?utf-8?B?Q2d3Rm8rL0pNT1l0ek0yM2gybm9NODVpZkkwelA5K242OUF2VFZNd0Rlejdi?= =?utf-8?B?OG9kaVZkMGhUa2UyNENJUkd0MWJBc204bTFKN1RMSVlRRzRWc2tKZG11cm9J?= =?utf-8?B?OVArS1l6enVHcWFURFJGUFlCZ2w2SUoxa0M5WTB1aUFrVzhrM0ljWnZxNVlD?= =?utf-8?B?UXRER1FkcURvSTB4c2Z3NWE2MVVTNzZHRmdwZjdxNU5DZ0hCUzY5OEEydjM5?= =?utf-8?B?NG1OVWZ2OXREODQxRFZXR2MxdlhiMGZudVdwdEFFN3NwSEFTemMxaFZGYUdC?= =?utf-8?B?ZTM1cXA5NWNUUTc2aFJ4QW1DQWlnbFhtUHhZbkF3dGRNQStqK3lwRHhKNmZV?= =?utf-8?B?OERXNlRwa1BTSStUMEFoY213NHZ5RE42M1dEZE9tQlFDZU5QUlErZm5UVkJU?= =?utf-8?B?U2xnSE9VQkVEWjZtOU1IdVF0Lyt1KzZCUFFLRmVMdGhJTjZ5NkZHQUdqT2Fh?= =?utf-8?B?VHVMcm1yTFF6ajliVHN4ZWVrVzlUVGNGZXErZjdhZzBSdytHOE01WFVEUW5B?= =?utf-8?B?UEdGUmVRZm55TEhBRE00UEpxNUlWckVqdGFmV1lXYlIwTlQvcGdsc1hhWmZ0?= =?utf-8?B?S1JnT3VMNjM5eFRSOTN1QmFsdTZ6elBxYmhsMjN4WGhCbHJTdDRKZko4L3lL?= =?utf-8?B?bmE3U3gySWt3Wm9CT3g2OXB5SVRSMVRsU01uL2l3dEwwQ0hMOFMzYlVUZVdm?= =?utf-8?B?OWorbGovWXE0YStENkZRMjZZd1RhWTNNWkZWSlAyWDFIY0duT2pqUzZaT0VQ?= =?utf-8?B?N3BxL2E0Tlh4Nmh5bUxaMGtYRVJzLzNCTEY1ZmJDcTFyYVAwdVkyVVdHei95?= =?utf-8?B?UEVOWWUvandNTTA2bk4vM3hWTWhKS2pNdThmZUNTMXlNUmwwTGFsMnYya21t?= =?utf-8?B?YnVUeE5PUldhdGtNWkdudjJqd2FXMnVENzRsQ0VzMVhQQUpMSXoxdUFQaE1D?= =?utf-8?B?a3drZkp5cDVQcEtoQkNvb0VwZzlyKzFYRVJLbWtVUnpqa0Zrbk0yZjFBSUdZ?= =?utf-8?B?ZDI2d3dOZWRuVXNjMFBBVGQzM0NEUXR3TzlVc0NoRGhpQlJMc3JEU2pTeXBt?= =?utf-8?Q?wxFRUUtJoRQwuEZSMgEYRt+zV?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b95eb9cf-09ce-45cf-3cca-08dc6aae7474 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 13:47:49.3286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aqdd29tdL/Htg9+Fzd9V3rLRplFQz/490VR577kLl1IqDSxVkwYnUracAxBX0c8U X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7083 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/1/2024 7:18 PM, Morten Brørup wrote: >> From: Stephen Hemminger [mailto:stephen@networkplumber.org] >> Sent: Wednesday, 1 May 2024 18.45 >> >> On Wed, 1 May 2024 17:25:59 +0100 >> Ferruh Yigit wrote: >> >>>> - Remove the tx_error counter since it was not correct. >>>> When transmit ring is full it is not an error and >>>> the driver correctly returns only the number sent. >>>> >>> >>> nack >>> Transmit full is not only return case here. >>> There are actual errors continue to process relying this error >> calculation. >>> Also there are error cases like interface down. >>> Those error cases should be handled individually if we remove this. >>> I suggest split this change to separate patch. >> >> I see multiple drivers have copy/pasted same code and consider >> transmit full as an error. It is not. > > +1 > Transmit full is certainly not an error! > I am not referring to the transmit full case, there are error cases in the driver: - oversized packets - vlan inserting failure In above cases Tx loop continues, which relies at the end of the loop these packets will be counted as error. We can't just remove error counter, need to handle above. - poll on fd fails - poll on fd returns POLLERR (if down) In above cases driver Tx loop breaks and all remaining packets counted as error. - sendto() fails All packets sent to af_packet frame counted as error. As you can see there are real error cases which are handled in the driver. That is why instead of just removing error counter, I suggest handle it more properly in a separate patch. >> >> There should be a new statistic at ethdev layer that does record >> transmit full, and make it across all drivers, but that would have >> to wait for ABI change. > > What happens to these non-transmittable packets depend on the application. > Our application discards them and count them in a (per-port, per-queue) application level counter tx_nodescr, which eventually becomes IF-MIB::ifOutDiscards in SNMP. I think many applications behave similarly, so having an ethdev layer tx_nodescr counter might be helpful. > Other applications could try to retransmit them; if there are still no TX descriptors, they will be counted again. > > In case anyone gets funny ideas: The PMD should still not free those non-transmitted packet mbufs, because the application might want to treat them differently than the transmitted packets, e.g. for latency stats or packet capture. >