From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 540C3A054F; Wed, 25 May 2022 10:46:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6C6F400EF; Wed, 25 May 2022 10:46:00 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 5DAC2400D6 for ; Wed, 25 May 2022 10:46:00 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 49D668F; Wed, 25 May 2022 11:45:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 49D668F DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1653468359; bh=rMJm5jjOHEw5xhe0RtFPi0OVCKIGLYIjiQDpNSrOPR4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MXRkVTZnbctetaVW2HAHubE1nr7Yt10MbQPyfsQNOqTcVRHlju5gFTwwQfPDFS982 lVf2E1Lx0aNXf/HabVZmeeZUa+MnhTNeP6YyFYTvrCuHFGPAcOzrLX5QOqMbjsclu+ 3L6FS/TZPWNYAfmdeIYJQCNs1kopHw5Y+QU0UaOU= Message-ID: Date: Wed, 25 May 2022 11:45:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 6/9] net/vmxnet3: add version 6 support Content-Language: en-US To: Pankaj Gupta , jbehrens@vmware.com Cc: dev@dpdk.org References: <20220525004028.24938-1-pagupta@vmware.com> <20220525004028.24938-7-pagupta@vmware.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20220525004028.24938-7-pagupta@vmware.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Pankaj, On 5/25/22 03:40, Pankaj Gupta wrote: > VMXNET3 version 6 supports some new features, including but not limited to: > - Increased max MTU up to 9190 > - Increased max number of queues, both for Rx and Tx > - Removes power-of-two limitations > - Extended interrupt structures, required implementation for > additional number of queues > > Tested, using testpmd, for different hardware versions on ESXi 7.0 > Update 2. > > Signed-off-by: Pankaj Gupta > Reviewed-by: Jochen Behrens > --- > doc/guides/rel_notes/release_21_08.rst | 8 + > drivers/net/vmxnet3/base/vmxnet3_defs.h | 73 ++++++-- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 220 +++++++++++++++++------- > drivers/net/vmxnet3/vmxnet3_ethdev.h | 10 +- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +- > 5 files changed, 234 insertions(+), 79 deletions(-) > > diff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst > index 4027bd4390..810da2cc1f 100644 > --- a/doc/guides/rel_notes/release_21_08.rst > +++ b/doc/guides/rel_notes/release_21_08.rst > @@ -133,6 +133,14 @@ New Features > > * **Added RETA query and RETA update support for vmxnet3.** > > +* **Added vmxnet3 version 6 supports with some new features.** > + > + * Increased max MTU up to 9190 > + * Increased max number of queues, both for Rx and Tx > + * Removes power-of-two limitations > + * Extended interrupt structures, required implementation for additional number > +of queues > + I've realized that I don't understand the last bullet. Could you clarify it, please, and I'll update it on applying. Also, JFYI, you should update release notes for 22.07 release, not old release notes for 21.08. Don't worry about it now - I'll move and rephrase it on applying. Thanks, Andrew.