DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: John Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>
Cc: Luca Boccassi <bluca@debian.org>,
	David Marchand <david.marchand@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Fwd: [Bug 1185] enic: no longer accepting 2048 descriptor size in 20.11.6
Date: Wed, 15 Mar 2023 17:46:45 +0000	[thread overview]
Message-ID: <cb2cc82f-ccdc-0561-985a-8df8b3cafdca@redhat.com> (raw)
In-Reply-To: <bug-1185-3@http.bugs.dpdk.org/>

Hi John/Hyong Youb,

Not sure if you are monitoring dpdk bugzilla, but wanted to draw your 
attention to https://bugs.dpdk.org/show_bug.cgi?id=1185

Maybe you have some clues about it and if we need to backport the 
mentioned commit?

thanks,
Kevin.

-------- Forwarded Message --------
Subject: [Bug 1185] enic: no longer accepting 2048 descriptor size in 
20.11.6
Date: Wed, 15 Mar 2023 17:33:52 +0000
From: bugzilla@dpdk.org
To: dev@dpdk.org

https://bugs.dpdk.org/show_bug.cgi?id=1185

             Bug ID: 1185
            Summary: enic: no longer accepting 2048 descriptor size in
                     20.11.6
            Product: DPDK
            Version: 20.11
           Hardware: All
                 OS: All
             Status: UNCONFIRMED
           Severity: normal
           Priority: Normal
          Component: core
           Assignee: dev@dpdk.org
           Reporter: ktraynor@redhat.com
   Target Milestone: ---

Hi enic maintainers,

With openvswitch 2.15 using dpdk 20.11.6, enic driver is reporting that it
cannot accept setup with default OVS number of tx descriptors (2048).

2022-08-19T16:29:38.555Z|00204|dpdk|ERR|Invalid value for nb_tx_desc(=2048),
should be: <= 256, >= 64, and a product of 32

OVS has used 2048 as default for many years and the code in 20.11.6 does not
look like it changed much from previous releases either.

The commit below [0] on dpdk main branch (but not on 20.11 branch), 
changes how
max descriptor values are calculated.

So any idea why the 2048 can no longer be used with 20.11.6 ? some commit I
missed? different firmware?

or is it an incorrect calculation and the commit [0] is needed on stable
branches to correct this?

Thanks.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=2119876

[0]
commit 22572e84fbda2c195707ffbb0dd6af4433d7a219
Author: John Daley <johndale@cisco.com>
Date:   Fri Jan 28 09:58:13 2022 -0800

     net/enic: support max descriptors allowed by adapter

     Newer VIC adapters have the max number of supported RX and TX
     descriptors in their configuration. Use these values as the
     maximums.

     Signed-off-by: John Daley <johndale@cisco.com>
     Reviewed-by: Hyong Youb Kim <hyonkim@cisco.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.


  reply	other threads:[~2023-03-15 17:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 17:33 bugzilla
2023-03-15 17:46 ` Kevin Traynor [this message]
2023-03-15 17:53   ` John Daley (johndale)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb2cc82f-ccdc-0561-985a-8df8b3cafdca@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hyonkim@cisco.com \
    --cc=johndale@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).