From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D0B445C7A; Mon, 11 Nov 2024 10:31:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B8B940EDC; Mon, 11 Nov 2024 10:31:11 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2052.outbound.protection.outlook.com [40.107.212.52]) by mails.dpdk.org (Postfix) with ESMTP id C196D40EDC for ; Mon, 11 Nov 2024 10:31:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p9imM7zumWgrkoC7NqeuA5wEabkYSIFpwUnAbNoB9Eit8dAsMJZWxSWp0ngQ7aztZrXDG/si7msymVBoIkf6SAxbISjuXgbKny+ic1LPpMw0uPfFz5RNffXev0+PdJ86Qe35NqhSMAwIIVgJ3LzAnZt6nALZ4saI6Xy5IQn2cqTgdgWEdGSxSQTkXkSMPlOCZi9/e6RSCmvydF+RpxXlPEEOqaJsn5Ma12w1w4jfjQQBeJarT6Rmpb5Npm6J/+X6jJXORh62Merv83gBZORL2IvEOSYFY9WqvLoNtZfYdpKFOskE/8WqDK+L11AQlBk5gxPTqNCAx/p79ZSoNkbLWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jfStc4wgjfmw0E+ABqmgd3whW3lN4weroGGY37DwERc=; b=D17OJVfFCjK07iox+Jt1RqGcmKp0P+GdqyseCzMBISeHV+zY71lXZU857D6wyAm2NoLgtClnsibtopfFeZ7ELBdgapglg9nZ/AGicY0RpvxIUev74clessZIDa32zcQ5XStkxEqG2CmRX/L2OSH3L8A12/5vbc+vrzPAhkYqenvsqG/dzzNv85qLdinkB+ak1+W/KZJkyDb5rlFkPx0kH9wq9W8GevLiLvleVPDNlBnaSGmm10svFyQfy+9w6Qv9sw/GFfQ+nDj1x+z7IDVeybTo+R5y7HvIqklugewGPN/7Rohn9eF0oGqRVyEJau7zN1ODHY2OfaWEYqnDdnfrhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jfStc4wgjfmw0E+ABqmgd3whW3lN4weroGGY37DwERc=; b=r7nmVj2QYvVzuiuxboTwQrogApqIGv38ydKrulodw22EFvvNRLhbS42GNpZFeBxcJok/sN9s5kN6y0eGjKSNdHndfg6stIswdDqWqqI2xy6hlfxddZNS+Quc5Zkv5keumVCPHNUrlKimtMAAQBxnwkLLDHOd6HSqT0rbvTNbM8U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by IA1PR12MB8285.namprd12.prod.outlook.com (2603:10b6:208:3f6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26; Mon, 11 Nov 2024 09:31:07 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%3]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024 09:31:06 +0000 Message-ID: Date: Mon, 11 Nov 2024 09:31:01 +0000 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOetlOWkjTog562U5aSNOiBbUEFUQ0ggdjYgMDEvMTddIG5ldC9y?= =?UTF-8?Q?8169=3A_add_PMD_driver_skeleton?= To: =?UTF-8?B?546L6aKi?= , "dev@dpdk.org" Cc: "pro_nic_dpdk@realtek.com" References: <20241108121123.248797-1-howard_wang@realsil.com.cn> <20241108121123.248797-2-howard_wang@realsil.com.cn> <2a6d7c1303ec43f6a00dbbf0924c1bdd@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0145.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::6) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|IA1PR12MB8285:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ead83ca-6ffd-423a-a424-08dd02339168 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TEFQcTdTSlpEN1Nvdk5WOVJrTHgzOVJSbUxvZGFlQmFydS9MZTdmdTZ4YzFv?= =?utf-8?B?VkhwTGpqM0xmTERiSU90VnVjM1lsZEtvSU9hZ1JHQVpudUcySSs2Ykk3U2hK?= =?utf-8?B?YzNlZHhTK3Nia21tMnR4djVLNmZ1Y0gvQUc4UGtjNW9NWUVoZjFRZkE3RGJX?= =?utf-8?B?NVdHa1FQd1hLdzJBNGhsZWlvZjJLUHVxR1Axd0xEZHRETlFJYnF3Ny9PWnl1?= =?utf-8?B?OTdHdmhockdoYUpmVzVBVGtobHVzdU95TGNjeXRITVBLZmdxRWNNSVYzTndJ?= =?utf-8?B?K1F0M3R1VDQrcUZPY0lpTlFuWkxrMW9XVUxSZWZCcUFKNVFrWGR6MTJ4US8v?= =?utf-8?B?a0hRYk1iYUlvSTJjeXhPTlk2SC9aWUcxVDBFRHhSYU1xRldmbTdiMEVIZGFN?= =?utf-8?B?Njg3U2pJWTl6T1UrWERxZWluaGlob2x4dUw5ZjVqYTlSeVUrT2tvR1h6UTdX?= =?utf-8?B?M0FRUkIyNi9JMzhkNFZHcWVPdXFRbVFFQU5RU1NuY3kwQmRhYlRMa094YkQz?= =?utf-8?B?RU5vME0wbnhaZUo1eHJ1NGN0YkpoR2tnTDZwOVk2Z1pTY3ovY1B4Mm04TWxa?= =?utf-8?B?S1hqSWlIMU5PUkRWZ1EzUmRMNFdjUXdYVXFiNUZ0SVJJdTVQTzRJRVcvRDcw?= =?utf-8?B?d1dReHhSSXpaWEhoblIra3JKK2owTlVKbnZUVmtVV1FKUXJ2WFZjNDBqZWIx?= =?utf-8?B?ZFE0ck8zNDA5Nk9kdS9WS0s4Z2FEVlNmM0lob0lIREx0R0loR0pIZGhJTitP?= =?utf-8?B?ZFM5Q003cnpLajgzNUdPWVRoZDNkYzVjdGRKaTZrZTVHS2pjQVBybHZxYlkx?= =?utf-8?B?T1ZXaDBwaldPaTFVenpBRDZ2Vjh3ZFlBRHBQZGZmTTRjaUd5MDJSNkg1N0kv?= =?utf-8?B?SDZEQXc5MVFpR29vK05UeHB0b2NuNlAwTitsaE05NElrVEFGMDRMYjg0aHUw?= =?utf-8?B?V29MMFIzWVZLOU5aZWpsUFBJZVc0Nk52c2cxZ1lQSE9YUngydGlFcExvNXcr?= =?utf-8?B?K2VuRVY5OVRUbllDNHB2RWJ6SEZxUnh1R2ViRkdpYTRjM1YvRVRPRzByRk1R?= =?utf-8?B?bzVMZEJCT05tVlZmSFRkaFRJK1BqdVF4WEtzTXBEeEY5YmVuMDZ1MlJ0M2Z0?= =?utf-8?B?bkIvTjBKdzhxZFZyMnNnd1pJa01idEFHTzJVdjhsZ2tPU1VyWW10QkhqVmJC?= =?utf-8?B?cEprWTYzNmh5NmcwdDUvMTcxSDBhTExhL3hNUkZGUVFuUDFtWFZReGQzeTlo?= =?utf-8?B?YUNSbm1LSUh3MmRhTjR3U2toak5XNGMyelQ4M1dMQzVmcjFzaTRGYUlac29a?= =?utf-8?B?dlUvZmJVVGZzbG8zRHdyd3VyZU4reVpzMCtWSFFTRWkwbStWODVuYWh5WW9t?= =?utf-8?B?RnNaOEsvNzkyb0l4RG9XOU5uY1NmWnBxMmRGbTNVS1RPT3BGYldOcllLblUr?= =?utf-8?B?bjhVQmN4VEtPYXRoMzRtYzROMDIwUG56d2doYnNmd1NsUDhpNWtTUzFHblBS?= =?utf-8?B?OWJGOTZQL01aaTdhTVhlSkJSNVNqZDdFczhvcmJwdmhVUnBpL1BKeWIvdFhY?= =?utf-8?B?aGhwQm9SaTh2QjJrajRmY25USmlEcXJmcm4vdXNDaU5ueU9xcmxiaGY3WTA0?= =?utf-8?B?cGp5bElWRXU1TlZLbDM4em1pUkxTWnVTOXdoOXkrR1FzdEtBRFJERmswTXJl?= =?utf-8?B?eUJUWWYyQ0NZZEo3QzVxS00yUk92eGNPbGE4VCt5aGd4a09WTnZSc2tTNjUz?= =?utf-8?Q?knpWkd+BjZMjTwMHANYzuhXoAVnB53btpszcE1u?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MG42OWhacUE4WXFQKzQrcTVYbjNLeUpkNzFIZzRiZ1MyZ3ozZjZtZXdqNUx6?= =?utf-8?B?Uk9lcktITVRwand4cStQRUJoU3hnK21ibmtlT2NIangwZWkvcy9ROTVqWitR?= =?utf-8?B?c1o4b2w3YVBWRGljSzFkbjBQS3lTVlFUTU5ya09VZk8wYjFDYS9jbFVoVndL?= =?utf-8?B?RENmUkxkWTRDMnE3aElpeGd6M1Jhb0tzaUxBTHc4d0FtbGkzZ3V6NkwvdHFy?= =?utf-8?B?Yy9JMUNEdXZsQVhXbUZGV0ExeStwVndWcDMydnZHbTBTMCtteFozWXNVaU94?= =?utf-8?B?QVFDd3BHVUExang1UURKWllYSytOb1dRWE1iZDA4bDh2UlcyUng2R0lReFE0?= =?utf-8?B?a29rSk9oRVhBYVFVOGJiUStnTmZQNjlyQW9wTnhmKzM1NVh3MVljUS9zUzNv?= =?utf-8?B?dlVESm5KelhXNHRpY3Q3QkdNY285UllRNk51Vmx4ellNNzRvamVoeGdXVmlz?= =?utf-8?B?amxrdm5RakhYMUljcHc1eFNzSlgxdUlQbkt2NnAxakRLWlhDcG9KVldkRWlI?= =?utf-8?B?cGkvWitxT3I0ZVlaM1hYOEhSSFlzOU5lMXNNRFF0aXpTQWx1ODB5d1NDcUJq?= =?utf-8?B?Yi9DczRGMUZqbm8xNWkyN2hXWGx5QnZhak9yRlMrK1cwR21oeis3NGJCMm0v?= =?utf-8?B?Z3JFNUJ0UG5tTVBheUNsUyszTHdkMFJoU3dPZ0RXd0VOQ3pZSmRBeldTdmFj?= =?utf-8?B?QUxKRG1JL2lnL3RUWXdwMUUzeDVuREh5K1dpTHNKZmNiMVNFZElyU2JFVU1a?= =?utf-8?B?M0Z3OTlBcGw2bDdLUUpVNlBYcGcxRkNTckJHVjlPZnBaNUhreXQvNEVuekY3?= =?utf-8?B?bVRaeS8xWVVBcXNkM3hoL3RvNzRMRlBRendLQmdwTm13UHM4THp6bkE5d0pB?= =?utf-8?B?Z1NIV2FuV3hhbCtZSDJZbWFlQ012Ymk0NElmbGVoZm9BOE5hZ2R6MWRKenNQ?= =?utf-8?B?bSs1WllWN3FsMVpPa1Boc0FBQzNpK1hJclMvQ0lGVE42NGo5NkhXMm5iaHZO?= =?utf-8?B?ZTloVVVhMjU5dWt2QU14SDlVR2Z3NXdRWEFYdUZ3NlVmRTM3OWYxakFpeG13?= =?utf-8?B?WlNlYmdscUJXZElxM09aOG9yWEtNWlU1YjBML3ZuUjZFWngzK1JBV1dDNnpk?= =?utf-8?B?TGtaN0prY1N2Wk9waUdQTnVnb2JqdDQ5THpwa1dyQ0wrN1paM0pSd2pIa3Jj?= =?utf-8?B?ekNhY21WWlNuczRtNEpJcnp1K3pUT0JBb2J5aEpUc2lVbi9CZmt1M1RkOWd5?= =?utf-8?B?QnVlcDlpVEtBaHZUN2NGOHZzSTBPUzFEdjB5S3R6YWxFYms0SDQ2NHp6Sld0?= =?utf-8?B?cmFjRlAxd0s5T2MwSUU5Z1VmU0s3TDZMNFFMZGpGQ05sRVRqMmN2RXIxaHBs?= =?utf-8?B?UmR1ek45WndnZ1hybkNtd054NFZuaXZTZE5JTlZHZEFRVjRXZCsyVXdnU1Bt?= =?utf-8?B?WFp5MUJPcWJNU0hKb3N5a2Q1dmNSZy9HTFl3L2pHSXY0OVlTeC9WWmJYNUl0?= =?utf-8?B?VU5ZUVl4U0ppWjhDMFBSMFJOMWtHYVRnWE93a1h1NEJheno5dDJ2ZUtaTStX?= =?utf-8?B?VEM1Y20wdkdjS0lHdVVKaVpRenFaLzFvRDhGazFXVFQ1dHpwTHhXcE1aZjF3?= =?utf-8?B?UHBESHRzbm9sY0RaR25aWC9PcE5GVzJxQ0t2bkxqRUdnaEtrMEtpZG4wVzl6?= =?utf-8?B?Q2xYc002Mllmck9haXQ0ODY0elQ1MzMwd2tldHJCeWVIYXk3WEF4b3JPbTRM?= =?utf-8?B?WHFEMGZKT3ZTQjloS2c0bGwvTmJGR1VSeFVEZGxmUi8rcUQ1WWRZb3lYTFF3?= =?utf-8?B?RGNkNWQrRTJGZmVTNnBXamdyY2tHQTdrSlh5bUlWQVIxTysyT25DNHE5cjkx?= =?utf-8?B?SmZiR2s3Vk9KcXZNUERXUDVqQkQvdHc1UjRjWWFaWlVrM0o1UmI1NFNQaGcw?= =?utf-8?B?M1lGQWp0aWRWcDlnOEp5ODlqVnNkVy9Bc0VXYzRwbFFxZTFVbTl0aGdWQUtj?= =?utf-8?B?UURNNHNNbkltbjU4V3dzbHpvdTl2a3c2VXk0a0o1L2swZlVEUnN6N2Zva0s5?= =?utf-8?B?NkJpYTQ0UVlhOUZOZWhHMEMwbTJiNWJNNTBRUVRRUnUwbFhReS9EOUVWaHdM?= =?utf-8?Q?SRH3cmxEMU3lYyb5hL3BCzX8r?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ead83ca-6ffd-423a-a424-08dd02339168 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 09:31:06.4683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4zGi4WLYbEchntMD0cRJ7Dt9UPZiK4Peyvt1uRoo56hk7LiGjZ8p4Dq+Osq57tmM X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8285 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/11/2024 9:24 AM, 王颢 wrote: > Dear > > Ahh, I see, matching is simple for 8125, device id and product number is same :), is it same for all supported devices? > > ===> Yes, up until now, the Linux inbox driver has been doing it this way too. > Got it, so OK to keep the code as it is, thanks for the clarification. > I am not sure if there is a misunderstanding but change requests are mostly simple ones, I expect they can be fixed in one or two days, and I am hopping to merge the driver in -rc2 or -rc3 at worst. > ===> I will do it as soon as possible. I have had a fever recently, so it might be a bit slow. > Great, thanks. (And I hope you get better soon ;) > > Best Regards, > Howard Wang > > -----邮件原件----- > 发件人: Ferruh Yigit > 发送时间: 2024年11月11日 17:09 > 收件人: 王颢 ; dev@dpdk.org > 抄送: pro_nic_dpdk@realtek.com > 主题: Re: 答复: [PATCH v6 01/17] net/r8169: add PMD driver skeleton > > > External mail. > > > > On 11/11/2024 3:46 AM, 王颢 wrote: >> Dear Ferruh, >> >> I apologize for the issues that have arisen during the process of splitting a complete driver into several small patches. >> >> On 11/8/2024 12:11 PM, Howard Wang wrote: >>> Meson build infrastructure, r8169_ethdev minimal skeleton, header >>> with Realtek NIC device and vendor IDs. >>> >>> Signed-off-by: Howard Wang >> >> <...> >> >> ===> I referred to Atlantic’s approach for this, and as a matter of fact, his first commit message was done in this manner. >> I will think again about how it should be modified. >> > > No problem with the commit splits and orders, thanks for the update there. > > Only comment in this patch is 'RTL_DEV_PRIVATE' macro is not used in the patch and it can be added when you use the macro, so this is a simple issue. > > Also I have a comment that build fails after some patchs, this also does not require changing how patch split done, just fix build after each patch. > > I am not sure if there is a misunderstanding but change requests are mostly simple ones, I expect they can be fixed in one or two days, and I am hopping to merge the driver in -rc2 or -rc3 at worst. > >> net/atlantic: add PMD driver skeleton >> Makefile/meson build infrastructure, atl_ethdev minimal skeleton, >> header with aquantia aQtion NIC device and vendor IDs. >> >> Signed-off-by: Igor Russkikh >> Signed-off-by: Pavel Belous >> >> >> >> What do you think to add macros for the PCI device IDs, naming them makes it easier to know which devices are supported. >> >> ===> Regarding the device ID, for 0x8125, the supported device is indeed called 8125. So, should we name a macro like DEVICE_ID_RTL8125 to replace it? >> > > > Ahh, I see, matching is simple for 8125, device id and product number is same :), is it same for all supported devices? > { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8125) }, > { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8162) }, > { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8126) }, > { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x5000) }, > >> >> Best regards, >> Howard Wang >> >> -----邮件原件----- >> 发件人: Ferruh Yigit >> 发送时间: 2024年11月11日 8:15 >> 收件人: 王颢 ; dev@dpdk.org >> 抄送: pro_nic_dpdk@realtek.com >> 主题: Re: [PATCH v6 01/17] net/r8169: add PMD driver skeleton >> >> >> External mail. >> >> >> >> On 11/8/2024 12:11 PM, Howard Wang wrote: >>> Meson build infrastructure, r8169_ethdev minimal skeleton, header >>> with Realtek NIC device and vendor IDs. >>> >>> Signed-off-by: Howard Wang >> >> <...> >> >>> +/* >>> + * The set of PCI devices this driver supports */ static const >>> +struct rte_pci_id pci_id_r8169_map[] = { >>> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8125) }, >>> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8162) }, >>> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8126) }, >>> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x5000) }, >>> >> >> What do you think to add macros for the PCI device IDs, naming them makes it easier to know which devices are supported. >> >> <...> >> >>> + >>> +#define RTL_DEV_PRIVATE(eth_dev) \ >>> + ((struct rtl_adapter *)((eth_dev)->data->dev_private)) >>> + >>> >> >> This macro is only used a few patches later, what do you think to add this macro when used? >> >> >