From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 85B105595 for ; Sat, 22 Oct 2016 13:24:14 +0200 (CEST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B89BCC0567A2; Sat, 22 Oct 2016 11:24:13 +0000 (UTC) Received: from [10.36.6.56] (vpn1-6-56.ams2.redhat.com [10.36.6.56]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9MBOAv0001901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 22 Oct 2016 07:24:11 -0400 To: Jan Blunck , dev@dpdk.org References: <1476956223-30308-1-git-send-email-jblunck@infradead.org> Cc: pablo.de.lara.guarch@intel.com, thomas.monjalon@6wind.com, yuanhan.liu@linux.intel.com, john.mcnamara@intel.com From: Maxime Coquelin Message-ID: Date: Sat, 22 Oct 2016 13:24:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1476956223-30308-1-git-send-email-jblunck@infradead.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sat, 22 Oct 2016 11:24:14 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/2] drivers: add name alias registration for rte_driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2016 11:24:14 -0000 On 10/20/2016 11:37 AM, Jan Blunck wrote: > This adds infrastructure for drivers to allow being requested by an alias > so that a renamed driver can still get loaded by its legacy name. > > Signed-off-by: Jan Blunck > --- > lib/librte_eal/common/eal_common_vdev.c | 8 ++++++++ > lib/librte_eal/common/include/rte_dev.h | 1 + > lib/librte_eal/common/include/rte_vdev.h | 5 +++++ > 3 files changed, 14 insertions(+) Hi Jan, This looks good to me, once Pablo's comment is taken into account, feel free to add my: Reviewed-by: Maxime Coquelin Thanks for doing the work! Maxime