From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 101EE43A22; Wed, 31 Jan 2024 18:54:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88DC942D9A; Wed, 31 Jan 2024 18:54:10 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2052.outbound.protection.outlook.com [40.107.92.52]) by mails.dpdk.org (Postfix) with ESMTP id 4092D4068E for ; Wed, 31 Jan 2024 18:54:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UUU4CFC1h2Jbo87mHo6NL8wRliq3dzIHvD7CBaW3Q8wD7s026jcDcOeWUCnQLdprZDqUTFr+TVF6unijV/9NsxGgGEk6+Zt4ozC6Gt0hPbHMMDx7LLJJl0H5z+zQaophU+MOODjDjn/7oImpwqZkirm60sDMU5RAVk+/k8lc3/MZIil9mP0j2tPXdy68psRmVylfiF4tilp4AV0A2xIMPc9Apiajo5C9MURL7xe+pmEgcd5u2RnzcY+sOxGWQjGBjoCrduYo9liopBIfnpSQxZppz81JKkTSRjr1N1SZt/t6D1toea3vRD6MQhpJIWsg+CsMJfg0DKk6QQ1OJSA14Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QcA2AVim3FNPkOeA/WPypmOjvR3yNTXYq8HXwoehJc8=; b=hi7/ET+3m+nPE+w6eqRnmU870lc1vDSEr5jMX3uhQnTqC6FMSA7rnsLLpaFT4uDKLWm0q8WfhE9vORhFcsWzE1vnwLNXm5jrj3g1PnGRaZO2zvyyoXKbp6yZFHyrp8Ow+B8hcyJhT8P/UrOuAfYhfUH9FdgslGlLYbLNu5YOdeIeznEQnlc5SZpOBTrU6eSaUIDGJNBNZckDt7UUvuc+tFtcri3c/OK20vsgCjYNnARUMwImoMQxWP7/32n3w7c6Hd8CyGRq1GH10/arPclw68JSiHkw9u/TJJf0O/8cewJQsGwyT3gJM6V/Bp80IYomVLZdkyhegu07qbohJZrLyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QcA2AVim3FNPkOeA/WPypmOjvR3yNTXYq8HXwoehJc8=; b=oTsMRaXct01r5wlBmrSPMmT9x+zCbPbIQmRHVJJWk8kgfg9q5LOJiG4FVVZBBx/1DiB4NUUbGANiHLgXgsvDOJC/C6yDhEpHYQ5UOAGNQkTNCToYOKADU15X181P+bp2Uby9nPwMKuTWqxjiXY33pc0NaeB7eFTFMeRrEz4DjZc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN0PR12MB6367.namprd12.prod.outlook.com (2603:10b6:208:3d3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.34; Wed, 31 Jan 2024 17:54:07 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7249.023; Wed, 31 Jan 2024 17:54:06 +0000 Message-ID: Date: Wed, 31 Jan 2024 17:54:02 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] ethdev: add compare item Content-Language: en-US To: Ori Kam , Suanming Mou , Aman Singh , Yuying Zhang , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko Cc: "dev@dpdk.org" References: <20231219013337.531548-1-suanmingm@nvidia.com> <20240115091318.1053433-1-suanmingm@nvidia.com> <20240115091318.1053433-3-suanmingm@nvidia.com> <2594409d-5c8d-4347-b724-eece2b775376@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0104.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN0PR12MB6367:EE_ X-MS-Office365-Filtering-Correlation-Id: a9e2c2f4-9bc7-4843-7ea7-08dc22859e9a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wy1sF4uI+lW68JpcoBFB4/Jh045W1DLTdfcciOP/NvHQgBWRjtWn3woFAJJg7SjN/Sb0u+mgBhsooPRMAeH+MltDhH+GK7YBEYnPtGvhaGelJFrwh3NPJTCVk8vfamLKnXvBxt8wbbTN2pblXhJNacBFQjnECGexBZthSFu1y0WZ2+8rBGCrw6uvn4k8jQRLB7EmnVtGNzlZBSml+7t9u8fSWkf4BTrAYxIpy9zGmPml49R5I4AxwvF2F9Jh+4rqYFuFGVXs4fGAqWEI54DavqCiKr39xWcFwjypld5aTJP4JY1gXWJoRhikK8pRrFLhKj0hrBL3ASsjsZiEEu2CJ3/+DDgIOx4hRkdA6rSu43AkczIquU/MycaP9dvgSdcA+DGUqMYysPTpNRRnxgI9cBtbRkByLeoXKYNMwriNiHE1ZMA8ji7EbtiXF/n7fqZo6sENbd/gnQYumtnAakYNPRs9K0M+646YkiVc3TWrUhKLuxXDmh1Hx/9f4tdp5RyL6NXmQjS/LICdrkyd3AJs3fDyIrYK2NAD515v3uisqArc+GoOxSs62viAR+fuE8hywkUdbahlh8Z1MHyA6pnmGjBzIhRbuF9eFXS7a/48RcxSDU2kOjmspc+sKAYLBSaul6peR7oCfaIaSu8pZhH2mGQ4dbAXiBWPmUzQb0pRXOB/KkOFJIxdjXPTePCoIWKhOBtvOuMskK4z4U1GYmN7HQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(136003)(346002)(396003)(39860400002)(230273577357003)(230173577357003)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(316002)(8936002)(44832011)(8676002)(4326008)(110136005)(2906002)(31696002)(5660300002)(86362001)(66946007)(66556008)(66476007)(36756003)(6486002)(38100700002)(53546011)(6666004)(6512007)(6506007)(83380400001)(478600001)(2616005)(26005)(41300700001)(31686004)(21314003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cy9JSnVBSW9VQzl6dkJxSzNjMWNBRG8rZDMwcGc3S3RvdW9rb3ZjSlBGS1la?= =?utf-8?B?eVhuVlFXNlRIcG44Skk1d2JRUVErSjJ4SWk5UVhmcjJ1NFRwek00Q2twUGJ6?= =?utf-8?B?cW9hRHUxTGZYRFU3MHZKU2xRMHZ4LzMxeldTWUt3VGs4ZElXY3lLYlAzMUJM?= =?utf-8?B?WTMyZGhHNzVvWUVZNENuMjFlTk9UanF3MTIwNkZoSW5zdG1HNC8rNy9xbWx1?= =?utf-8?B?dHhvbEpHeERYZHVOT0pLQ3FrekxhZ2U1Zk9wRFZ2QlZqME95enZJT3ZwbmhY?= =?utf-8?B?VHY1d29BekRIdE5xOWxkdU51Tzl3UTBHVHM3OUplVkdFZnZYRDZYNm1NOS9y?= =?utf-8?B?SlRtdktnZFZYQkgvaFZycCtja290QVJlMjNXb25NY1hJMG9TR0dNOHZhTTFz?= =?utf-8?B?WTRUYUJwdUMvdVpPQjdERGhyYzN0aDRZZStQMkd6QUFOVkgvTVJKVFMxY0w0?= =?utf-8?B?NTF6aEhMdENMRXkxREtUR0g0TDlrRVB6Y016V0JOTmpHVHV1eitlZkMvN3gv?= =?utf-8?B?OEx6RVFBMFIxVWtCV0ZhMkZhSUZ2cGwvb3Jtb1pHQnV6bFNnekdJcDBxVGRU?= =?utf-8?B?YnRDMFB1TVl3ZFJrUnNyaWVrSFhCRkhCdG93YWFWSUdYdG93ZHpIM2p2R3JR?= =?utf-8?B?VWR0Z051VGxJNjdTZDJQY3NXYnZqSTN1WUVUS0M2dmplVi9nZjF1V0htVmcy?= =?utf-8?B?OEk1T0dTSmN0VXU0V3FLSjJJRFBwZnJVSDZmZWswU1pRZXlJRkRtejc4K0NJ?= =?utf-8?B?T3ZVQ2RXZXBob3l5UkYxUmkrQzBvdkNudXBYaU9IZzZNNHMzdVNjb29jS3p4?= =?utf-8?B?VFlndFI2OGJRc2NtcnJVcDl0dGVYVDBZT0ZObzh1TkdmR0plSVNEUEFacW1K?= =?utf-8?B?UFFMWEtFY0U4cnh2cEs0cGFGYVV5L2RIekpDRElIalJRMFpnZW5nQ2hBeGlD?= =?utf-8?B?UmVpd3FxK1I5RzN2QnZJTVFWYUNWcnE0MnN2VXRoaFE1MVlNWEUyYnlzQVox?= =?utf-8?B?YmV6by82TWpVOVMydmExbERwUHlrVC9vdE04bTRrUmpsLzFUd0FrSXkyYjZI?= =?utf-8?B?NVZ3S0tiNzVtbFhqT3VIVUJYZlF5ZFpNenVhWXdJK0s1R1Y2TmUvMXBzOTY1?= =?utf-8?B?b05HQ1JwNDZVUEVzV2xmWnpPNDFFZFRqemJDNloxQmd1N3poMUpXUDVKeGFW?= =?utf-8?B?MUFKbWwrZ3gzenJ6dXAra1JoQTYvOHJCL2FKRU9nM0tjUHQ1UWhlVEZrR1RT?= =?utf-8?B?RkVqMFA3YTJxVjUrVjdqZVVLNXhUcmh2K3hHT05CTXIzbFRoT1R1NitSdko4?= =?utf-8?B?cFZpWG9jdHA3MUVvVXI1d1BtOEFkODF5TDhyc0pJcUYxVUlkTUttTlBLSFhH?= =?utf-8?B?WEFGbkNzU3hra2VJZ2N1clQ3dit1bzc3cnNEaHl1Y1hjRmFZQkc0Q0Y5VnF2?= =?utf-8?B?WG5hakQxaWhkZkZKT1d3M2xDWUlqOXVES0ZoVW9ySGRUMHVXMElCUEdVc1ZE?= =?utf-8?B?NnRQWUFXZGRueGd2T3BZdjIvMFREOFFOWWlGUi90R3VYUGZGWWQzQjkyQlRO?= =?utf-8?B?N3p0eTJzNHB6L2NqcUJJdDh2dUdqTXZleFFpemtjNTlPeU1nWTNuMldUZE9G?= =?utf-8?B?QmF6V21wUUluM3R2Uk0vZ09SS1JzWWVjQTZDbTN5Q1hWeW9jOVhFdlBZa0la?= =?utf-8?B?NGkyaXA2bXl1bjh2YWcvWVpPNlZJVEtxQ29OK3VLQ2tDR1RralR2YThrdW1o?= =?utf-8?B?Y1NNMTVyNkM5SGVHSjAzUUMrRUdpT1FYV0JFTlU4VTY1T1JGenpGWFpkSnJu?= =?utf-8?B?R09lZmtWa1FhVFVRbmRzV0pxaTRNU29IK1ZiV09raG9aT2dFMWpTTWtJZ1E1?= =?utf-8?B?d29wSHFNK1hhOUNad1BLNisxY0VxdjJyL1JSelNwR0RORFpBQjdLWlY5SHY5?= =?utf-8?B?blVPMmpUckNBQUpFRzA3REpHOE1DN2VXQWFKR2lpOXNOSVFJREtCNUl1UEIy?= =?utf-8?B?MXUycVZNdVFlWHZFbmRHUVdjTHJkY3drSGpPbVpjM2hKeUk1cXZIZWdEUnlJ?= =?utf-8?B?OXpmT2JGRVgvb0ZTanFGcDhqS1UzN3c4Yllvak9GWU1yY3RnRWhqMmZiZHVs?= =?utf-8?Q?O4h2xehVm+4/kYwz6IBk5vL7Z?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9e2c2f4-9bc7-4843-7ea7-08dc22859e9a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 17:54:06.8572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3onZMip4piJtdgeXj16OW4QYeKoCNYeZMdfoE+c6tSSlm+Wld1ydgrBn1GoPlx3x X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6367 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/31/2024 5:43 PM, Ori Kam wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, January 31, 2024 6:46 PM >> Subject: Re: [PATCH v3 2/3] ethdev: add compare item >> >> On 1/31/2024 3:56 PM, Ori Kam wrote: >>> Hi >>> >>>> -----Original Message----- >>>> From: Suanming Mou >>>> Sent: Wednesday, January 31, 2024 4:48 AM >>>> >>>> Hi, >>>> >>>>> -----Original Message----- >>>>> From: Ferruh Yigit >>>>> Sent: Wednesday, January 31, 2024 1:34 AM >>>>> To: Suanming Mou ; Ori Kam >>>> ; >>>>> Aman Singh ; Yuying Zhang >>>>> ; NBU-Contact-Thomas Monjalon (EXTERNAL) >>>>> ; Andrew Rybchenko >>>>> >>>>> Cc: dev@dpdk.org >>>>> Subject: Re: [PATCH v3 2/3] ethdev: add compare item >>>>> >>>>> On 1/15/2024 9:13 AM, Suanming Mou wrote: >>>>>> The new item type is added for the case user wants to match traffic >>>>>> based on packet field compare result with other fields or immediate >>>>>> value. >>>>>> >>>>>> e.g. take advantage the compare item user will be able to accumulate a >>>>>> IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag >>>>>> register, then compare the tag register with IPv4 header total length >>>>>> to understand the packet has payload or not. >>>>>> >>>>> >>>>> ack, above sample makes it easier to understand. >>>>> >>>>> This patch is adding testpmd commands, can you please provide some >>>> sample >>>>> commands in commit log? >>>>> The more samples are better, as far as I remember there was a testpmd >>>>> documentation that documents the sample usages, can you please check >>>> for it? >>> >>> [Snip ..] >>> >>>>> >>>>>> +/** >>>>>> + * @warning >>>>>> + * @b EXPERIMENTAL: this structure may change without prior notice >>>>>> + * >>>>>> + * Field description for packet field. >>>>>> + */ >>>>>> +struct rte_flow_field_data { >>>>>> + enum rte_flow_field_id field; /**< Field or memory type ID. */ >>>>>> + union { >>>>>> + struct { >>>>>> + /** Encapsulation level and tag index or flex item >>>>> handle. */ >>>>>> + union { >>>>>> + struct { >>>>>> + /** >>>>>> + * Packet encapsulation level >>>> containing >>>>>> + * the field to modify. >>>>>> + * >>>>>> + * - @p 0 requests the default >>>> behavior. >>>>>> + * Depending on the packet type, it >>>>>> + * can mean outermost, innermost >>>> or >>>>>> + * anything in between. >>>>>> + * >>>>>> + * It basically stands for the >>>>>> + * innermost encapsulation level. >>>>>> + * Modification can be performed >>>>>> + * according to PMD and device >>>>>> + * capabilities. >>>>>> + * >>>>>> + * - @p 1 requests modification to be >>>>>> + * performed on the outermost >>>> packet >>>>>> + * encapsulation level. >>>>>> + * >>>>>> + * - @p 2 and subsequent values >>>>> request >>>>>> + * modification to be performed on >>>>>> + * the specified inner packet >>>>>> + * encapsulation level, from >>>>>> + * outermost to innermost (lower to >>>>>> + * higher values). >>>>>> + * >>>>>> + * Values other than @p 0 are not >>>>>> + * necessarily supported. >>>>>> + * >>>>>> + * @note that for MPLS field, >>>>>> + * encapsulation level also include >>>>>> + * tunnel since MPLS may appear in >>>>>> + * outer, inner or tunnel. >>>>>> + */ >>>>>> + uint8_t level; >>>>>> + union { >>>>>> + /** >>>>>> + * Tag index array inside >>>>>> + * encapsulation level. >>>>>> + * Used for VLAN, MPLS or >>>> TAG >>>>> types. >>>>>> + */ >>>>>> + uint8_t tag_index; >>>>>> + /** >>>>>> + * Geneve option identifier. >>>>>> + * Relevant only for >>>>>> + * >>>>> RTE_FLOW_FIELD_GENEVE_OPT_XXXX >>>>>> + * modification type. >>>>>> + */ >>>>>> + struct { >>>>>> + /** >>>>>> + * Geneve option >>>> type. >>>>>> + */ >>>>>> + uint8_t type; >>>>>> + /** >>>>>> + * Geneve option >>>> class. >>>>>> + */ >>>>>> + rte_be16_t class_id; >>>>>> + }; >>>>>> + }; >>>>>> + }; >>>>>> + struct rte_flow_item_flex_handle >>>> *flex_handle; >>>>>> + }; >>>>>> + /** Number of bits to skip from a field. */ >>>>>> + uint32_t offset; >>>>>> + }; >>>>>> + /** >>>>>> + * Immediate value for RTE_FLOW_FIELD_VALUE, presented >>>> in >>>>> the >>>>>> + * same byte order and length as in relevant >>>> rte_flow_item_xxx. >>>>>> + * The immediate source bitfield offset is inherited from >>>>>> + * the destination's one. >>>>>> + */ >>>>>> + uint8_t value[16]; >>>>>> + /** >>>>>> + * Memory address for RTE_FLOW_FIELD_POINTER, memory >>>>> layout >>>>>> + * should be the same as for relevant field in the >>>>>> + * rte_flow_item_xxx structure. >>>>>> + */ >>>>>> + void *pvalue; >>>>>> + }; >>>>>> +}; >>>>>> + >>>>>> >>>>> >>>>> I am aware that you are just moving the above struct, but it is nested too >>>> much >>>>> which is making it hard to read. >>>>> >>>>> As you are touching it, can we extract some structs and make this struct >> less >>>>> nested, what do you think? >>>>> Of course it needs to be done in separate patch, as a preperation/clean- >> up >>>> patch >>>>> before moving it around. >>>> >>>> Agree the struct maybe a bit nested. But not sure how it was discussed >>>> before during the last new member was added... @Ori, Do you have any >> idea >>>> about this? >>>> >>> >>> As far as I remember, it was never discussed, >>> >>> I think for this series we should keep it as is, and revise it later. >>> >> >> If you don't want to make this set more complex with this, that is OK as >> long as it is addressed at some point. > > Agree, > If you have suggestions, I will be more than happy to hear. > For the struct? Simply extracting the inner structs as named structs to reduce the nested structs, does this make sense?