From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7F30A09FD; Fri, 18 Dec 2020 14:34:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8E27CAE3; Fri, 18 Dec 2020 14:34:43 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 97562CAE3 for ; Fri, 18 Dec 2020 14:34:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608298479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KMyoqfYQKMKEmr309b6CJ/hHu+f1GUsHN/Mv5vmkf50=; b=J0XIL/9U1Ogb34z2Se/g2jFaO23IRPDfVEXw4Ou4eFZI+hRkr/xTi7YFtKJf+oF5rxo+ub Z1Ax4aEGGD/A4VTWYK/CcoERfYV3T+jZ6FGI15d6e7WHCN4nq+wHG3Xykd986kEYI7bdYG Z8Z2exna9M9aE3SEcsPM9VV1zDfKOnU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-f4MS1in1OFWrouPPCDiH6A-1; Fri, 18 Dec 2020 08:34:37 -0500 X-MC-Unique: f4MS1in1OFWrouPPCDiH6A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B984879516 for ; Fri, 18 Dec 2020 13:34:36 +0000 (UTC) Received: from ovpn-114-80.ams2.redhat.com (ovpn-114-80.ams2.redhat.com [10.36.114.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id E9ED52C169 for ; Fri, 18 Dec 2020 13:34:35 +0000 (UTC) Message-ID: From: Balazs Nemeth To: dev@dpdk.org Date: Fri, 18 Dec 2020 14:34:35 +0100 User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=bnemeth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] Potential regression introduced by commit b10231aed1edb9 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Commit b10231aed1edb9 introduces a regression on my systems. I have a "QLogic Corp. FastLinQ QL41000 Series 10/25/40/50GbE Controller" which relies on the qede driver. Calling rte_eth_promiscuous_enable(portid) followed by rte_eth_allmulticast_enable(port_id) causes no packets to arrive from my generator. It's important to add that the generator doesn't specifically target the mac of the port. I presume that irrespective of dst mac, if a port is put into promiscuous mode, all packets should arrive and rte_eth_allmulticast_enable should not cause *less* packets to arrive. Am I missing something? It seems that b10231aed1edb9 inadvertently introduced either a bug or a pretty significant change in semantics (at least for qede)? Regards, Balazs