* [dpdk-dev] Potential regression introduced by commit b10231aed1edb9 @ 2020-12-18 13:34 Balazs Nemeth 2020-12-29 13:29 ` Igor Russkikh 0 siblings, 1 reply; 5+ messages in thread From: Balazs Nemeth @ 2020-12-18 13:34 UTC (permalink / raw) To: dev Hi, Commit b10231aed1edb9 introduces a regression on my systems. I have a "QLogic Corp. FastLinQ QL41000 Series 10/25/40/50GbE Controller" which relies on the qede driver. Calling rte_eth_promiscuous_enable(portid) followed by rte_eth_allmulticast_enable(port_id) causes no packets to arrive from my generator. It's important to add that the generator doesn't specifically target the mac of the port. I presume that irrespective of dst mac, if a port is put into promiscuous mode, all packets should arrive and rte_eth_allmulticast_enable should not cause *less* packets to arrive. Am I missing something? It seems that b10231aed1edb9 inadvertently introduced either a bug or a pretty significant change in semantics (at least for qede)? Regards, Balazs ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] Potential regression introduced by commit b10231aed1edb9 2020-12-18 13:34 [dpdk-dev] Potential regression introduced by commit b10231aed1edb9 Balazs Nemeth @ 2020-12-29 13:29 ` Igor Russkikh 2020-12-30 12:51 ` Devendra Singh Rawat 0 siblings, 1 reply; 5+ messages in thread From: Igor Russkikh @ 2020-12-29 13:29 UTC (permalink / raw) To: Balazs Nemeth, dev, Devendra Singh Rawat, Rasesh Mody Hi Balazs, This could be a regression for your specific usecase. The commit itself tried to fix promisc as is. Adding more people to comment/investigate here. Devendra, could it be that we don't consider subsequent calls of promisc_enabled + allmulti_enable ? On 18/12/2020 2:34 pm, Balazs Nemeth wrote: > Hi, > > Commit b10231aed1edb9 introduces a regression on my systems. I have a > "QLogic Corp. FastLinQ QL41000 Series 10/25/40/50GbE Controller" which > relies on the qede driver. Calling rte_eth_promiscuous_enable(portid) > followed by rte_eth_allmulticast_enable(port_id) causes no packets to > arrive from my generator. It's important to add that the generator > doesn't specifically target the mac of the port. I presume that > irrespective of dst mac, if a port is put into promiscuous mode, all > packets should arrive and rte_eth_allmulticast_enable should not cause > *less* packets to arrive. Am I missing something? It seems that > b10231aed1edb9 inadvertently introduced either a bug or a pretty > significant change in semantics (at least for qede)? > > Regards, > Balazs > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] Potential regression introduced by commit b10231aed1edb9 2020-12-29 13:29 ` Igor Russkikh @ 2020-12-30 12:51 ` Devendra Singh Rawat 2020-12-30 12:55 ` Balazs Nemeth 0 siblings, 1 reply; 5+ messages in thread From: Devendra Singh Rawat @ 2020-12-30 12:51 UTC (permalink / raw) To: Igor Russkikh, Balazs Nemeth, dev, Rasesh Mody Adding more people to comment/investigate here. Devendra, could it be that we don't consider subsequent calls of promisc_enabled + allmulti_enable ? Devendra >> yes, I agree that as long as promiscuous mode is enabled for a port, all traffic should be accepted even if allmulticast is enabled latter. Commit b10231aed1edb9 shouldn't have changed that. I will prepare a fix patch for this. On 18/12/2020 2:34 pm, Balazs Nemeth wrote: > Hi, > > introduces a regression on my systems. I have a > "QLogic Corp. FastLinQ QL41000 Series 10/25/40/50GbE Controller" which > relies on the qede driver. Calling rte_eth_promiscuous_enable(portid) > followed by rte_eth_allmulticast_enable(port_id) causes no packets to > arrive from my generator. It's important to add that the generator > doesn't specifically target the mac of the port. I presume that > irrespective of dst mac, if a port is put into promiscuous mode, all > packets should arrive and rte_eth_allmulticast_enable should not cause > *less* packets to arrive. Am I missing something? It seems that > b10231aed1edb9 inadvertently introduced either a bug or a pretty > significant change in semantics (at least for qede)? > > Regards, > Balazs > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] Potential regression introduced by commit b10231aed1edb9 2020-12-30 12:51 ` Devendra Singh Rawat @ 2020-12-30 12:55 ` Balazs Nemeth 2021-01-04 12:03 ` Ferruh Yigit 0 siblings, 1 reply; 5+ messages in thread From: Balazs Nemeth @ 2020-12-30 12:55 UTC (permalink / raw) To: Devendra Singh Rawat, Igor Russkikh, dev, Rasesh Mody Hi, I already posted a patch that fixes the issue on my side here: http://mails.dpdk.org/archives/dev/2020-December/195206.html Regards, Balazs On Wed, 2020-12-30 at 12:51 +0000, Devendra Singh Rawat wrote: > Adding more people to comment/investigate here. > > Devendra, could it be that we don't consider subsequent calls of > promisc_enabled + allmulti_enable ? > > Devendra >> yes, I agree that as long as promiscuous mode is enabled > for a port, all traffic should be accepted even if allmulticast is > enabled latter. Commit b10231aed1edb9 shouldn't have changed that. > I will prepare a fix patch for this. > > On 18/12/2020 2:34 pm, Balazs Nemeth wrote: > > Hi, > > > > introduces a regression on my systems. I have a > > "QLogic Corp. FastLinQ QL41000 Series 10/25/40/50GbE Controller" > > which > > relies on the qede driver. Calling > > rte_eth_promiscuous_enable(portid) > > followed by rte_eth_allmulticast_enable(port_id) causes no packets > > to > > arrive from my generator. It's important to add that the generator > > doesn't specifically target the mac of the port. I presume that > > irrespective of dst mac, if a port is put into promiscuous mode, > > all > > packets should arrive and rte_eth_allmulticast_enable should not > > cause > > *less* packets to arrive. Am I missing something? It seems that > > b10231aed1edb9 inadvertently introduced either a bug or a pretty > > significant change in semantics (at least for qede)? > > > > Regards, > > Balazs > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] Potential regression introduced by commit b10231aed1edb9 2020-12-30 12:55 ` Balazs Nemeth @ 2021-01-04 12:03 ` Ferruh Yigit 0 siblings, 0 replies; 5+ messages in thread From: Ferruh Yigit @ 2021-01-04 12:03 UTC (permalink / raw) To: Balazs Nemeth, Devendra Singh Rawat, Igor Russkikh, dev, Rasesh Mody On 12/30/2020 12:55 PM, Balazs Nemeth wrote: > Hi, I already posted a patch that fixes the issue on my side here: > http://mails.dpdk.org/archives/dev/2020-December/195206.html > > Regards, > Balazs > > On Wed, 2020-12-30 at 12:51 +0000, Devendra Singh Rawat wrote: >> Adding more people to comment/investigate here. >> >> Devendra, could it be that we don't consider subsequent calls of >> promisc_enabled + allmulti_enable ? >> >> Devendra >> yes, I agree that as long as promiscuous mode is enabled >> for a port, all traffic should be accepted even if allmulticast is >> enabled latter. Commit b10231aed1edb9 shouldn't have changed that. >> I will prepare a fix patch for this. >> >> On 18/12/2020 2:34 pm, Balazs Nemeth wrote: >>> Hi, >>> >>> introduces a regression on my systems. I have a >>> "QLogic Corp. FastLinQ QL41000 Series 10/25/40/50GbE Controller" >>> which >>> relies on the qede driver. Calling >>> rte_eth_promiscuous_enable(portid) >>> followed by rte_eth_allmulticast_enable(port_id) causes no packets >>> to >>> arrive from my generator. It's important to add that the generator >>> doesn't specifically target the mac of the port. I presume that >>> irrespective of dst mac, if a port is put into promiscuous mode, >>> all >>> packets should arrive and rte_eth_allmulticast_enable should not >>> cause >>> *less* packets to arrive. Am I missing something? It seems that >>> b10231aed1edb9 inadvertently introduced either a bug or a pretty >>> significant change in semantics (at least for qede)? >>> >>> Regards, >>> Balazs >>> > Hi Balazs, You can create Bugzilla issue as well, that helps to record and track the issues: https://bugs.dpdk.org/ ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-04 12:03 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-18 13:34 [dpdk-dev] Potential regression introduced by commit b10231aed1edb9 Balazs Nemeth 2020-12-29 13:29 ` Igor Russkikh 2020-12-30 12:51 ` Devendra Singh Rawat 2020-12-30 12:55 ` Balazs Nemeth 2021-01-04 12:03 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).