From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B19D7A0C43; Wed, 20 Oct 2021 11:30:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 933DD40687; Wed, 20 Oct 2021 11:30:18 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 6433B40142 for ; Wed, 20 Oct 2021 11:30:16 +0200 (CEST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HZ4vy0T2xz90HY; Wed, 20 Oct 2021 17:25:18 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Wed, 20 Oct 2021 17:30:14 +0800 Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Wed, 20 Oct 2021 17:30:13 +0800 To: Kevin Laatz , CC: , , , References: <20210827172048.558704-1-kevin.laatz@intel.com> <20211019141041.1890983-1-kevin.laatz@intel.com> <20211019141041.1890983-13-kevin.laatz@intel.com> From: fengchengwen Message-ID: Date: Wed, 20 Oct 2021 17:30:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20211019141041.1890983-13-kevin.laatz@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v10 12/16] dma/idxd: add vchan status function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/10/19 22:10, Kevin Laatz wrote: > When testing dmadev drivers, it is useful to have the HW device in a known > state. This patch adds the implementation of the function which will wait > for the device to be idle (all jobs completed) before proceeding. > > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > drivers/dma/idxd/idxd_bus.c | 1 + > drivers/dma/idxd/idxd_common.c | 17 +++++++++++++++++ > drivers/dma/idxd/idxd_internal.h | 2 ++ > drivers/dma/idxd/idxd_pci.c | 1 + > 4 files changed, 21 insertions(+) > > diff --git a/drivers/dma/idxd/idxd_bus.c b/drivers/dma/idxd/idxd_bus.c > index b52ea02854..e6caa048a9 100644 > --- a/drivers/dma/idxd/idxd_bus.c > +++ b/drivers/dma/idxd/idxd_bus.c > @@ -101,6 +101,7 @@ static const struct rte_dma_dev_ops idxd_bus_ops = { > .dev_info_get = idxd_info_get, > .stats_get = idxd_stats_get, > .stats_reset = idxd_stats_reset, > + .vchan_status = idxd_vchan_status, > }; > > static void * > diff --git a/drivers/dma/idxd/idxd_common.c b/drivers/dma/idxd/idxd_common.c > index fd81418b7c..3c8cff15c0 100644 > --- a/drivers/dma/idxd/idxd_common.c > +++ b/drivers/dma/idxd/idxd_common.c > @@ -163,6 +163,23 @@ get_comp_status(struct idxd_completion *c) > } > } > > +int > +idxd_vchan_status(const struct rte_dma_dev *dev, uint16_t vchan __rte_unused, > + enum rte_dma_vchan_status *status) > +{ > + struct idxd_dmadev *idxd = dev->fp_obj->dev_private; > + uint16_t last_batch_write = idxd->batch_idx_write == 0 ? idxd->max_batches : > + idxd->batch_idx_write - 1; > + uint8_t bstatus = (idxd->batch_comp_ring[last_batch_write].status != 0); > + > + /* An IDXD device will always be either active or idle. > + * RTE_DMA_VCHAN_HALTED_ERROR is therefore not supported by IDXD. > + */ > + *status = bstatus ? RTE_DMA_VCHAN_IDLE : RTE_DMA_VCHAN_ACTIVE; why not use stats.submitted and completed ? or I miss some thing about this API? does this api must called after rte_dma_submit() ? If not the following seq will function fail: enqueue multiple copy request submit to hardware enqueue multiple copy request invoke rte_dma_vchan_status to query status --because the copy requests not submit, the last comp will be non-zero, so it will return IDLE. > + > + return 0; > +} > + > static __rte_always_inline int > batch_ok(struct idxd_dmadev *idxd, uint16_t max_ops, enum rte_dma_status_code *status) > { > diff --git a/drivers/dma/idxd/idxd_internal.h b/drivers/dma/idxd/idxd_internal.h > index a85a1fb79e..50acb82d3d 100644 > --- a/drivers/dma/idxd/idxd_internal.h > +++ b/drivers/dma/idxd/idxd_internal.h > @@ -102,5 +102,7 @@ uint16_t idxd_completed_status(void *dev_private, uint16_t qid __rte_unused, > int idxd_stats_get(const struct rte_dma_dev *dev, uint16_t vchan, > struct rte_dma_stats *stats, uint32_t stats_sz); > int idxd_stats_reset(struct rte_dma_dev *dev, uint16_t vchan); > +int idxd_vchan_status(const struct rte_dma_dev *dev, uint16_t vchan, > + enum rte_dma_vchan_status *status); > > #endif /* _IDXD_INTERNAL_H_ */ > diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c > index 9d7f0531d5..23c10c0fb0 100644 > --- a/drivers/dma/idxd/idxd_pci.c > +++ b/drivers/dma/idxd/idxd_pci.c > @@ -140,6 +140,7 @@ static const struct rte_dma_dev_ops idxd_pci_ops = { > .stats_reset = idxd_stats_reset, > .dev_start = idxd_pci_dev_start, > .dev_stop = idxd_pci_dev_stop, > + .vchan_status = idxd_vchan_status, > }; > > /* each portal uses 4 x 4k pages */ >