From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 8A4C71BAE4 for ; Tue, 10 Apr 2018 18:34:38 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 09:34:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,433,1517904000"; d="scan'208";a="219304439" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by fmsmga005.fm.intel.com with ESMTP; 10 Apr 2018 09:34:36 -0700 To: Olivier Matz , dev@dpdk.org References: <20180403130439.11151-1-olivier.matz@6wind.com> <20180403130439.11151-4-olivier.matz@6wind.com> From: "Burakov, Anatoly" Message-ID: Date: Tue, 10 Apr 2018 17:34:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180403130439.11151-4-olivier.matz@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/4] eal: set name when creating a control thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 16:34:39 -0000 On 03-Apr-18 2:04 PM, Olivier Matz wrote: > To avoid code duplication, add a parameter to rte_ctrl_thread_create() > to specify the name of the thread. > > This requires to add a wrapper for the thread start routine in > rte_thread_init(), which will first wait that the thread is configured. > > Signed-off-by: Olivier Matz > --- <...> > + > + pthread_barrier_wait(¶ms.configured); > + > + return 0; > + > +fail: > + pthread_kill(*thread, SIGTERM); This may be wrong, but perhaps instead of killing the thread outright, a better approach would be pthread_cancel? I'm always uneasy about mixing signals and pthreads... > + pthread_join(*thread, NULL); > + return ret; > } -- Thanks, Anatoly