From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E677F1B7D8 for ; Fri, 13 Oct 2017 19:04:23 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Oct 2017 10:04:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,371,1503385200"; d="scan'208";a="909688490" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.248]) ([10.241.224.248]) by FMSMGA003.fm.intel.com with ESMTP; 13 Oct 2017 10:03:07 -0700 To: Markus Theil , dev@dpdk.org References: <72302705-a723-ccb2-05ae-5bc131c0080a@intel.com> <1507910627-29940-1-git-send-email-markus.theil@tu-ilmenau.de> From: Ferruh Yigit Message-ID: Date: Fri, 13 Oct 2017 18:03:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1507910627-29940-1-git-send-email-markus.theil@tu-ilmenau.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix legacy msi masking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 17:04:24 -0000 On 10/13/2017 5:03 PM, Markus Theil wrote: > MSI masks contain a 1 if interrupt is masked, 0 if unmasked. > I got that wrong with the !!state calculation. For better > readability, the mask is now changed like in igbuio_msi_mask_irq. > > Fixes: a8ea1e5fb647 ("igb_uio: fix unknown MSI symbols") > > Signed-off-by: Markus Theil > Tested-by: Markus Theil Acked-by: Ferruh Yigit