From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <SRS0+gQA0=OV=ericsson.com=mattias.ronnblom@lysator.liu.se> Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id BD98B1B432 for <dev@dpdk.org>; Wed, 12 Dec 2018 21:07:01 +0100 (CET) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 4DE9940019 for <dev@dpdk.org>; Wed, 12 Dec 2018 21:07:01 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 39BC740016; Wed, 12 Dec 2018 21:07:01 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.1 X-Spam-Score: -0.9 Received: from [192.168.1.59] (host-90-232-140-56.mobileonline.telia.com [90.232.140.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 72C4540014; Wed, 12 Dec 2018 21:07:00 +0100 (CET) To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org Cc: Qiming Yang <qiming.yang@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>, Jingjing Wu <jingjing.wu@intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-18-git-send-email-wenzhuo.lu@intel.com> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= <mattias.ronnblom@ericsson.com> Message-ID: <cba1ea57-ab9f-4e3f-41cc-497e0d96a366@ericsson.com> Date: Wed, 12 Dec 2018 21:07:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1544598004-27099-18-git-send-email-wenzhuo.lu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [PATCH v3 17/34] net/ice: support device and queue ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 12 Dec 2018 20:07:01 -0000 On 2018-12-12 07:59, Wenzhuo Lu wrote: /../ > + > + for (i = 0; i < len * sizeof(union ice_rx_desc); i++) > + ((volatile char *)rxq->rx_ring)[i] = 0; More of a general question... but why doesn't DPDK has the READ/WRITE_ONCE() of the Linux kernel? Would reduce the amount of open-coded use of volatile.