From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD72A41C97; Tue, 14 Feb 2023 19:22:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C187342F88; Tue, 14 Feb 2023 19:22:11 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2067.outbound.protection.outlook.com [40.107.102.67]) by mails.dpdk.org (Postfix) with ESMTP id 6B5CC40EE4 for ; Tue, 14 Feb 2023 19:22:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FjOZ7fZM29f5gHGiRk0+PWdEijubpUBxaY2kHkoDR6n5dN/gmFNxGDd+icSMxxnHmh/KWIhEhTAKIkxhENNZsiGvM0qiogqqFYxqCN7W/vdm18zuv2uTcQZDdn6+b2NX7GWBDOGuEY97h7dUbVIC7/kWB/bLmwg7tlmLyz8WP6OVfdkJEAhg/j66j+EIkA8a4ybFVCHXPxphbUtesfY4G1iWDMpZe787vWj93vZny7n4ZVJZ0QUhA5Tu8GnCX/BO+CERIUaXvVtZUbYOMfAbTs84URwYoP0ygBr37KzapkAgbfTqSWl9Ms6y/WCB9f3fmEbW+L2EF37cEQ848zx4jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LEOPley8JMolb/XDiTEpYIm7aRz6GvrtTzjJSoJyK94=; b=f11oxMl1trnAozMbj9CXtsJ5TzZp5Sb30dU+ZMGdcsXNO+Ahms1/VkF7QNXHZisbGpauFen0dz2KFqUZAVMXlY5nwYgdrfFmTlW2bHHTawbkoCLGDHxFGBN6S0vpQcxGidFkRATYHHmnc0SDtRLCUStBOoixKGPI5qjRrbp2i4qb+V6RZEegqLh93rOwXpQ9MyUulP0yYQ4k0AJ2VGOsNoPpAF0DtmQ3YZuoAPm68nzlJNqNOlHDcg7Hb3p/QpwoSCjsxVwCnpYoCJy4UhNNkfVJbSRAM7+cfWXeGJwRapUQ7vEiXEp1aUq/8JJ1XGBOkhIjeXmwuk8tU91FGdCZpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LEOPley8JMolb/XDiTEpYIm7aRz6GvrtTzjJSoJyK94=; b=oGChRe/d1UPIo8L4PpsRAo2zl0YpDWbcuSoJ4N/NUJGOMpQNe9aXvrdQutr0UVaSuOZHTiux02Pby9Id4WiV6LFaL7naVaJIDyjgMBQZf8yJTTDYAzM4rRFxHX5b2dicp6DvZpHdfwNI+AvguwdLSABlmozLuKcywfJpoWBXcz0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB5024.namprd12.prod.outlook.com (2603:10b6:5:20a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.22; Tue, 14 Feb 2023 18:22:08 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6086.026; Tue, 14 Feb 2023 18:22:07 +0000 Message-ID: Date: Tue, 14 Feb 2023 18:22:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 0/6] Testpmd code cleanup Content-Language: en-US To: Robin Jarry , David Marchand , dev@dpdk.org Cc: Aman Singh , Yuying Zhang References: <20230124104742.1265439-1-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0386.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB5024:EE_ X-MS-Office365-Filtering-Correlation-Id: c802be2e-785e-403f-8c16-08db0eb86126 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tFY1oCscJAUZUSKJm/pNKuRbp1whF4A7FUlxCoJ660gVBxveprgsDD097KbL2FVoOU4WRNtFlJtS94+DezVSShCkuw1U2usify9cuJcsmOczH8AcNJy0ZP1ZXHZYYPq1uglFnnTOJ3jw4eEhcZ6ZhbexYWkq9pb7iXICB/HwjlanWGoLGnsScFHiCt3M10nNZAg7pjK3ouikXQvAbxLHcGpPLAvB4ZFStFprZ1Lapf4x8TOgRPp9SkREDTwibhw7L07M5m4ZEHh6GxDBP2l6lheQqQIEzEsF3DLJBuJVW1t/hKmFmoeNYBUSlKpXMRUfMIIFge+axf0BQzV/4rpW5N9KVcZ8Mn63yBXANbIsxDJrkiyjfSIGLOgHKqReN9OIfHdf3Ub3OJ6pd58uCeApMSjYwqMm70fUgDIh5BZ4G2+RDHfr2cFoWwvcIe4ngPQOLx83WcvHQUvO+pOA/6kPHaYJmXflr5DHumakv/hVUeW9OkHaISiuKhuEj/7tSZMTRqTeSZbrNB+eYveLbbPtu8V2vmPpWDU036ia3JOd6/9fkKUQwOXmfmOSc5XpTQVl2gPCgaZEKZpIv4UzJ2i6UJGHruxweQYIS4i4GKEDSKD5hD0xWUojoGEVd5FP89dhx200C5OpDnAgIr3ZF5Yo9PFZbTexoKNeC5MlQGx5caR3l99DFFlKpbjJRBh9kz3Nql1QDU7Qw2dnThf4ujUAnHNbOkv1p3kYwhem2LLacTY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(451199018)(66946007)(110136005)(44832011)(8936002)(4744005)(54906003)(66476007)(66556008)(4326008)(8676002)(83380400001)(41300700001)(316002)(5660300002)(86362001)(38100700002)(26005)(36756003)(6666004)(186003)(6506007)(53546011)(31686004)(6512007)(2906002)(31696002)(478600001)(2616005)(966005)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUtLZmY2N3VGbDhDQmhoOEliaUVjQmU2NTRSZ0dyZUE1WkFVb1BKQ0RyWEg0?= =?utf-8?B?eUN0dU94dXdBOWVHMGtEWUxvZjZTS09FK25Lei9XOU1vUmNENVdGUXYweHhJ?= =?utf-8?B?c1M3ZndmTllwQzJYaU1HWmtjNjZyTjRTemp5dSsrcitWWDV2NkhhVzZrY3A0?= =?utf-8?B?ZnJkTkFRb0M1Wm11R3B3RGYxKzlQZ1NGS2pVdGpBTVFxYThIbHAxZXBtMUh5?= =?utf-8?B?UzV4d1labEhUaXZzaGl6M0tXTExnRmwzZUtDa1pZS3BMcXhqcHpaQmZTWVZS?= =?utf-8?B?VStTMWtxcWMrLzZqOHZwR2U1R2kyQ09xQXlEREpUTnFoUjdoWnpVZFNCcG8y?= =?utf-8?B?WlB1SXNpZFNZT1BTMC9HczhReEZMZjNQcGJ1WksyUm50MXRkdmptZlFFVktq?= =?utf-8?B?NXgxNXVGbVpJQ2dNWG5jSittSVlRUVY2dVJOUk9KY0JKVXRCTlpKbktpSnpD?= =?utf-8?B?REJZaFNFSWIveDhWL0RhMXhndWo0MjliNVllSzg3MDVpTytIKy81Yjg2UjRG?= =?utf-8?B?VHlEd0VQcHdXd2JqaEFydXV5dG12eFlnSDNPSVFpdWRMbEJuMDZhdmJibGxa?= =?utf-8?B?WmJNbEtHNjhWVkthSkU1WmdSQmtpemVkZmR1QTR5VDVpSWlVOW1wczJGQy9a?= =?utf-8?B?dHQ3UmdSNFkyQmpSY2Zzak5LTkV1bDB2TnB1d2FhYmZQWDB6WFcwem5DVzkr?= =?utf-8?B?aEV0TUthVWM0cGRmQUlMRU9iY2VVeTMrNkZpOVNyVXJpQ3hrSGdBQ0ZraDFu?= =?utf-8?B?bEtDSDhUb092SjRIbU96WUpxeU02WXlTdWZZc2N3eWlXcEo2Nk5HZFh3ZFpt?= =?utf-8?B?a2VZUm9hZ1kxR2Juc3p2blJ1ZEZpS01qd05USGMrSzVYTDFmOHN0M3k1MnhD?= =?utf-8?B?c0d2d2pmWjMwMnNJS0V0WjVhL2drTWxyd0lHRm9jVm0wNTFVakFuQVpDYmRp?= =?utf-8?B?ZWNUdWVTY1IwMjhRbmtTU2xDOWJpY3VTK1pSTWhZb084YVl4amZrQWF1Y1VL?= =?utf-8?B?Qk5rTzFrYUxqTFhQOFplZ21vZ29nY0dzWit5Tkd0NndKSjZsYTZqbjBJU29l?= =?utf-8?B?VW9KUHpHTTdQU0dGOHZLOVFRM0c0b2ZCZ3RQNTBuTzVSTTVkMStadnd3UUI2?= =?utf-8?B?cjlCUmJWYitob3JGQktSNmdHZFZwWDFtdWdtMkl4bW1XZzdEYTRxdnEzdjg5?= =?utf-8?B?ZkxwTmVDTzl2ajBXM1ZNdUZ2V0hTV0Mwem5ZL1lSRGFOZzh1eVdXMU43L3Bq?= =?utf-8?B?Q3Q4Q0lJV21aSUNBMUpLOTIwOGNwMGZ0Um9jdXVhWFV5VGZEVmZ2Mk1uRlJl?= =?utf-8?B?TzhWd0J2Yjk3c1hvazd6Um4rLzQwOUxUVnpSYmU2R080dUJPQTlxa09qc0t6?= =?utf-8?B?YXlGdUpBWXIzdm1mN2l2akFCQVp3SDBZYzJTSHZaM29yOVYzOEVQM0p0eTY0?= =?utf-8?B?eWxNZW1hbnowUUNnd2l4MXBrQStWdDVFS0FBMlVKd1hMVTlIL1RJbGhKcUtF?= =?utf-8?B?NjNyYURWT3FJWVRIT092UERNcTQ1N0JTU2N1Tzc3cUp4eFJBbnlyQ3pNQ1ZV?= =?utf-8?B?RDlXeTBEMysrUHlac1BnNUZEZnRPdFdJWWE0d2tsejIwTldtMWN2TWlINmhW?= =?utf-8?B?L1BVdzR5OTllQ3BYTnBPaUZqTjJHMTN1dVFuamdFSHlId3pTNFdEZllwS0pF?= =?utf-8?B?OGVmTzlqNlIzamdvckgrT2ZIbHZQQ2o3cVZTTEZ3VVRzQlFvSlNmQWJ6TzhG?= =?utf-8?B?N0F2bnBuRGhLOVRCOWxFbk9ZVzRJam43ZHhMT1kyeDdpaTFLdU1NVTBUVGFU?= =?utf-8?B?RkFWQmxKdGtBTWd1VHdFVU5sL0w4czZlMUdyUkhMelV0bXk5Q08vMjRnSnN2?= =?utf-8?B?Y0F1TXdGNGtzTm9mNXlWYWpMT0I5UGx2OE16NXQ3OVpTdm51b0JYNjBTWU9q?= =?utf-8?B?a1hNZFBWWVM2UGR5czVrZXpReDllU3N0Unp6WWRSUjd6dXdaS0dXMTEyNXpw?= =?utf-8?B?VWZlN3E3NjFRMUwvWk5ibytaaHNscUNPNWJkTGppSk1mczNha1NlclpwdVR0?= =?utf-8?B?K0Y3U2FUTjBORjR3MkFmL3YvZmE3VUtrZ1pTandoMzVUM2JzL0ZKMXFNK3Rm?= =?utf-8?Q?sUodeNE2oXHoms2ehcGfu9wXm?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c802be2e-785e-403f-8c16-08db0eb86126 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 18:22:07.1931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AsOeVYfoGcKXElPgTMDfx0fdh+1b6CrBFUecIddvUr7iNnR99gW4Isja5wTtib02 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5024 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/25/2023 1:50 PM, Robin Jarry wrote: > David Marchand, Jan 24, 2023 at 11:47: >> Here is a series to reduce code duplication in testpmd. >> >> This work started from looking at Robin series on reporting lcore busy >> cycles in telemetry, which is then added in testpmd [1]. While looking >> at the forward engines code, I saw way too much duplicated code. >> >> Warning: this is only compile tested. >> >> 1: >> https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-rjarry@redhat.com/ > > Hi David, > > The code looks good to me. I have made some basic testing, it seems not > to break obvious things. > > Reviewed-by: Robin Jarry > Hi Robin, This set conflicts with your set which is merged [1], I guess your test was before your patch merged. Can you please check again after rebase? [1] Commit 99a4974aa569 ("app/testpmd: report lcore usage")