From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CB5EA00C5; Tue, 15 Feb 2022 14:28:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 191EF4113E; Tue, 15 Feb 2022 14:28:36 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 2332C410F7 for ; Tue, 15 Feb 2022 14:28:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644931714; x=1676467714; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=+a0htaGLso4qRNmJmXeqA7T+JyndyiKsiDrLn9aIeDc=; b=Yaozyhg0ENwPakfYuo3VeSAYaoTsn2XpnShfNJeBAJyIPoU/VkXW2fRj XPPl8f0T2bA++TJKWjHGvZ61nsXomtYLLxbkkaB6tN6gowYHVzWV927Wc HA4YiQcV8cx4mRpno9Jy6dIYn4w8sdSTsD06f/kAOYqb+npflXR54+xP/ sLFJrWjfWrD5r3peseMpX9Ub8e+lN+BzZDfNxSn+OBcm4NLdgcv/J6gbu sUID/axORF+SHOgOjn7zsJuiaCiIkBqcl97w0dZMAzgcUpF8996SkN8QX Y3clTI8cDWlpQROiZ5agOFeKJJie9hWpYFXebIp4Q+hpePuSUJw/7WVdU A==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="336781192" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="336781192" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 05:28:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="703676896" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 15 Feb 2022 05:28:32 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 05:28:32 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 05:28:32 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 05:28:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iLdrvfy+ieW3y9i73HMYsxm3vXqpqxALOu/AEDVogV+2YWO7yk5WEWMTIBiVwS6ZSwXVIMPZaglRiXxoowJW0J6LJ3SMmcrzcbAKAYiWe/rWomkcEAbvG0QPf9IQYH+dQ9id/4oEKAyoOzhmscBtoBrQ0K9x3VD4aKZgbc4N5WQtf9vhk0pZ5E3smLqhrMjVjyN9afQqhLunniOnDZwWSkxOYSFiNHVHJrEgIjalgr9E1dLmh5pp/TyByvAIjiP1mDBukCO+mUNP1QM0DV6wpoQd4d/FZgVe+72pJ8K2RkTxdYTm0EYCyM6ULtfsjKP5CAgAwGbBVAZfBLmA4x32RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EjeaRjcsERCcLL/2dLnXxsGzgqOBjYq7cJ5JIFJeIaQ=; b=c8S/QuA22xKVUB7heIi5sBWQeNQO+5TyEzc2k2SlYaVZk4v4Mkr7Y0JoJ+MIXMfuaSWhrw3ZcYeAQzN/J3cxHwGpPhVx5Hkc2QgGgdlVT+ChHyjmeYv/06eT2+XliEr9CV7iOQqAGf/7EtCSS0jiGodPHPa4U48pZ8Caddw9lK7AstOVjP5z9cu6xK5PsF+JsfwjIeTiV+gvxV0OkGK+u75Xqg160dvH7UM86Oag913wZZgTYyfZW/6ynfBfP0chqH3ut8D3/RGAmu2mYH9C9pMwEUq2kiX/XETcGmx/Ybg4Zf/WDHOQsDdX5y1ttR9p24/55v+2tQ9QfOJhBa0ZZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR11MB3892.namprd11.prod.outlook.com (2603:10b6:405:80::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb 2022 13:28:26 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 13:28:25 +0000 Message-ID: Date: Tue, 15 Feb 2022 13:28:19 +0000 Content-Language: en-US To: Robin Zhang , , Qi Zhang CC: , , , , , Thomas Monjalon , David Marchand References: <20220215101853.919735-1-robinx.zhang@intel.com> From: Ferruh Yigit Subject: Re: [PATCH] app/testpmd: format dump information of module EEPROM X-User: ferruhy In-Reply-To: <20220215101853.919735-1-robinx.zhang@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0111.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b31c2402-78fb-4646-3f34-08d9f0870b89 X-MS-TrafficTypeDiagnostic: BN6PR11MB3892:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eJTx47Y9BKyGueCPU6ZyqhP7rFdszdH0wdZlkf56ByIcVwsj7vgW17HxIyYOHjoFe7y18koAENnIsVauM3OnYJ7SN0ShtZAW7F0yH3hreA1evuBC14n3O5qO3LwoOIUqRza72xjST+tqHoMohdPxx5PcwszRfT8GhXUJwrv/1T3YiOsIV43YeBLQrYtuZASHrY/x+p3mmWHSd5UDrwvfY6zYA7vF6xOX336xqJ5ItG6QI9w2stjuUZHV6nabE90lp3vQ7ZXa7JjM7PzwcNm8P7oa6HSz5pix66eKl8Q90t18KM/GSZyAiwutP8ds7VTD+lPLM7YzRAwl+WJ/WlMe2vYLECjtUOSZWZgmvM+eFBHG2JFNEcyaE9nibwbAzLI0cTdzsAKQNd5VKmWDZNuQ2Dqz4R+o6QAVUKDHcHOEZrnhpm2LOf/Ruy3lDNxJTuDxsOwDqAds0YxTxft5eMgSHN8vJn2yiXrv9loQ1e/qpK+1LHnbtdKH9M8jLeV30k1Sxc1Fijw3K/f6MKNhZynN6HRnJAPQaRIMo2QD5vRCyY3ITjQkmOmb+dFt0LOQ1AjJ/p2R3dLIj3od98P6jqkhOD+eS+Om657Ln4Okc2It4T7na+HR6jBX3pW5go8VgEm8F+cEOHdK/ua8b9y26t3yyiVSjErG24lEKDhnpktZYLS9wwbh1YWYUgZ6QP+NsbcSMp4DgxVnPg8Sxtjp8EcI7g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(66556008)(66476007)(4326008)(66946007)(26005)(86362001)(8676002)(31696002)(6506007)(6666004)(8936002)(5660300002)(2616005)(83380400001)(6512007)(38100700002)(316002)(53546011)(110136005)(82960400001)(54906003)(6636002)(6486002)(36756003)(2906002)(31686004)(508600001)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0FnQ0ltUUVmdkVzeSt6bUU5TXJMdEw2cGJ5LzJJbWNTL1R2VW9YWTRPK2JR?= =?utf-8?B?WVlxTkh2Y205S1BqSnI3NGJGRURBRDZmKzVhVHhlUURYdUpwQ2hFOERXeW9u?= =?utf-8?B?WXBVS3RaM2V4RzNoMk9kY0p0eGJYMEE3Tit6MGM0cC9TdkhBSGRSSDdEbXhZ?= =?utf-8?B?MmpFeW9kOUJSRHpCV0pPVnA5T09vMGVNM2pjOTl3aEhQSnF0L1piWFhQV1F6?= =?utf-8?B?RkZrbmdUOWpWdUhZSjhNSzZxZGVIdmV1UGZLTnZSeTZjbC9jTzdNZkdVWkZ2?= =?utf-8?B?R2V1OXcwNkNJeEdWdTdmREJpSUgvbXNQSVRsTEhsVFRURTVMY3o1R0ZMMVRO?= =?utf-8?B?OUJWWU1QQU1PS1dSM29HL2FNQ2x5L050WTNnTHp2ZmxMSTYxRnlWUnoweVVT?= =?utf-8?B?VE96SW5ZcGdSVDMzMnVDZ3ZyMXlrdS94Zzg1NGM2enJwcnpSQUJVREpMY3pE?= =?utf-8?B?VkR4ajZaTmJWWG5GT1BML2RENFRLZ3c2VVF2bENNVnNKMlkyNGIrRkFQdk5w?= =?utf-8?B?M1dRS1h5MkJoZHlHcEp2RVNpRmtlSVVCSnZnallHaHlRM3hkbzhmdG5mZDVB?= =?utf-8?B?aEUvTUcvL1BEbE9jbHJkTDBueFhudnRqT2VDV25hRzFtV0JSUm9RbkNUTmV3?= =?utf-8?B?R1orYUR2ZWgrbmFxVFpkaVhxUDBwMzVsUENsOTFtelpadEp3K3FZeTdyaE9Y?= =?utf-8?B?WnBGWkFkTzBVR0xnQ0pwazhWdld2dDA0dUI0MmRRTWptSDFwek9mZ0daR0N2?= =?utf-8?B?d2hjM05SbVI5R0lDRk5wM1ZhZ0tzaWhxSFJPbktRRWM3WC9Vdmlnd3VOcDM0?= =?utf-8?B?SUczRGdHQ0Q5RjlLM3AzMXlLWmlsMmpFUG9SZFlHK3Uyb1hISFpPK0EzWFMy?= =?utf-8?B?NnZkWW1XSmhWL0R2MjRlaGtna3RmVWJiKzhTY2xKbTM3clp4ajlwRmJCRkNr?= =?utf-8?B?ZWNvTzNrbTRrYVlJekllTy9iaFJaUVNVcjB6TUNQS3BONEg0UkozbVlUTUJM?= =?utf-8?B?SFNMdFFwRUU1MVY5Z2FuS1M4cDJYcGl3M3k3RmZNSW5TOXZtNmRWejVwODJU?= =?utf-8?B?L3M1cjZmbnFibm40Uk05U2w4ZHlUZDNDUU9QOWJaNUdVZFFTMWtlNHhVelNp?= =?utf-8?B?Q25ibVcwMEdFNzZqK3ZxMmNxQ0JnTUdiR0tXY2lNUWRpMzZTL3l6MXp6RCs0?= =?utf-8?B?ZmVLd0JPOTR2dGpmdGIzU2ZDKzNlZitSck5sNEdZS1FuUXdwZlpWQmVOSEJR?= =?utf-8?B?QURKUWZsL0w3ZFVabklobVcwYS8wTkQzR3Z2WGdEa2sxVDZnNmg2YWxFRTlo?= =?utf-8?B?R0NtaGhuaEV3WWJBZU5HaHgyVG5rSTlwQktCdVlnNENtYTVzcHN4TzN0cjVp?= =?utf-8?B?aGRtd2pSd2FRdjR4UjFWU2dhc1FnbEJxdGtVa3FjREoxR1Nqa2VLKzdGeUdr?= =?utf-8?B?T3JES1ZmV2RpeG5VY3lLT2Q3eGNjVkZxRjJPVDhWMUw2ZzJ0QVo1N3ZUSVV3?= =?utf-8?B?dFhySjZZdEV5Z2hIaSt2RisrbHZ5NkxUNFpzMC9jSVBQaEttall2eFdidk5m?= =?utf-8?B?ck1TeTQ4akxnckgzT25VajRWemgxOHVBTmFlUEFDUElnazZmWkRHN1hOL3dP?= =?utf-8?B?Z2w2S24xMVFSOXZJQU1YL3NiTXg2WlhQM3lqUmtRTE1HalZSa3lmZVRkampB?= =?utf-8?B?VkhTZFIxWUYyZ0ZDM1YzcTBPUUdCaXB1MW95VXNkMVNTZFZIaVJ4WCtMcmVJ?= =?utf-8?B?VVNDaGtOY21zM2NVcnRzQ3RkMTV6ZVlrM1ovaWY1Zk1SR3dyc244STFDalM5?= =?utf-8?B?TTc2SW53Qi9zdmNScUNoOHlCQ09DUDVTZHd5YVJFbGNQSHQvdXJKOG1ybE04?= =?utf-8?B?K010MzFwVXBVL2F2Yi95MHN4M2ZrMnZ5ckp6T0Y3cGJreDJFUk53SlhsY052?= =?utf-8?B?elRRSzlRa011WDk2bmp2MWpNME96WkE2WWlrb1hIRUszSnJRU1cvc2R3SEk5?= =?utf-8?B?cGkyQ2FwVW5idy9lczBpa002LzFmMnIzRVpDdVRRUWVycll5TUN6OXlDaVFM?= =?utf-8?B?RnVLL3FFT1VIU3k2ampUMHQxalR3b05Zc2oyRHN4REVrSWFQUy9rTWFBcWxw?= =?utf-8?B?dDBsVzNtRUQwalh4ZS9YNWdQSklrMm9MYTFXRS8wTFNPV3kyV3dtbUw4aWhX?= =?utf-8?Q?ZWu4qBOhP/J1YeGGJRY7cX4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b31c2402-78fb-4646-3f34-08d9f0870b89 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 13:28:25.8024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oqQQI3MTvM4EWkLczX/fHTA39PtulWzNPvTbnqTx5L5N27ojVsacgDHyvnzcKnGMv3xbO18of5qlrwVsHoe8Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3892 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2022 10:18 AM, Robin Zhang wrote: > This patch add a format specific information of different module eeprom. > The format support for SFP(Small Formfactor Pluggable)/SFP+ > /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on > SFF(Small Form Factor) Committee specifications > SFF-8079/SFF-8472/SFF-8024/SFF-8636. > Hi Robin, First of all, can you please clarify the motivation of this patch? Why we are adding this eeprom parsing, and who will be user of this patch? And, just to confirm, this parses the eeprom module based on SFF spec, right? So it doesn't specific or depends any vendor. But still, this is too much SFF specific code in the testpmd, and it is not small amount of code. I am not comfortable to get this into testpmd unless there is a good reason. What do you think to have this as a sample application? > Signed-off-by: Robin Zhang > --- > app/test-pmd/cmdline.c | 74 +- > app/test-pmd/config.c | 24 +- > app/test-pmd/meson.build | 4 + > app/test-pmd/sff_8079.c | 376 ++++++++++ > app/test-pmd/sff_8472.c | 281 ++++++++ > app/test-pmd/sff_8636.c | 742 ++++++++++++++++++++ > app/test-pmd/sff_8636.h | 592 ++++++++++++++++ > app/test-pmd/sff_common.c | 296 ++++++++ > app/test-pmd/sff_common.h | 178 +++++ > app/test-pmd/testpmd.h | 13 +- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 +- > 11 files changed, 2575 insertions(+), 16 deletions(-) > create mode 100644 app/test-pmd/sff_8079.c > create mode 100644 app/test-pmd/sff_8472.c > create mode 100644 app/test-pmd/sff_8636.c > create mode 100644 app/test-pmd/sff_8636.h > create mode 100644 app/test-pmd/sff_common.c > create mode 100644 app/test-pmd/sff_common.h > <...>