From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CABA43C27; Fri, 8 Mar 2024 21:26:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A5E140291; Fri, 8 Mar 2024 21:26:45 +0100 (CET) Received: from smtp-fw-80009.amazon.com (smtp-fw-80009.amazon.com [99.78.197.220]) by mails.dpdk.org (Postfix) with ESMTP id 0630840274 for ; Fri, 8 Mar 2024 21:26:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1709929604; x=1741465604; h=from:to:cc:date:message-id:references:in-reply-to: mime-version:subject; bh=f1qdJbPa8kt3W34ANan9M4/1NhhUG2zgooFExkI15ds=; b=funnGtNdyvWnh4Rd8PdnTsE1ytWBcd44wtHHi5iKSD3yjrtniVyRdcof z6909lFjXDR3fToHhVwbLNTzKr+3VOmaxZvTaFDDCyZFsl2qXalMkIxQ0 208umkl8/1fK/YGoUgku4NFJBQwry0d47abDI0dRL/AePrfYba8uMvB7I U=; X-IronPort-AV: E=Sophos;i="6.07,110,1708387200"; d="scan'208,217";a="71856674" Subject: RE: [PATCH v3 00/33] net/ena: v2.9.0 driver release Thread-Topic: [PATCH v3 00/33] net/ena: v2.9.0 driver release Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.25.36.210]) by smtp-border-fw-80009.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 20:26:41 +0000 Received: from EX19MTAEUA002.ant.amazon.com [10.0.10.100:44124] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.43.65:2525] with esmtp (Farcaster) id 604e6788-7543-49a8-8c05-1a3f71812ea7; Fri, 8 Mar 2024 20:26:40 +0000 (UTC) X-Farcaster-Flow-ID: 604e6788-7543-49a8-8c05-1a3f71812ea7 Received: from EX19D007EUA004.ant.amazon.com (10.252.50.76) by EX19MTAEUA002.ant.amazon.com (10.252.50.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Fri, 8 Mar 2024 20:26:40 +0000 Received: from EX19D007EUA002.ant.amazon.com (10.252.50.68) by EX19D007EUA004.ant.amazon.com (10.252.50.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Fri, 8 Mar 2024 20:26:39 +0000 Received: from EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc]) by EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc%3]) with mapi id 15.02.1258.028; Fri, 8 Mar 2024 20:26:39 +0000 From: "Brandes, Shai" To: Ferruh Yigit CC: "dev@dpdk.org" Thread-Index: AQHab8FIgsgpkqvGh0eU42E5VAy0W7EuHqsAgAAvrLs= Date: Fri, 8 Mar 2024 20:26:39 +0000 Message-ID: References: <20240306122445.4350-1-shaibran@amazon.com>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: multipart/alternative; boundary="_000_cbe500fa1b5e455fb3d004b13a86bf54emailandroidcom_" MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_cbe500fa1b5e455fb3d004b13a86bf54emailandroidcom_ Content-Type: text/plain; charset="windows-1255" Content-Transfer-Encoding: quoted-printable Sure, will upload a new seried, thanks! =E1=FA=E0=F8=E9=EA 8 =E1=EE=F8=F5 2024 19:36,=FE Ferruh Yigit =EB=FA=E1: CAUTION: This email originated from outside of the organization. Do not cli= ck links or open attachments unless you can confirm the sender and know the= content is safe. On 3/6/2024 12:24 PM, shaibran@amazon.com wrote: > From: Shai Brandes > > Hi all, the ena v2.9.0 release introduces: > 1. HAL upgrade: > - renamed the 'base' folder to be 'hal' > - separated the HAL patches instead of a bulk update. > 2. Restructured ena stats and metrics. > 3. Restructured the LLQ configuration: > - configurable via devarg. > - support device recommendation. > - restructure the logic in driver. > 4. Added support for the admin queue to work only in poll-mode > - configurable via devarg. > - allows to bind ports to uio_pci_generic kernel driver. > 5. Reworked the device close to exhaust interrupt callbacks and alarms. > 6. Fixed a bug in fast mbuf free. > Best regards. > > --- > v3: > * Fixed missing admin queue missing intialization in patch 0032 > > v2: > * Fixed minor spelling issues from checkpatch > > > Shai Brandes (33): > net/ena: rework the metrics multi-process functions > net/ena: report new supported link speed capabilities > net/ena: update imissed stat with Rx overruns > net/ena: sub-optimal configuration notifications support > net/ena: fix fast mbuf free > net/ena: rename base folder to hal > net/ena: restructure the llq policy setting process > net/ena/hal: exponential backoff exp limit > net/ena/hal: add a new csum offload bit > net/ena/hal: added a bus parameter to ena memcpy macro > net/ena/hal: optimize Rx ring submission queue > net/ena/hal: rename fields in completion descriptors > net/ena/hal: use correct read once on u8 field > net/ena/hal: add completion descriptor corruption check > net/ena/hal: malformed Tx descriptor error reason > net/ena/hal: phc feature modifications > net/ena/hal: restructure interrupt handling > net/ena/hal: add unlikely to error checks > net/ena/hal: missing admin interrupt reset reason > net/ena/hal: check for existing keep alive notification > net/ena/hal: modify memory barrier comment > net/ena/hal: rework Rx ring submission queue > net/ena/hal: remove operating system type enum > net/ena/hal: handle command abort > net/ena/hal: add support for device reset request > net/ena: cosmetic changes > net/ena/hal: modify customer metrics memory management > net/ena/hal: cosmetic changes > net/ena: update device-preferred size of rings > net/ena: exhaust interrupt callbacks in device close > net/ena: support max large llq depth from the device > net/ena: control path pure polling mode > net/ena: upgrade driver version to 2.9.0 > Hi Shai, I did review only first 10 patches, there are some common patterns to address in the perspective and commit logs. Can you please update whole series according to comments? I will review remaining patches in the new version. Thanks, Ferruh --_000_cbe500fa1b5e455fb3d004b13a86bf54emailandroidcom_ Content-Type: text/html; charset="windows-1255" Content-Transfer-Encoding: quoted-printable
Sure, will upload a new seried, thanks!

=E1=FA=E0=F8=E9=EA 8 =E1=EE=F8=F5 2024 19:36,= =FE Ferruh Yigit <ferruh.yigit@amd.com> =EB=FA=E1:
CAUTION: This email originated from outside of the= organization. Do not click links or open attachments unless you can confir= m the sender and know the content is safe.



On 3/6/2024 12:24 PM, shaibran@amazon.com wrote:
> From: Shai Brandes <shaibran@amazon.com>
>
> Hi all, the ena v2.9.0 release introduces:
> 1. HAL upgrade:
>    - renamed the 'base' folder to be 'hal'
>    - separated the HAL patches instead of a bulk update= .
> 2. Restructured ena stats and metrics.
> 3. Restructured the LLQ configuration:
>    - configurable via devarg.
>    - support device recommendation.
>    - restructure the logic in driver.
> 4. Added support for the admin queue to work only in poll-mode
>    - configurable via devarg.
>    - allows to bind ports to uio_pci_generic kernel dri= ver.
> 5. Reworked the device close to exhaust interrupt callbacks and alarms= .
> 6. Fixed a bug in fast mbuf free.
> Best regards.
>
> ---
> v3:
> * Fixed missing admin queue missing intialization in patch 0032
>
> v2:
> * Fixed minor spelling issues from checkpatch
>
>
> Shai Brandes (33):
>   net/ena: rework the metrics multi-process functions
>   net/ena: report new supported link speed capabilities
>   net/ena: update imissed stat with Rx overruns
>   net/ena: sub-optimal configuration notifications support >   net/ena: fix fast mbuf free
>   net/ena: rename base folder to hal
>   net/ena: restructure the llq policy setting process
>   net/ena/hal: exponential backoff exp limit
>   net/ena/hal: add a new csum offload bit
>   net/ena/hal: added a bus parameter to ena memcpy macro
>   net/ena/hal: optimize Rx ring submission queue
>   net/ena/hal: rename fields in completion descriptors
>   net/ena/hal: use correct read once on u8 field
>   net/ena/hal: add completion descriptor corruption check >   net/ena/hal: malformed Tx descriptor error reason
>   net/ena/hal: phc feature modifications
>   net/ena/hal: restructure interrupt handling
>   net/ena/hal: add unlikely to error checks
>   net/ena/hal: missing admin interrupt reset reason
>   net/ena/hal: check for existing keep alive notification >   net/ena/hal: modify memory barrier comment
>   net/ena/hal: rework Rx ring submission queue
>   net/ena/hal: remove operating system type enum
>   net/ena/hal: handle command abort
>   net/ena/hal: add support for device reset request
>   net/ena: cosmetic changes
>   net/ena/hal: modify customer metrics memory management
>   net/ena/hal: cosmetic changes
>   net/ena: update device-preferred size of rings
>   net/ena: exhaust interrupt callbacks in device close
>   net/ena: support max large llq depth from the device
>   net/ena: control path pure polling mode
>   net/ena: upgrade driver version to 2.9.0
>

Hi Shai,

I did review only first 10 patches, there are some common patterns to
address in the perspective and commit logs.

Can you please update whole series according to comments? I will review
remaining patches in the new version.

Thanks,
Ferruh

 --_000_cbe500fa1b5e455fb3d004b13a86bf54emailandroidcom_--