From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 018F637A2 for ; Wed, 3 May 2017 18:43:07 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2017 09:43:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,284,1491289200"; d="scan'208";a="963977217" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga003.jf.intel.com with ESMTP; 03 May 2017 09:43:05 -0700 To: nicolas.dichtel@6wind.com, Thomas Monjalon Cc: dev@dpdk.org References: <20170503160016.31375-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 3 May 2017 17:43:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 16:43:08 -0000 On 5/3/2017 5:39 PM, Nicolas Dichtel wrote: > Le 03/05/2017 à 18:00, Ferruh Yigit a écrit : >> build error: >> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10: >> error: implicit declaration of function ‘pci_enable_msix’ >> [-Werror=implicit-function-declaration] >> err = pci_enable_msix(pdev, >> ^~~~~~~~~~~~~~~ >> >> This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option >> enabled. >> >> Following Linux commit removes the pci_enable_msix() >> Linux: 4244de1c64de ("PCI: remove pci_enable_msix") >> >> Switch to pci_enable_msix_range() for kernel > 4.8 since current Linux >> igb driver uses this function. > When looking at the kernel patches, it seems that the way to go is to use > pci_alloc_irq_vectors(), but it needs a bit more work. I remember this from your igb_uio fix, but latest igb kernel driver uses pci_enable_msix_range(), I found it easy and safe to replicate it. We can update it when kernel igb driver updates the code, unless you have a strong opinion to switch pci_alloc_irq_vectors() in advance? Thanks, ferruh > > Exemple : > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=da6f4cf58e40 > > > Regards, > Nicolas >