From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2191B1E35; Thu, 18 Jan 2018 11:15:07 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2018 02:15:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,377,1511856000"; d="scan'208";a="20731849" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by FMSMGA003.fm.intel.com with ESMTP; 18 Jan 2018 02:15:04 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org, declan.doherty@intel.com, Boris Pismenny , Aviad Yehezkel , Radu Nicolau References: <20180109162317.18183-1-ferruh.yigit@intel.com> <20180117215802.90809-1-ferruh.yigit@intel.com> <3175063.1rsM1vLuis@xps> <2341214.iScQkZ5rM7@xps> From: Ferruh Yigit Message-ID: Date: Thu, 18 Jan 2018 10:15:03 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <2341214.iScQkZ5rM7@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/6] ethdev: fix port id storage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 10:15:08 -0000 On 1/17/2018 10:19 PM, Thomas Monjalon wrote: > 17/01/2018 23:09, Thomas Monjalon: >> 17/01/2018 22:57, Ferruh Yigit: >>> port_id is now 16bits, update function parameter according. >>> >>> Fixes: 4c270218aa26 ("ethdev: support security APIs") >>> Cc: stable@dpdk.org >>> Cc: declan.doherty@intel.com >>> >>> Signed-off-by: Ferruh Yigit >>> Acked-by: Hemant Agrawal >> >> Obviously, >> Acked-by: Thomas Monjalon > > Not so obvious actually. > It is a good fix, but an API change. It is more like API fix. While whole library is using 16bits for port_id, I think we shouldn't deliver release with this specific API uses 8bits. I am for getting this because what it does is wrong. > This function was not declared experimental. > It must wait 18.05. > > And the function has no doxygen! There was a request to add it [1] but not received the patch yet. [1] https://dpdk.org/ml/archives/dev/2017-December/082824.html > And the function was placed randomly in the middle of struct declarations! > One more proof of the poor quality of rte_security stuff. >