From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id ED02D3256 for ; Mon, 10 Dec 2018 07:57:06 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 38049BC0064; Mon, 10 Dec 2018 06:57:05 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 10 Dec 2018 06:57:00 +0000 To: Qi Zhang , Yongseok Koh CC: "dev@dpdk.org" , Ivan Malov From: Andrew Rybchenko Message-ID: Date: Mon, 10 Dec 2018 09:56:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24276.003 X-TM-AS-Result: No-2.392900-8.000000-10 X-TMASE-MatchedRID: j3Po2fwqyGRwSkt7pf4K+LdQIb8hCnY+bnWMzHijq6Sen0qBdy7fjDzx KygWHJr/VwVGg7TlOfjcf/VR1nlQ7m5/NyTKlG69sTcWkxuDrdJ8yGO3dvk8/QJ1vk7thYuGUdf EKc10rU4vQVE0yOGFpW6Pnn0tTaMe31upjFk7WXTkGAR1SqoA1H0tCKdnhB58O5QxsrU10s/6C0 ePs7A07ZSWEIQ2SV63o+28hB1aYfIWFR5w2ylZD4dNxNzNVHvDrZ/cAjTwJPAEItOcio5m1CD7D yXhusjAOtdeiUhsLShpn2fF/7cC031xNJ4nIn/t2JYUlMOktfG9on7lreBAZ2WGmfg8DJ6twbzv OZYCiGEI9kdNJejuD/wUUe/vR9tHV52vNTgr9BTY6luG5YdZZsTnihm4os/F X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.392900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24276.003 X-MDID: 1544425026-9NHKnHebBT53 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] Incorrectly applied ethdev: fix queue start to 17.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 06:57:07 -0000 Hi, Do I understand correctly that the following patch was incorrectly applied on 17.11 since changes are done in queue stop functions instead of queue start functions? If so, could you fix it, please. Also I think it makes sense to check other stable branches as well. We observe regressions because of the changeset. Andrew. commit d48890a39af7ae5c2d79dad02dd3ea3df8b6db82 Author: Qi Zhang Date:   Thu Mar 22 20:59:01 2018 +0800     ethdev: fix queue start     [ upstream commit 239c9b435ad4abcac89b5d2480a0c21ce8b8288f ]     Device must be started before start any queue.     Fixes: 0748be2cf9a2 ("ethdev: queue start and stop")     Signed-off-by: Qi Zhang     Acked-by: Konstantin Ananyev