From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B1A1A0C43; Tue, 14 Sep 2021 18:17:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E60FF4069C; Tue, 14 Sep 2021 18:17:33 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 316464068F for ; Tue, 14 Sep 2021 18:17:33 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 822687F4FE; Tue, 14 Sep 2021 19:17:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 822687F4FE DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1631636252; bh=675BjISvXOv+BZdRJALGL9L+nVOSru9MhzkHsk+enuc=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=wX+8qf3IbhiSnBk8JdeYswIE4/++AHA5gqLy5muLkk0aaSqBWPbMuJVkh96tT7Bf0 HvLIzG4rvu7mAm1hd659kpwlVY65FY28NCUrWbZ4gtwTpHlTszm42R1VPXCcQ0SCj1 hDhe8TeNv/UOtd1VhIuOjQtBEGsFB0vckKxTcVq8= To: Ferruh Yigit , Xiaoyun Li Cc: dev@dpdk.org, Xueming Li , Viacheslav Galaktionov , Andy Moreton References: <20210827063935.1834143-1-andrew.rybchenko@oktetlabs.ru> <20210831161242.3465395-1-andrew.rybchenko@oktetlabs.ru> <78232368-50f3-a03e-aedf-b7f0a8249792@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Tue, 14 Sep 2021 19:17:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <78232368-50f3-a03e-aedf-b7f0a8249792@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/14/21 6:52 PM, Ferruh Yigit wrote: > On 8/31/2021 5:12 PM, Andrew Rybchenko wrote: >> From: Viacheslav Galaktionov >> >> Make it simpler to debug configurations and code related to the representor >> info API. >> >> Signed-off-by: Viacheslav Galaktionov >> Signed-off-by: Andrew Rybchenko >> Reviewed-by: Andy Moreton >> --- >> v2: >> - change output format to log just one line per range >> >> app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 135 insertions(+) >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index 82253bc751..ae700f9dd1 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result, >> " Show port supported ptypes" >> " for a specific port\n\n" >> >> + "show port (port_id) representor info\n" >> + " Show supported representors" >> + " for a specific port\n\n" >> + > > What do you think extending existing "show port info #" command instead of > creating a new command for it? My fear with such approach is that output of the "show port info #" is already too long and adding representors info there will make it even much longer. > Since "show port info #" is a well known command, it can simplify the usage. > When port is representor port it can display additional info. > Just to be clear: it will output information for "backer" (or parent) port which should be used to create representors.