From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4097D41D9B; Tue, 28 Feb 2023 11:02:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31E4F41140; Tue, 28 Feb 2023 11:02:59 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2057.outbound.protection.outlook.com [40.107.237.57]) by mails.dpdk.org (Postfix) with ESMTP id A909D4113F for ; Tue, 28 Feb 2023 11:02:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j3QSohTb6EpLyHiS8hX4LgE0HhkQ2gm+m+TKhJAX5ok8rQ3rbnuFySv6N4LHiVDV7H3lxv6bEhBUvF/nVQjHUfq8OreyAYXZdfDf9XmiVGk2qVONbiqvCS5duIBPGWRdqxcHp9twtvThJ1m94uHPvytwWVSOMwCsJ1iklDDZebS32sNiycgH/PJgsbGXnJFxe7fvlroM5OOz1UZZM2VlB//Ki6K3XuvVf1X5CDlDG4I7nJA2LjDZlpoHBYc7xh70SpV373bYybGE2XejR16uM8PFTTYSwYt6FCTMwlTDAQCASke4XBTfir7YYishUr0NN18YCWb/Ve0Tp32UMvYqig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+6K5T+b3fAu/BfkHae8T7oz6dqJLIa4rCK2ISOgmCWM=; b=lv56TJlpnklxla/asa0dm/1hXZzXISeFRcKY8gJ1dOTcmIn0hfFQhDjMwYHnU2mYgSlwihV7sGCowA+L3mv23+701WOqOvFtBA2XI72ukxs/zPBx5m2u49nczwpxxogevPLWJxHAg9zgCUbA49ptasPgF+vOHpm+E5jW3VSSzz3jWWWG+GKUWa/Aj9AaZXvQFLdvAS/agyJfISr7xVhLdJXcGdSHw1idiQdOU1mxSCWnvTfp6uetQnRyHuAYh34/PrymD4dPDfJuZjSXJLQpf1z1Wl91xwPYoOShydJB0RZU4566Vyk+OAaiZEk1cGC0zKWROEs8bd0Oa8fzrCzbAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+6K5T+b3fAu/BfkHae8T7oz6dqJLIa4rCK2ISOgmCWM=; b=R2J6jCDb3ShzeSSBzbMFMLLJUgxF5Gh+ZKpnYsZwn+LoCvu6SRLftjjUtFJPkpnU9oCIgOqAQr+GYIdpF1xILCmJM+VSl3i5Q7YrSon60viX6TswUDkxW3J9T8Pr0LzaU8IgT2r02Y8f+dLqbY5oO05m+FW5JVVOHFW/2yswoD4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7420.namprd12.prod.outlook.com (2603:10b6:806:2a7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 10:02:56 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 10:02:56 +0000 Message-ID: Date: Tue, 28 Feb 2023 10:02:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 03/21] net/cpfl: add Rx queue setup Content-Language: en-US To: "Liu, Mingxia" , "dev@dpdk.org" , "Xing, Beilei" , "Zhang, Yuying" References: <20230213021956.2953088-1-mingxia.liu@intel.com> <20230216003010.3439881-1-mingxia.liu@intel.com> <20230216003010.3439881-4-mingxia.liu@intel.com> <44469963-92a1-82d0-ff77-8ff176cb81e3@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0245.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7420:EE_ X-MS-Office365-Filtering-Correlation-Id: 768003ad-d729-4f18-3c8f-08db1972f6aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OIs9xrLYyDK61zztcwOKbkvzFKksiJq6uesYehZhzDlUtskrG5J0tV3XPj/JynMchLOb78md4NwGnie3ibNgBOwKbHyqnm1jVS6vpKzAvfHXUL9jEJhNbr4hQjFaVSlHwGH85VxmBnKn9UTC+ruGoAgi4bE3TjfGQ80B+kdag7UCRbzeS4QzoPE5N/tCjnB9NyTRM7HnXNaYmssW2y3qkg5RXUBgBFVz5PYXTk68YELbzNz7mIcF195WLOyYLI+uLn+m22uIle/YR82RYxZttujZoxG3G4ubUpBxKMaIqMHBS66Gyz/gd1MlOLqg6tLayXdXH83bc08dOQwpdauRB4lqU0tW1qvWjWPGWNbGeY/Z0vgWdlJydaETDrES/VWz/ziT5bLMtL6xkC9cbSIpO0FIbm+Avhcf2tTI3MnQeZW0EApHcWICZqSVxwjOzAFeJ6jQmQFkJwpTilV8AWEWsceTIGxr0isdznKof0oBF9SWEbP17j/5gYUUQEZgUbddj9SAkveW+nSFa0kFNGH/HLmT03QXXQ0xSLoLQkQvW55adBj/9Ottktk3q0OJ07Ze5z9z6oKhnwdgXIze2mjBnhjJJp5bmBjCF1PolDTkjELuWfcvc3uAAVYjwnL8C12nV8OXXVvPsLoHSPTA78KlKQe+/3X6Vp7mCEo/JNooIexZYeYWtZXQjMOOrkC2ACHzVzxNL97RDM5Nbhi30Tq7FM3SCsWs5BdG5ZKXy5wQFOg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(396003)(366004)(376002)(136003)(451199018)(31686004)(86362001)(36756003)(41300700001)(66476007)(66946007)(66556008)(5660300002)(8936002)(31696002)(8676002)(44832011)(2906002)(38100700002)(6666004)(6486002)(478600001)(316002)(83380400001)(110136005)(26005)(2616005)(53546011)(186003)(6506007)(6512007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGZEL1BoSnpmUzU5a1AvRm1uMXZuUGlIMklOOGRsTmVFVllWK3QvZlZpbWVl?= =?utf-8?B?TkxQekZhQy8yaVRvYzhYOTNwY3ZIQk10RmhpZkZYdlNwc1NzVWNEaDdmRnRo?= =?utf-8?B?VDhpZ3FVRGRTL0JWS3FxSmpWdWp5QlRKL1pLcmo4OEJ2eXF5akMzNU4vWjNr?= =?utf-8?B?SEpYa2VaTldlSXN4bWVsc3RQVnM1bWlEM2E4UTA0NHlTY3RiY1oraU81WFJx?= =?utf-8?B?VGptdzFHdXFpTjNmZ2FmT09BdlZjcUVvZncyWGIzNDlsanpydU1QWkxnaVFO?= =?utf-8?B?MGVKK09Fd0h0cHJ4VGFiQXk4OVJiRFFVSWpHVHNXWTg0NjhLSVBXbzNEaVZG?= =?utf-8?B?VzM2cGNOazJmT0JDUVJWU1ppbmZHYUFDN1dIWHArSjBUMllhbTc0bUQyNmFN?= =?utf-8?B?NE9aMXZZUjhiakdMVXRDQ2dxeUtpZXM3d2JKWktHSnBWYlY4Q1JGb3g1c1BM?= =?utf-8?B?ak9SZHE4WUs1NzRsYzRwUnBxSEVyQ1NuRHJhRCswa1lyUW9TQkp1bTZwVFo4?= =?utf-8?B?enZjOVFJeFVsck1lVkx5K0U2RGlCYk1ZQ3NkOFA0bUh4U1hITGxjUE55aXdZ?= =?utf-8?B?SCtVclpkUkZUaDJnVjRUTVFscW10Wk1iNlhYT094Qytzci84Yko1ZFpHbDVy?= =?utf-8?B?NzJMZ2NjTllOWnh6NHYxQmdkcmF3eVg4RHdkQmp1Z1A2ZFYybVdCVkVxTDhZ?= =?utf-8?B?ckpFUHpvb05vRmZkMWFSZ1JlSTd6RGNzMkF3UkZHdUpYdXRIMkdSaVRGSTBD?= =?utf-8?B?Nm85a0pORDBtNDZTQkV6eWorZUFuOUpac2F4TVlqN21IL2xPUXdkaVVXMElX?= =?utf-8?B?bXp6NmRZWnlCTU4vQ2g2MndxOGFpenJRWHF3NE1mUUt2WnhNQjBSOFl1Z0tY?= =?utf-8?B?WU11SzQ2dmttWExWdHNBQ1pKL21FdmJwdjdXRGZTamxTL3E0ZHhuSzFpKzhV?= =?utf-8?B?bm9RdUU2VXBsUk9USHI5MDhGMmlVR2hQL2pBTVF1THlZWExvSUhYMDlvRkJK?= =?utf-8?B?a2xtWVFFQnVPdy9KbUJtSklTUU02ck52aDRxVFBOT3J1bVJzY05YaVhwUDFI?= =?utf-8?B?bUhSNGJGWE1PbERzZEpKZXVwTjRoa0lCYU8rbGVGUVQ2T2kza0JkUHd0V2lr?= =?utf-8?B?Q29kcit1SFdZSC9VbDhTRzN4ZkpHMkE5a3Qyd0xkdkpndUlUM0ovbjIvN3B2?= =?utf-8?B?WVYvWStnNElSbGpreGNVSHJmMlI3cGEySm1NMjkxQXREaVlualg3ZE95aU94?= =?utf-8?B?YnlGeXNKeHlkT1hIMFFNVXpZd3drMy9vQVN2SjU0d2JVUGp5VnU2aU90TXdl?= =?utf-8?B?SEIxYmhCRWZDR1ZtZnV3QWpKZFJwdWwvb3dOZkJ5OE12a3VwNkFkMEdhZUMw?= =?utf-8?B?UHFLN1ZtM09pMWE1RDBsTjZudXI2bENaOThBK3lpZ0pvRWNIeGo1aVBCTFA4?= =?utf-8?B?YzVnME9JKzdIbG1oSitKK3hicHJoVGFvaUNOdm9LQ2pMNXF0dHJOS1V4TGVk?= =?utf-8?B?Q2NBS1VmWEZGKytxc1I4emVDSzVPVVlyZWxtMTVXMzZXcGczUXUwRXhCZHRH?= =?utf-8?B?N0greklRRlVsY0pKcWNOdDR3NHRxREpReEtZU1AvVlRZYlBtUENLU2Y4QzFP?= =?utf-8?B?dWFLTldhbE0vNGVRK2lwaTR3Tk93US92NUg3cUJSOVJMQU1CTWdoV1VtaVdU?= =?utf-8?B?QlBHWDNZQ2QyenNsOFZZak9RVW1zWXBIZExZeWhlT0pxZlhENFlNYTlNVkp4?= =?utf-8?B?cmVFams5Rnl4UVdvU3oweEFGbEZjUVNSQVlFMStJdmtMa1YwSTlsK3QrdFBT?= =?utf-8?B?UE1pMk54SVoxdGRBcE1IVTFyaEtnVHdEMXZEZTBGUDVPaXVVUXA5MEV4eDEv?= =?utf-8?B?WGh2b2ZUUDRIOXlTVlB0YWw4bStOVmI0ZEVPR1NBdUx4V3lnZWtRMnEvMEFw?= =?utf-8?B?a3Avd3BVN3JZU0V6TE54aGZwNkVtQXBvN0xFbG5VSWpjMlV1QUVLQmZxQWhB?= =?utf-8?B?N29jdEZxME9MT1lIOUhhZUh1UUJKcnhRUmJtZ3RMSzVTMHdCUE1UeG1iYmY2?= =?utf-8?B?UlpmZHArUlZaWWVBRE96aGl1NU5wR1gwb1d6QUZUSFJxMFIvTGhZbnk3K2NQ?= =?utf-8?Q?tCcwP40DWOqT37INJ1xbwsELW?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 768003ad-d729-4f18-3c8f-08db1972f6aa X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 10:02:56.0104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RQElcLghy4r7rjhI1Js1bKZicdvfj/B69iu6ZZiE0NpLiGwIfv3wdraYJ5X4E1b7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7420 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/28/2023 3:03 AM, Liu, Mingxia wrote: > Thanks or your comments, we will use enums to differentiate queues. > > As for 'bufq1'&'bufq2', they are members of struct idpf_rx_queue, defined in idpf commen module, > And it involves idpf pmd code, so it's better to improve it in the later fixed patch. > OK >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, February 28, 2023 5:46 AM >> To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei >> ; Zhang, Yuying >> Subject: Re: [PATCH v7 03/21] net/cpfl: add Rx queue setup >> >> On 2/16/2023 12:29 AM, Mingxia Liu wrote: >>> Add support for rx_queue_setup ops. >>> >>> Signed-off-by: Mingxia Liu >> >> <...> >> >>> + >>> + if (bufq_id == 1) { >>> + rxq->bufq1 = bufq; >>> + } else if (bufq_id == 2) { >>> + rxq->bufq2 = bufq; >> >> For readability better to use enums to diffrentiate queues, instead of using >> 1 and 2 as paramter to function. >> >> Also I wonder if queue variable names can be improved too, from 'bufq1' >> & 'bufq2' to something more descriptive.