From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62BDFA0350; Mon, 28 Feb 2022 15:51:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D14A4068C; Mon, 28 Feb 2022 15:51:48 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 49F2240140 for ; Mon, 28 Feb 2022 15:51:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646059906; x=1677595906; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=kjFNlatsfJsC75wxf9u7IImajOMTkbH5d5cBOjtaEPQ=; b=QKGZm40C7qigTTGGjDstKL1Pj4/AaVqZSSUv+TSSXo1UuTQnIrSit9vw B1N2E8ICv3s6cjTnRcQ5dtYdQwkJ/dUfeJ9CVXC6s5Yqww5Ifgu+Ua43R 6cQ6CvNQ8/z7lVWEgbt5tUnvDuyNU5ELx4byYyf4DItG15jcYPNpjWrvq Qte92UMiSC+rdAuxHZ2NlhRXRTpLWEsBv2DOJhlU+L/9JCSNoKRfrutCe LUFaF0GUEq5Ty4E0NFlhf2Ia0xBfE6wxKjGIsXnlzurkgWKoopB7lrJ/p 0XwNC6ZGRy16YTx8j1s7VVz120QgeOCVXBrVIygg8rsXZINydtQjStYtS A==; X-IronPort-AV: E=McAfee;i="6200,9189,10271"; a="277556820" X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="277556820" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 06:51:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="544755116" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 28 Feb 2022 06:51:45 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 28 Feb 2022 06:51:44 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 28 Feb 2022 06:51:44 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Mon, 28 Feb 2022 06:51:44 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 28 Feb 2022 06:51:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TwOxGmwPvAtV+43NWENVJj2VqhHShm+LjHIDClK335fOyl1wDE3e1K8Lbvi/Rwv26ZGxPogMJE1pI8N3fqcN2oLOHfCR2wNtuELGfFDv9go5x8PXRkJNPEJcMNHS6iiMLRn1QR2kbpbahJ3z7ejzioP7qIHKec4vKSWejRM+A8Z42DJ+LzySfMHBUhm34VISmCKyexe4LF9vi/RQRBT7+NUTf15bMXwEv5iwcLBYyrwy4CCPorzodd37gKofFC5dXXloHATJ6xrA9NkHBiPtRLdswx2ua+0bsm+A37OeNqzuICyerbQ3TB2abZ5IUB58DgfdgrbuXS8nH0kFH5eWjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hGT2QoxN3+iq61ZsQ4OPfFc9TQHNT79R28wKDBJHG54=; b=YixpU5gF0SyHt8GnrYv377gXuhVZQ69dBTkwcbv90VvWMqKwvTh+z8FtX+/72qJWrJRrpcZ2xj39GS0CH8gBBiUWcIgtKsREB8o8deW8ngWJvCqlQuKWv1M+N2LiwlfO9WuyMZS8maRJ6eUc6e/BL3HfSgasCAvWiq6SHw4jvQXptoPDjHFGfJVbb4meZ9hM5jVyplY51Ydc8xnsYwhizxMLPVeZ6SEWHZs96ntOhGcORQlxgSoSW2qcKyimnGL13u/qpNoOYpBPac55MWxwN+wWKWUpmq10jkl5IiqXVA/BUHrVQWAvtf/0HMrowMKXpZkct6DkinRVm8gUsS333A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM4PR11MB6044.namprd11.prod.outlook.com (2603:10b6:8:63::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Mon, 28 Feb 2022 14:51:41 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%5]) with mapi id 15.20.5017.027; Mon, 28 Feb 2022 14:51:41 +0000 Message-ID: Date: Mon, 28 Feb 2022 14:51:36 +0000 Content-Language: en-US To: John Miller , CC: References: <20220226124454.68600-1-john.miller@atomicrules.com> From: Ferruh Yigit Subject: Re: [PATCH] net/ark: support multi-port pkt generation X-User: ferruhy In-Reply-To: <20220226124454.68600-1-john.miller@atomicrules.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0016.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::10) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f063b01-55e8-4e3d-4fc3-08d9fac9d475 X-MS-TrafficTypeDiagnostic: DM4PR11MB6044:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SMh+ecFrjAvuy7MvEaIl3h3g7aWOxAGyEyLvHbeg1tj5B0zNk/966skrzcTJJdyGA1K3S1qRnB1STbLTqnQkA954sfs2iXGhSkv6wjDFRdPGXBgcCzT090ecTl46hsAr74fLEnpJV2nuisL88ujBXbhdc1pQZdMdGmqOxodE9IettYIub59cQaCY6uLYYvhqyAiK9RLkGvszXvUOeXX6ObEFEyySgLvMjKCNUHCLh8SJXQV0VyvRrBzJGZ2CDTJxY3DWMcUJP9McMIqfaUHDNtPET2zGa6xMD+CgoYW4ifgc3lF41YLpW7WnZto+TL0aIKFIt5e+ZVDpSzlgfMqWpOstqnLplJL9UTwv6KZiG7XipFFKCms90LdmkN8i/YLgGJzEmN2I4ch4wrztwuKbtgL5zpz/1SnDbS21xz+AcWELwgE22Fj5hh8nxqyJycI1AzdILYMQHZ86NgTsN6U/sZkkTiQKhfViHV9b81pggyYTXEj4+nvKLApNAItwT20Dx+y8YbIAiH584wha1yI9ZdO1ILI6d43wxWB1Jl725WKhuthlYhB06oCHy8KIEq/dUMXLfmqIgL/liAZe9h+E/t1CTW4oTW4nD4j3w4xbvBxmP5pXbVpG5xDgAeVXyrmd0h6NSHfl113aWbMU0WV5YAmLopmT9jbhNu4aCBuufd1nsDzYs7G/5vFirlt/nAQsDl1HAaLanf2uPV3tUSY5FA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6486002)(316002)(6506007)(53546011)(26005)(6666004)(2616005)(186003)(6512007)(44832011)(508600001)(8936002)(5660300002)(86362001)(36756003)(83380400001)(31686004)(2906002)(31696002)(38100700002)(66556008)(66946007)(82960400001)(66476007)(8676002)(4326008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVcwemp1cTVrWWN3YkU1dUphT0FDRTIxanltNnN2Mndhb0o5KzFTRnU2RGRq?= =?utf-8?B?K1h2cmQ3MlM2VGlYUnVwMGZ2bGJSYWtBU205b3FZaG1iOEVHcUViY0tQN1Jp?= =?utf-8?B?N2t0Ty9SdWZkRTN0L0tlZU84QU5qRFVOL1Fvd1ZBNktVRVA1ZkR4enlTTWE3?= =?utf-8?B?OG1icVAvSVBRdzJJWnc4dDQ2YlNxUHNSS0VaK201Z3BTU3p3MnZOenRIV0tz?= =?utf-8?B?eDdkQ2ZDK1NMdXM4cVAxeFZLRmRkOWdDM0VhSm0vZGxRU1NZNkVHUC9TenJD?= =?utf-8?B?QVJGMnplMUpBdWQ1dnBybXU4cStLV1pWNWtHWXdlOWV4TlB1cndPUUVlTXZB?= =?utf-8?B?aGo3QUM5T2NtWFZROXcwZ3lEN2VjdWxhVHE4cHh5Zy9lN0xhZ0V3RXF3U09j?= =?utf-8?B?YzhkL2RudDViYUozaWwzUVM0bUYvWFdGaUxTQUx1MEQzc2cxd3oybERZdDM2?= =?utf-8?B?TEZYcEhVb0ErNUNvSS9jUU1BUWg2akh3ekdGTFVHWjBFa1BLOEl6U3Q2L1JI?= =?utf-8?B?RkhQWjRWODFrdGhZbkZTa0VLbnk5aXZyc1IreXcrWm4wN2liTTl4K0U2VkJn?= =?utf-8?B?UnphdHlhMkNFZzVpZWtpU0lFdDhkaDNZVUlITFZVdEErT21jdTgzdVFyVFh6?= =?utf-8?B?dDBwOTV3elVscjdTVFJSa1FPZXJHUnkzY09Cd00vQjFiMU5SMVFNcjdWbHhC?= =?utf-8?B?cGF0ZUszbXN4ZVBSd0tHNGFYK3J5Ynk0R2ZvZURZeUlpYktlenhsdXYxeUJG?= =?utf-8?B?MHNvV3hXVmZ6OTRBa05yS09aQWJYOFFCQ2lmTGZiYTNYdENEQWZoY3Z3dXJW?= =?utf-8?B?ZEl5dWI1QWZDWmRRR1U1c0JUemZLbEdCbkJjK3ZLUVRkYUR5N1B0UHZyMUhm?= =?utf-8?B?TmlNeGpSVTFQUkpnakE3WlVJUkpPUTJTZU5VRGZqQzlZYzB0RmxwamhNaCtu?= =?utf-8?B?VktwSGZKblFOSkpyaWE1SHZOSXRWYkRTaUsvdmFoTTF2eWxQSm03eTkvZnFy?= =?utf-8?B?MUU4eUZOWXE0L0dtNDV4SWx3bGR0cG5NSjRVL20vRUhFOS9XNFBZa2puV1hm?= =?utf-8?B?NE15dUZYKzM4Qk1iSjNTWFRTZktJRUhjeXJseDdsZ0pGNVd3UDdIcVRvTFpo?= =?utf-8?B?MUR1SzZLd2YvNWVxRnRwNlZ4Ui9HWWRsZGRLQzRrUFN2dmtyUE15SGtmUXY3?= =?utf-8?B?MStXdEgvRmlSanI4K2Z1ZVNGaWZFQ2hDVUNIOUJrQ1dXR3dEaDNzb1dsOWtM?= =?utf-8?B?bnIzSUZQU1FCOVNNWkt1Sm5SVjRTN0plamRHU1FJYkpNUjNRVWxsOFNIVFZC?= =?utf-8?B?SnJ2M3JWM2NtRjY3bGNCb0VvdGF0UDRuK0lrUUJTekN3NkdtbTNxUHk3d1kz?= =?utf-8?B?MncyZUU0bWZwUVF4dnAvVGM3V1JueUk4bmJ1bEUxbm5uTzlYY2lOS0tveGMx?= =?utf-8?B?STRiMzRMVFNHNjB3YjhPcEIxRnltVkg1Y21pb3dSREVsWmwxNW0yU0FDWkRw?= =?utf-8?B?Y1FjY2czK0t3MEI1NzBRY2pDVDA2Q2kyREZ5Rnl5Q3VuanZ6cEZoK0hZdFEw?= =?utf-8?B?UVFaQTdPa3R2U1hsWUxtbzVCL0t2OHdrMVVKSjVXTThuV3dZWTNmeHNuMnNa?= =?utf-8?B?WEtmZ0Y2dElHSllvWVVjT0YvR2VDbTNUZ2ZKWWFnYjlHWHFQMnA2UmVpUThx?= =?utf-8?B?RHpuWFBxc3h6RGt6dXdKTkZENWQvZXNDa2FMMzZOT3IzdTFlZk8vTmRjMGhU?= =?utf-8?B?dkxkL0NnelFPRUk4Snk2RTlPRUVlRjg4WGk3ZWZKbWxRSUdHT1lTbVNKTnVI?= =?utf-8?B?YWpxdnBZTWhLSC9BWmNyUlY2Ulc3cDRlUHIwcnFORE5VRFR2RWFVSzVVUWd6?= =?utf-8?B?dDMxVWhLWGs0eXZqVVZ1Q3RILzFsSnNmdUVDdCsxcElORHUvRjZEUXZIY080?= =?utf-8?B?QVFBN3dDUlc3eG40KzlneFJ3ZnFQSEpnR1A1OC9WWDZqeGg0YWQ0L3c0S1hB?= =?utf-8?B?MnAvd2I2eHFTdzljc040eHBiYW0xYTd6OEZzUW9WTjd4Y2VWTXJXMmhFK25Y?= =?utf-8?B?VEhQbTdERjN1dUIzenNFUktrRU9Lc2NoMFBkOE9jUmZkTzh6QURENkxGT2dM?= =?utf-8?B?amdiL2VMTDhlT3E2YjBnYnBxUENaSWkzb3VhUzBFVDNUeGZPTm93c2NNK2ZB?= =?utf-8?Q?EYNJm5GeURqJs+jBBCAKMb8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8f063b01-55e8-4e3d-4fc3-08d9fac9d475 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 14:51:41.1963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fasOeWYpYTGPgtx0vQa1ir/YG2jd5HON1hJ8JyriQCMy/xLiPub5SMpiYyLD3/wKCwKWHpu3Hj1LGgEwqoezoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6044 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/26/2022 12:44 PM, John Miller wrote: > Added support for packet generation in > multi-port Arkville implementations. The packet > generator is a singleton within the device but is > capable of generating packets for any port within > one device. > > Signed-off-by: John Miller > --- > drivers/net/ark/ark_ethdev.c | 4 +++- > drivers/net/ark/ark_global.h | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c > index 230a1272e9..980e1a4a3b 100644 > --- a/drivers/net/ark/ark_ethdev.c > +++ b/drivers/net/ark/ark_ethdev.c > @@ -441,6 +441,7 @@ ark_config_device(struct rte_eth_dev *dev) > * known state > */ > ark->start_pg = 0; > + ark->pg_running = 0; > ark->pg = ark_pktgen_init(ark->pktgen.v, 0, 1); > if (ark->pg == NULL) > return -1; > @@ -562,7 +563,7 @@ eth_ark_dev_start(struct rte_eth_dev *dev) > if (ark->start_pg) > ark_pktchkr_run(ark->pc); > > - if (ark->start_pg && (dev->data->port_id == 0)) { > + if (ark->start_pg && !ark->pg_running) { > pthread_t thread; > > /* Delay packet generatpr start allow the hardware to be ready > @@ -574,6 +575,7 @@ eth_ark_dev_start(struct rte_eth_dev *dev) > "starter thread\n"); > return -1; > } > + ark->pg_running = 1; Should there be a place 'ark->pg_running' set back to '0', like 'eth_ark_dev_stop()'? Or is this delay thread is only required once in first init per port? Btw, if there will change, you may consider thread name, "ark-delay-pg", get port_id to differentiate multiple threads, like "ark-delay-pg_0", "ark-delay-pg_1" ... > } > > if (ark->user_ext.dev_start) > diff --git a/drivers/net/ark/ark_global.h b/drivers/net/ark/ark_global.h > index 49193ac5b3..3c3a712bc8 100644 > --- a/drivers/net/ark/ark_global.h > +++ b/drivers/net/ark/ark_global.h > @@ -107,6 +107,7 @@ struct ark_adapter { > > /* Pointers to packet generator and checker */ > int start_pg; > + uint16_t pg_running; > ark_pkt_gen_t pg; > ark_pkt_chkr_t pc; > ark_pkt_dir_t pd;