From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6B24A7CBD for ; Tue, 3 Oct 2017 01:32:43 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 02 Oct 2017 16:32:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,471,1500966000"; d="scan'208";a="906044183" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.131]) ([10.241.225.131]) by FMSMGA003.fm.intel.com with ESMTP; 02 Oct 2017 16:32:41 -0700 To: "Doherty, Declan" , Gowrishankar , dev@dpdk.org Cc: Thomas Monjalon , =?UTF-8?Q?Ga=c3=abtan_Rivet?= References: <266cd54d289bfd6e9535a173c9607f0234f8b1b7.1499167396.git.gowrishankar.m@linux.vnet.ibm.com> <502c45826dbbfd2bc3f4f743aeea87f159921ae9.1505929849.git.gowrishankar.m@linux.vnet.ibm.com> <0c17c7cc-9e11-da22-c2b1-311b6f16b979@intel.com> From: Ferruh Yigit Message-ID: Date: Tue, 3 Oct 2017 00:32:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <0c17c7cc-9e11-da22-c2b1-311b6f16b979@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: support bifurcated driver in eal cli using --vdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 23:32:43 -0000 On 10/2/2017 12:06 PM, Doherty, Declan wrote: > On 20/09/2017 7:04 PM, Gowrishankar wrote: >> From: Gowrishankar Muthukrishnan >> >> At present, creating bonding devices using --vdev is broken for PMD like >> mlx5 as it is neither UIO nor VFIO based and hence PMD driver is unknown >> to find_port_id_by_pci_addr(), as below. >> >> testpmd --vdev 'net_bonding0,mode=1,slave=,socket_id=0' >> >> PMD: bond_ethdev_parse_slave_port_kvarg(150) - Invalid slave port value >> () specified >> EAL: Failed to parse slave ports for bonded device net_bonding0 >> >> This patch fixes parsing PCI ID from bonding device params by verifying >> it in RTE PCI bus, rather than checking dev->kdrv. >> >> Fixes: eac901ce ("ethdev: decouple from PCI device") >> Signed-off-by: Gowrishankar Muthukrishnan >> --- <...> > Acked-by: Declan Doherty Reviewed-by: Gaetan Rivet Applied to dpdk-next-net/master, thanks. (Gaetan, we may ask your help during merge on this.)