From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89AE1A0548; Tue, 22 Jun 2021 15:28:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01A4B4003F; Tue, 22 Jun 2021 15:28:04 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 22D174003C for ; Tue, 22 Jun 2021 15:28:01 +0200 (CEST) IronPort-SDR: 1GG/bljuY2CNz36FxS3BDzW69mYlgbYAhciaTsAp/bBkdgT4cAr4+GGpUR2cTaYy2kcwzINvl2 vGfiLezGASaw== X-IronPort-AV: E=McAfee;i="6200,9189,10022"; a="206996812" X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="206996812" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 06:28:00 -0700 IronPort-SDR: 1lEcAoor3pn/kqJPflYBrcnpHnWKSi1AcT+kLf5sYzqrZ3ywm7uNKBfJXmGbaZ6B2QL2ki+t46 70DPdT7dohXg== X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="423317188" Received: from ebaldwin-mobl1.ger.corp.intel.com (HELO [10.252.14.169]) ([10.252.14.169]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 06:27:59 -0700 To: dev@dpdk.org Cc: anatoly.burakov@intel.com, stephen@networkplumber.org, Richael Zhuang , Reshma Pattan , nd References: <20210622125853.2798-1-david.hunt@intel.com> <20210622125853.2798-2-david.hunt@intel.com> From: David Hunt Message-ID: Date: Tue, 22 Jun 2021 14:27:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210622125853.2798-2-david.hunt@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v5 2/2] power: refactor pstate and acpi code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Adding people to the CC list that were on v4 of this patch set, and Richael who raised some issues in v4. On 22/6/2021 1:58 PM, David Hunt wrote: > From: Anatoly Burakov > > Currently, ACPI and PSTATE modes have lots of code duplication, > confusing logic, and a bunch of other issues that can, and have, led to > various bugs and resource leaks. > > This commit factors out the common parts of sysfs reading/writing for > ACPI and PSTATE drivers. > > Signed-off-by: Anatoly Burakov > Signed-off-by: David Hunt > > --- > changes in v2 (should read v5) > * fixed bugs raised by Richael Zhuang in review - open file rw+, etc. > * removed FOPS* and FOPEN* macros, which contained control statements. > * fixed some checkpatch warnings. So in the process of posting v5, I picked the email id from v4 in patchwork, used that in my --in-reply-to, and somehow it screwed up the threading as it looks like I'm responding to v3. So I'm sending this email to make sure all the people CC'd in v4 are included in this (v5). Anatoly is busy at the moment, so I'm addressing the issues raised in v4, and additionally adressing the checkpatch issues where it does not like the macros with control statements, so removing those, as I don't like them either. Regards, Dave.