From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Di ChenxuX <chenxux.di@intel.com>, dev@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, Yang Qiming <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove
Date: Thu, 24 Oct 2019 18:24:13 +0100 [thread overview]
Message-ID: <cc98ecde-a365-cd9b-3c52-a2818a1be8aa@intel.com> (raw)
In-Reply-To: <20191024010310.35882-1-chenxux.di@intel.com>
On 10/24/2019 2:03 AM, Di ChenxuX wrote:
> Hotplug remove cause infinite loops. Fix by canceling port_close
> before port_detach function when rmv_port_callback.
Can you please give more details/backtrace of how loop happens?
How can trigger it?
>
> Fixes: ac89d46096d5 ("net/i40e: release port upon close")
>
> Signed-off-by: Di ChenxuX <chenxux.di@intel.com>
> ---
> app/test-pmd/testpmd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 5701f3141..a264644a1 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2708,7 +2708,6 @@ rmv_port_callback(void *arg)
> no_link_check = 1;
> stop_port(port_id);
> no_link_check = org_no_link_check;
> - close_port(port_id);
> detach_port_device(port_id);
> if (need_to_start)
> start_packet_forwarding(0);
>
next prev parent reply other threads:[~2019-10-24 17:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 1:03 Di ChenxuX
2019-10-24 11:28 ` Iremonger, Bernard
2019-10-24 17:24 ` Ferruh Yigit [this message]
2019-10-25 1:48 ` Di, ChenxuX
2019-10-27 22:35 ` Thomas Monjalon
2019-10-29 12:13 ` Ferruh Yigit
2019-10-28 5:51 ` Yang, Qiming
2019-11-05 13:54 ` Ferruh Yigit
2019-11-05 23:30 ` Ye Xiaolong
2019-11-06 5:08 ` [dpdk-dev] [PATCH v2] net/i40e: " Di ChenxuX
2019-11-07 2:50 ` Ye Xiaolong
2019-11-07 3:00 ` Di, ChenxuX
2019-11-07 3:11 ` Ye Xiaolong
2019-11-07 5:45 ` Di, ChenxuX
2019-11-07 5:45 ` Ye Xiaolong
2019-11-07 6:02 ` Di, ChenxuX
2019-11-07 6:23 ` [dpdk-dev] [PATCH v3] " Di ChenxuX
2019-11-11 8:42 ` Ye Xiaolong
2019-11-12 5:56 ` [dpdk-dev] [PATCH v4] " Di ChenxuX
2019-11-13 2:11 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc98ecde-a365-cd9b-3c52-a2818a1be8aa@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chenxux.di@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).