From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDD18A0C41; Wed, 15 Sep 2021 18:58:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B755941149; Wed, 15 Sep 2021 18:58:55 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 76C5E4068F for ; Wed, 15 Sep 2021 18:58:53 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="283377557" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="283377557" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:58:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="471008907" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 15 Sep 2021 09:58:52 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:58:51 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:58:51 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 09:58:51 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 09:58:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jzkBnne2Cb/dPixZUSot8esUUTX1KPok+vm2AeRCHJtJJnH5Zo3BstqNK11XGvevKCCe345OWBPBolNl/PJx/3Tql6kFqr9MRknILAzQhbWtXIZjocDQTaA+J1DxVuJBNJUATfqLpstunTExLqaJ7vj8MDXHIMtjyWpZ9sfhDjo7C5RlN/2+CORYjw8IOczJ804AP3CC9zQJN+4fjIKstXNRhJvEgldEx2DMlmJGq1tURhlUADHTP/coQtwPrTjADNA1Ho0WjKgok+tuC7GNc+PJW0IE/58XCQglVoIqEXK6aEZTu5zbfFvZP2HJBiDMKBse1uxJTEO2O+/jjUM25g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4E8xMgv5Cv7tmN2wcubMd/KmpMTwnZfcJNIqFONKr9E=; b=A3wIqetxHLYYxofs+czmTMcpQ3H+LF+t37zMO+gXoDzERYPTpXVSTcyRS8YR4wkkN56ajj0OJ5v9JP52JJgc/arCB9r2bH+EULoSYaPwD5H6jUmY0hcz9xTHFLHzs+pSIZ8W4m9JvmxZ929BHcim7gI4OGDtk8MnZnkxFssedgBLvuH7T4+UPqRPI3GYzIHySxyCjXU5GaOmdIQOn0q5rJT1yIQKQNtaNsCkyqQlk6c9PDX/Fj6mP8SoEruV7WbUYjmWX8PcPYxSW7ZZmqN70RSgLiDDHmbSxG9KoZfm64B5w86GHUluFkStVAa3awfCppGKdy/JoCj9dsCi5YWPhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4E8xMgv5Cv7tmN2wcubMd/KmpMTwnZfcJNIqFONKr9E=; b=ZXwpI9Q6G8QDWQQhRH3RHm9YqpemJ+t6XwGrGB/TiZqzMb6cpbrl/d6s91YKCuwPNeSMDuZyfh+7e7J03rvWKU+IpaRd8PNL2lYji0Y0WbndfZAJyRlaO4yD9K971cXkQGpAFPQhXFRL4x+qL5Ikv0H/hIOzKjXldOe0E1bxYqA= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5111.namprd11.prod.outlook.com (2603:10b6:510:3c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Wed, 15 Sep 2021 16:58:43 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 16:58:43 +0000 To: Hemant Agrawal References: <20210908083758.312055-1-jiawenwu@trustnetic.com> <20210908083758.312055-29-jiawenwu@trustnetic.com> CC: Jiawen Wu , , Bruce Richardson , Thomas Monjalon , "David Marchand" , Akhil Goyal From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Wed, 15 Sep 2021 17:58:37 +0100 In-Reply-To: <20210908083758.312055-29-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0801CA0049.eurprd08.prod.outlook.com (2603:10a6:4:2b::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0801CA0049.eurprd08.prod.outlook.com (2603:10a6:4:2b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 15 Sep 2021 16:58:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de445287-fbb1-4ebb-4082-08d9786a133a X-MS-TrafficTypeDiagnostic: PH0PR11MB5111: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xyzn0DvtP9DXcuwaaw0YQtN67e4XT+7faqwWXTECPAJTB4LOAEANmo1NK9FFiY2rub9IanrCkGWAVJamtWu3/b4eFkitmBRjGQMdK9r1b9hfetYGoEoRg8FbUSr631TV9QWBckO0UUCsoBKbWgMkvquhA9/CfYO1RWOie8/4sZDvvh8RZfrZ/mtTMI7JuCBqf5VQQxN2z82SZPMGy+gE27r22Av7UqWLxzy7YzLP1SfS8tAAsc86+0gS6OxCXkyJL0mX7ILABmCQEbx06539cXMypdZlcHWPuYZr2O3spdgXO6zB2OQvKylCGx5TPPABG+IagEGgDmDxzwctJZNroGTzlC0SW/dP1WHm7in8CxJn4asIYcYOcv0pfLrtvGUkiGUVkv91coSqs419scJzy/HRTRkei/f97vOMxTzXQdsEmTd36B4sdZ5oETL/zM+tdJf3huYLS+DtsxlGkZWjoXuvedBYiltg5Il6agI+z6sYCYf2+0THMpj9dWPBGo2mUkRHS0P5kvmb4dhpHj1LmhMRY0SUTfXMv4a5HpGQ4E+RQ5+oHDXdCW+9jtvxx4QZXSTWTsIJxFLtwrsqMqx0MV85bSwFpUIcvOCq1Dd36pacoiHk9zTW7SA++M8AuN+9WAp87fACcTf+neI4sZBLdgktkZQXxEUvyVFga23gd/G1N0lJPD1hRYCDzaM82JAC7XeAeK68zIAJ7X5zD9VAtg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(366004)(396003)(376002)(136003)(66556008)(66476007)(8676002)(2616005)(4744005)(44832011)(956004)(186003)(83380400001)(53546011)(66946007)(31696002)(26005)(4326008)(38100700002)(6916009)(86362001)(54906003)(31686004)(5660300002)(2906002)(36756003)(6666004)(16576012)(316002)(6486002)(8936002)(478600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TE1Ec0g0cktITDVMTXRpS3RWSHkzZUY2bDROaVhCNzJqa3FUTG15R1dSc2lr?= =?utf-8?B?eGtHNllCVEF6cjhyaWZDRTZhVnhOejNDN3JHcGhBa2NCamJoNCtvTXI0clVK?= =?utf-8?B?RmVrSzA5eXVNdUFXYlNkQ3BaVTc2dzIvVDE2SUwzV2hjU1FZREZUN01oVlhs?= =?utf-8?B?M3UzdnA1aWkrZ2RQUW93LzBPOVExYmFiV3I2dWtOL1pRbnNkY1JoV255SG5w?= =?utf-8?B?SWJxQmp1OVluMVYrT3ROUkhtVldlclZkZGNhOFdCVzU0M2JlcGwwUmhzU3RX?= =?utf-8?B?VUN1a0RSMWF6a3NxQTNoWFNYWE9lU3ovRmFFNituUU56bVVXZy81enFFL2s0?= =?utf-8?B?bm0wbnF4MHNnZTBpWWs5eFh4RUV4UlFlTHBFR29OT3RhQ2ZjVTNBa0hZaWtt?= =?utf-8?B?L1ZUWUNlR0FYNXltamlSdU5Ja0dISndRWUR5TnpGVXRMcjJVTXpRLy9hRWt4?= =?utf-8?B?MHBJZU9rY0U3N1FCdDYyRzZTay9Gdmx0SEt1OEZDOWtuNHQrMzRtQS9PaGNV?= =?utf-8?B?VzVBZ2tESnNRUEtHdjBPOU1qT2VxODRnZ1k2bGNNb2o0RmQ5Ykw5NFdtNXhP?= =?utf-8?B?YmRJOEFnYVNRUklJVEJSU1dLNzNaYnN2Ulo1MWlRMW5WODczOFBBanNSd2JQ?= =?utf-8?B?dFZZSFNFdzNTeU9JUnRXejQ0REFjenloU3RXV1MzRFB3THgxcE15RmtZdmtT?= =?utf-8?B?NnNqZWx3SzBpcEpMVStuVGhBSGdPKzd1R3FYR20zVzZ3bi8zWU5pbWhyRmp2?= =?utf-8?B?d3ozQzJjRnNkSHJCMHBaOGdOclhBa0RtNk16TXFFUUJyZmVzVVFuVkNVQnRS?= =?utf-8?B?RWs3L3YwNXFhc2EyaXE2aXRCOHp4dnhHakVNU0Fxako2ejNpS1lBOWpIMWdC?= =?utf-8?B?S1dEb2dlbDAvb04xcGpCbFE5SVJrWTNqU2JZV0kvdTMvMnVOZElTb00vUzR1?= =?utf-8?B?V2dYcVJXRVdGOWlQaVF4L1hRSTNtWlRMd3JrNG9YWE9HaFpiSHhjbjNGMUtY?= =?utf-8?B?VDhwSjFVeHJlQUY3N2FKOTBLUmN4YURXdXIxdTFFL2NaWWk1Wit0ZXFiYlQ1?= =?utf-8?B?V3gvNFo4Y00xR0x0VENlMlU1d3JyVVhXblhnQlRiU2NMWG1ERjJwcS9PejY2?= =?utf-8?B?THEwUy83NjY5UmVieE82NTEyL2pRNGxXWFFEa1VoVEVkR3JtUEVLVlpYaDRH?= =?utf-8?B?WTFLdUI4K0tZZCtTcTNGSlByUmZuWkpHU29iUzEzWFhvUFBtejJ5d0pDWVFW?= =?utf-8?B?UVNpUjJYVDRuV3gzdU8rU3lhMUpHQlJIbzQ1ZTBpWmwwYld1NnhOMGxkNkM2?= =?utf-8?B?K28xMU1pYVVlNVh2WTlQVjdpTkIzdHFPeWFyZXNNM3VMTk1TaGlseE1GS0x0?= =?utf-8?B?VWdXT1A0UDdIN0F5cXg2WFVxSVAwRVZZQzRxYkdwUWdGRXVCMW5ONGY2eUtw?= =?utf-8?B?WlBzSmtJU1dSTmhRZVlHWlk4VkVjTFhmR0wrSUJqT2loTmhzMDNlWFBCRkVU?= =?utf-8?B?ZUtsTUdSTU1QRGQzajZQVndwMW9HU2NYUy9lVVFKRDdBSm9jaWhhZVJFM1Vt?= =?utf-8?B?ZG5RMHQvL2VrMXNSV2JMS3lVZlpSMVAyUGhTL2lMY1JXSDZ3WVJRQk5KR3hy?= =?utf-8?B?d0N0U3ZlaVlTLzZPdjJqV2pUcUhaMHorNXpaREFEcWYxcnp5ZzhzYTZvalU0?= =?utf-8?B?WUhyS2htV2s2YkZzTWZubGx2SWI4TGpZSUtuOWZlTFAyZ2krWVlWcXBpb1hw?= =?utf-8?Q?1ymcFoRPRqBJJ6vBZTHjOaWZyK9ASHW0B/OGpSb?= X-MS-Exchange-CrossTenant-Network-Message-Id: de445287-fbb1-4ebb-4082-08d9786a133a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 16:58:43.5749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +o6OqFY79KBR/VtPRs/hjuPvYOSAs7QJJTgJjhPz4E5jJHNvkOWvU3iMhCPVDfUsTBOlCwS9eY48G71G6dLoTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5111 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 28/32] net/ngbe: add IPsec context creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Initialize securiry context, and support to get security > capabilities. > > Signed-off-by: Jiawen Wu <...> > --- a/drivers/net/ngbe/ngbe_ethdev.c > +++ b/drivers/net/ngbe/ngbe_ethdev.c > @@ -430,6 +430,12 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) > /* Unlock any pending hardware semaphore */ > ngbe_swfw_lock_reset(hw); > > +#ifdef RTE_LIB_SECURITY > + /* Initialize security_ctx only for primary process*/ > + if (ngbe_ipsec_ctx_create(eth_dev)) > + return -ENOMEM; > +#endif Hi Hemant, I see 'RTE_LIB_SECURITY' is still used in some PMDs, as this new PMD also uses it? Previously I assume this macro was to mark that security library is enabled, is this macro still valid? Who should set this macro now? Also can you please help reviewing this and next a few patches since they are related to the security?