From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AE96A09E4; Thu, 28 Jan 2021 02:55:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 285621410A5; Thu, 28 Jan 2021 02:55:41 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 602EE1410A4 for ; Thu, 28 Jan 2021 02:55:39 +0100 (CET) Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DR3Rd1gVwzlBZW; Thu, 28 Jan 2021 09:54:05 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Thu, 28 Jan 2021 09:55:33 +0800 To: Ferruh Yigit , CC: , , Rahul Lakkireddy References: <1611150232-609-1-git-send-email-oulijun@huawei.com> <1611150232-609-2-git-send-email-oulijun@huawei.com> <7afa888c-7087-53a7-0328-96ca890b04cc@intel.com> From: oulijun Message-ID: Date: Thu, 28 Jan 2021 09:55:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <7afa888c-7087-53a7-0328-96ca890b04cc@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/1/28 8:20, Ferruh Yigit 写道: > On 1/20/2021 1:43 PM, Lijun Ou wrote: >> From: "Min Hu (Connor)" >> >> Document FEC in NIC features, add information about FEC and add >> implementation related support. >> >> Cc: stable@dpdk.org >> >> Signed-off-by: Min Hu (Connor) >> Signed-off-by: Lijun Ou >> --- >> doc/guides/nics/features.rst | 14 ++++++++++++++ >> doc/guides/nics/features/default.ini | 1 + >> 2 files changed, 15 insertions(+) >> >> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst >> index cf82e9d..ded5c16 100644 >> --- a/doc/guides/nics/features.rst >> +++ b/doc/guides/nics/features.rst >> @@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information. >> * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, >> ``tx_burst_mode_get``. >> * **[related] API**: ``rte_eth_rx_burst_mode_get()``, >> ``rte_eth_tx_burst_mode_get()``. >> +.. _nic_features_fec: >> + >> +FEC >> +--- >> + >> +Supports Forward error correction. Forward error correction (FEC) is >> a bit error correction mode. >> +It adds error correction information to data packets at the transmit >> end, and uses the error correction >> +information to correct the bit errors generated during data packet >> transmission at the receive end. This >> +improves signal quality but also brings a delay to signals. This >> function can be enabled or disabled as required. >> + >> +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, >> ``fec_set``. >> +* **[provides] rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, >> ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``. >> +* **[related] API**: ``rte_eth_fec_get_capability()``, >> ``rte_eth_fec_get()``, ``rte_eth_fec_set()``. >> + > > Feature doc looks good, thanks for adding this. > > Can you add another patch in this series to update .ini files for hns3 & > cxgbe to advertise FEC feature? > ok. I will do it in next version. >> .. _nic_features_other: >> Other dev ops not represented by a Feature >> diff --git a/doc/guides/nics/features/default.ini >> b/doc/guides/nics/features/default.ini >> index ee786d3..562a681 100644 >> --- a/doc/guides/nics/features/default.ini >> +++ b/doc/guides/nics/features/default.ini >> @@ -65,6 +65,7 @@ Module EEPROM dump = >> Registers dump = >> LED = >> Multiprocess aware = >> +FEC = >> BSD nic_uio = >> Linux UIO = >> Linux VFIO = >> > > "Linux UIO" etc renamed in this release, can you rebase on top of latest > repo please? > . >