From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC5B8A0350; Mon, 28 Feb 2022 17:42:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BC1541163; Mon, 28 Feb 2022 17:42:29 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0CCB94068C for ; Mon, 28 Feb 2022 17:42:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646066548; x=1677602548; h=message-id:date:to:references:from:cc:subject: in-reply-to:content-transfer-encoding:mime-version; bh=XWntGNAoKCzmv3GLpWuli7KNDrJakQxvAgq4EInAyxU=; b=NcoWLoHlVu57VIcvgxy2C4t1IYm+R5MeLJ54euKsp8jtNHDolniC1VKX go8uQkFJMtsi1dnAGjJ3Hy3QGwwFrGBJHchSL6CcfiJDIqo7JjPlIIlJW slFX12l4Sw+fLUE1oDIhsMqqo8RU7YszbBNbRJw0CEM1Q/p0A9YEz6ZOD M0uMTJ5EtrVQDPa5o9xzoa1AgILbLW2cNC4Q6EPlfxzAZ9ywuaEz41V0i NnjwyZGdCMqQbC5/DEAWG56nZbGb2TAnrWGq3PVQBmOO4yM4vYgp1/83A dX4xPD8w8Da5F93srWfv7enlFZmTpVq80HLXMe1eNqshkgR459y3Z6VxO Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="250510069" X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="250510069" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 08:42:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="593280153" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga008.fm.intel.com with ESMTP; 28 Feb 2022 08:42:24 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 28 Feb 2022 08:42:23 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Mon, 28 Feb 2022 08:42:23 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 28 Feb 2022 08:42:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IL3fv0NfJ1aEcDDbEseDAk3L1Z/n/hW+zTpQzLuS2rdqSemMHV7V9MMsJxuBy6WU4usO+7pjo3Zoh2oOHdWF5cDwhTaSG9t6FUYEKKiwwScDmBwiqZ6x0nJepxzvDyr2hdRprvX3D19Z9b+/5KwsGJX1ZL1kAgmUtJfiZ4JW+W2q2/xkLYSyEESyv6OoNSlk6pKN050B00/Oedz9tIxreVmBHu2wRVfE3ZDxauICRjU5MwucwLfDheTZ3J77EIoY/rB2bj/VHKrt1ExE7zLo4JuzN904bFW8bweS1uC3+iSLl5k1aHjwGiyUVVFhopPpQqTgP9n+93Sh/NEn0e7Iyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W2SgEa/ENyx1rdAfjJUpBAkB6BN0SEDpaVQMyQpykMo=; b=gviHqPh16b1hGjP1A/dEnzFvZAWmyH/OEroiEXhMUlep8xENXE1HzBkihwn8WbqA5SZe5taQMUp7Trh1IjIwTNkaJTPoNExoUxCqC7KoStSfgzuHbq0MHhBzHJa4oKc+RuKTGNtZQkWyUPHrgQ5u+/hrEgWGMNVKZNUcKg4nvWgkXpQBatr1acj8N4KrOkNA4+80v5g5j61AX3QTXerBH+yR6aaoWhnlmicIgxuzk0cdF8lo2rGFaK2h+0bEAbqwyz5b1FoXKZ/Ne8cGmEbfiV7KLhXG40oPxyTaI0wqtxEpW/rOMXaylLmMIJx3CivCTWfjlDfipmQwa/lfTtZbhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM5PR1101MB2331.namprd11.prod.outlook.com (2603:10b6:3:a2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb 2022 16:42:22 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%5]) with mapi id 15.20.5017.027; Mon, 28 Feb 2022 16:42:22 +0000 Message-ID: Date: Mon, 28 Feb 2022 16:42:15 +0000 Content-Language: en-US To: "Min Hu (Connor)" , , , Andrew Rybchenko , "Qi Zhang" , Ori Kam , Huisong Li References: <20220228032146.37407-1-humin29@huawei.com> <20220228032146.37407-3-humin29@huawei.com> From: Ferruh Yigit CC: Olivier Matz , Ajit Khaparde , "jerinj@marvell.com" , Stephen Hemminger , Viacheslav Ovsiienko Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior X-User: ferruhy In-Reply-To: <20220228032146.37407-3-humin29@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0214.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::34) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c43cf2e2-b0a3-4205-9df7-08d9fad94a87 X-MS-TrafficTypeDiagnostic: DM5PR1101MB2331:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yKojZrwWRHo5y3YaKDNCKgPZUkW4PSKPsEgAn2uLNrOyYMwo/tqH+aB3N5CMePXA1v5k3h1s9AbOgDlD60mV6tAdgfiTqrL8oGmW224XuaHlg9DU10Z9gqiTO0LK3GqjEWxokvOp+zGSoRgSoF/GzWmG1XKzW9DEvyPWd6lXhf7BX7769teqnXSBfB2thnClvfQeMU0atAdhqQ4yvUKj4wRMcKQ1k9qdf8dzy0xvPuGx0+lVYyYvJUzm0RV5EUSScsd+DQ86o3r/zYLRtFdiBMqQF3XNourm2yuPX0CHRh5x1mFy+/kkOfQtkDO7hBL1iThCIwf25WSSmeDnP4AlDAndmhA5tUP+TWQksLKvnz2uHzXiMnX3NGTaHewuGsLF+Ad7jkF6x6hTPVx1ZOn3P6ZfiIwGCXuBVeTjxc33ObGMKrPA2YP86mYE4iv3XQ6c5fYiiTuk4GmUEzw09xIQ59Bb+Ed9tLUDhGt+U/U4olhBZrsOVrMVkY9l2DSRrK3ubU46qmPrGyKuqiSxREK3ZpZ9aoZX5TT1I1yuk30PaMt+tc30WphH4h6bC85X4uLtjmoArPW+yqCFFJwN7ltX4IfEfGZv3C7iQvvDjGxOYsAzg0Nc/yAdUJaUK4QTM2L42MdKYOedop8OhQ9uQyZIBrkyr2BhSmwNjkzx7l0Z3uZCTsWeX+ofPmfNPWZm4fo/uZvElbcdxPx2x/qusJwN4A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(6486002)(36756003)(53546011)(6506007)(54906003)(110136005)(316002)(82960400001)(66476007)(8676002)(4326008)(66556008)(4744005)(8936002)(66946007)(38100700002)(6512007)(186003)(44832011)(31686004)(6666004)(7416002)(31696002)(2906002)(2616005)(86362001)(26005)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHNVOEV6b293dTg1cU1EVmZ4ZkJ6QWhKa29GNnNSL3hCM3Q3M1BseUU1TTJQ?= =?utf-8?B?USsySUJMeXdHd1ROL2dVNWp1YVRySDF1a2dVa3dGdnVGUE9kQjloVHNJR0Vr?= =?utf-8?B?RDJyeTBXVVhDeElnMEtLZUhpbHYza052TVdSV2Uwb0xoczhLNE5xSWN2d2Vz?= =?utf-8?B?WFBXMllzeUZxZ0RIY2tEK3Q4MUp0K2twbW9UWWNPbGdYNjJwSUVGZW1nNFRJ?= =?utf-8?B?UEpUeXlkNUZkWHIwOE1xMGd4QlBPeW9iRjhtRTcvWUE0SGoybUNxVmJnb0tY?= =?utf-8?B?cllmWS9tZ2pIUFRKd0FaQXRzSmJLdVFoemJUOUVqV1d2K0tBUHRLSHFqQ2RG?= =?utf-8?B?Y1VQL21vdUNCWWNSYkt3Q3hlVUJhTkxxQ0RacCtDNnp4QyttTi9WM3pDdUZh?= =?utf-8?B?WlBzOFRDQ0lac3diSFlQbkR0VFBJUFo2L2hIWFdxYlZsa200YWhnQm1SM3FZ?= =?utf-8?B?N3pvOGoxVWtlalpkSjdNOERyTGIwQWw0TlgvWHl5MlNMakVSc0xMSHNHWWFn?= =?utf-8?B?amQvK3U1UU1aSlJkOHlCRGtjZUJUWkVleXZaSlB3SXYrUVdqSmVSd0M0T1Fs?= =?utf-8?B?cXR6OENDcEIwT2RWeGp5Z29LQ2JIS1RLdW5IL3VsYmYxNTVEeGVHQzkzY05T?= =?utf-8?B?Z2szZWl4VUxKOFd1ZkRLRnBrSG0zQTBFTXlIMzhtU29rWXVjVVduMWMxNmlu?= =?utf-8?B?Zys2OGNURmlJR29zT0FycWQrVE9zWDVEUUFNSFhna09YZTk4eFFvUGY0Rm11?= =?utf-8?B?Vk04dlpxaXFyWlVQL2I0STJ3eXFaN3hFKzJPc0dnKzg2MnllMlRxWVJ2ZUll?= =?utf-8?B?ekRGUEs3RnY2cmlIM1NRWS9sNjhBZ09wcEVYYW1PVGh6RlZkQ2Q0bVI1RUJ2?= =?utf-8?B?bitiM0h6VDkvQW9SUVV6TE0zYlRsS3NDVnc2OTRSelhHc3hiS3JCcjhoNGxD?= =?utf-8?B?SW92Sy93MSs2VXVQOVZBb2g5WmtZR1QxbFIray9JNVl2M1RBMUlXUm1tT1Zi?= =?utf-8?B?cklXUWNkUUJZcmVOc2NvVTFld2hJTXFNZ0tEOUNTaWs5TU9FZktpTmFFclRt?= =?utf-8?B?N0pnbUFHVjhTQ1A4MmRnNXkxQ3Zha3drVm9sYVNVNFBoWjlGaXVnMy9BWE8x?= =?utf-8?B?NkUxOXJNTXFwWEdSNTMvdXBVNkVvdnJRRzBaenJ2UGJKdDU0alJUc2cyNFVj?= =?utf-8?B?R1hjZ1NFd2Q4eGpqOGMyc2swYlhFUTBIN3F1aE9ZM0ttY3ZUTEJhajV6ckZ5?= =?utf-8?B?eWJCVHAydDJMUlYzMUx3cWt3UVFmL21QeXZMQjhnelpVVllFMmwvYzMxcmlP?= =?utf-8?B?ZytnNEplLzU5VytKWXlGeHFpZEtRUkZyR1VpNVlLVVdNYTZJUUpDaGZ1N0Vt?= =?utf-8?B?Tnh4eDdBQzdkbGxKa1BtNkZFenA2bXBFZWs0U05uNUdzTmRadWxybGNaZkRS?= =?utf-8?B?T1ByL3QyUHE1Nmp4eDFVcFFIQUlmdk1HZUhQUDZzRmlpOFJkREN4aXZ1ZHBV?= =?utf-8?B?ZThTNlNLMUtnMjFDa3lIZU5ZellTRVFacHlacUdmWmhZZkxlRFYwWnJQZ1Fi?= =?utf-8?B?QUpOY05iR3VmYnRTbkF6am5jT3JwVXBLNVNsTlptWlVpZGlUVXgwaytRQlRC?= =?utf-8?B?eXNFYlV3dGQ5TWhUR2ZDUXlRbWxraGFDY2lGMnd2aDVVM0ZxUHlNZmg1OFVX?= =?utf-8?B?TVlSWFJnVTQyYktvZTFLYnlpdmtIWGh3YXRUNGRIaEdTSEppUDgxVXBoRllz?= =?utf-8?B?YnlOUTJ4cWJnY2NvV0hhbTlkL2dsVUE5NlJlQzRkcG1PbGl6YTJBVVFGa1Nt?= =?utf-8?B?anNKWnh0TkJDeWt0TkNUWHRybWJ0bS8vZEtLWkJ4eEc4UHN4UHlIcnpUWnBx?= =?utf-8?B?VHBsMXNMUXhQUnE5NWNFdkFma3g3YndLSlpkeUNRUTBkdVc3bElhLzdiSFp4?= =?utf-8?B?bWlVaGJCS1FNYktac25NbENYUXNnK0RqYlZaZk9NWmNqOXF1ZUx3Ry9qbjAr?= =?utf-8?B?UTljclFUd1liMmlxM1VBRngwRGhPWU1GM2hRUThjcGM1YzhqY293SUdGbzBo?= =?utf-8?B?WnhwR296UHRnc0xPWDd0cC80aTg1S3h5WldmcG50eWV4L3B0ZUUxNTdJb3ZI?= =?utf-8?B?MUlDdjhoZlRRWCtuZjVzNDdubWJDQVR0U004ZDJueTN6RTUvd1RwYnFiWDFO?= =?utf-8?Q?EhDWpADS2os4E6pr46HLGmc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c43cf2e2-b0a3-4205-9df7-08d9fad94a87 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 16:42:21.9102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ife8TXtfjedzueYT+4GM2M7q5y5f9SvUPIGx5kYLeBi20CLdyP/Upho7URMLKl+vg+7bXHohXwyqeGz/HTK5iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2331 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: > From: Huisong Li > > RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be set in > dev_configure phase. However, if this flag isn't set, RSS can be enabled > through the ethdev ops and rte_flow API. This behavior is contrary to each > other. > > Fixes: c37ca66f2b27 ("net/hns3: support RSS") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li Hi Huisong, Connor, Let's get a little more feedback for this patch, cc'ed more people. To enable RSS, multi queue mode should be set to 'RTE_ETH_MQ_RX_RSS_FLAG'. But I wonder if it is required to configure RSS via flow API, and if other PMDs check this configuration for flow API?