From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 89C14A0C40;
	Sat, 31 Jul 2021 14:15:54 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 12CDD4014D;
	Sat, 31 Jul 2021 14:15:54 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id B060E40042
 for <dev@dpdk.org>; Sat, 31 Jul 2021 14:15:52 +0200 (CEST)
Received: from [192.168.100.116] (unknown [37.139.99.76])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B01697F510;
 Sat, 31 Jul 2021 15:15:51 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B01697F510
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1627733752;
 bh=oGowMADgVmvr6kpnuARHzEHEUSjzuryz4YqxHgWzDCw=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=ELdcEpHdsdvg0KNdG2CGR7ZcOrwofTUi5iUpb2fa8hx08zRwDYDBE2wBphZPjB3LR
 zZUFxXpKJflQc3QlDKn5dmveAKMYN21CdTHLsVb9zPAOtUCTjDZPfrPbnTTUrDyNwQ
 aReZw0yHxyPEFvnJ0K/qK9S7aHcUd4RY/vJHrbOY=
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Cc: Ray Kinsella <mdr@ashroe.eu>
References: <20210730155700.32574-1-olivier.matz@6wind.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <ccfb6214-40ce-1699-f625-060e6b476ef1@oktetlabs.ru>
Date: Sat, 31 Jul 2021 15:15:50 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210730155700.32574-1-olivier.matz@6wind.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] doc: announce renaming of mbuf offload flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/30/21 6:57 PM, Olivier Matz wrote:
> The mbuf offload flags do not match the DPDK namespace (they are
> not prefixed by RTE_). Announce their rename in 21.11, and the
> removal of the old names in 22.11.
> 
> A draft coccinelle script is provided to anticipate what the
> renaming will be.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

[snip]

> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 9584d6bfd7..04cb141de7 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -147,3 +147,8 @@ Deprecation Notices
>   * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific
>     content. On Linux and FreeBSD, supported prior to DPDK 20.11,
>     original structure will be kept until DPDK 21.11.
> +
> +* mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``.
> +  A compatibility layer will be kept until DPDK 22.11, except for the flags
> +  that are already deprecated (ex: ``PKT_RX_L4_CKSUM_BAD``), which will
> +  be removed.
> 

I think it is better to be explicit with defines to be removed:
PKT_RX_L4_CKSUM_BAD, PKT_RX_IP_CKSUM_BAD, PKT_TX_QINQ_PKT,
PKT_RX_EIP_CKSUM_BAD.