From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B17ED1BC31 for <dev@dpdk.org>; Wed, 11 Apr 2018 14:57:51 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 4E5BDB80057; Wed, 11 Apr 2018 12:57:50 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 11 Apr 2018 13:57:45 +0100 To: Adrien Mazarguil <adrien.mazarguil@6wind.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org> References: <20180406131736.19145-1-adrien.mazarguil@6wind.com> <20180410162022.9101-1-adrien.mazarguil@6wind.com> <20180410162022.9101-15-adrien.mazarguil@6wind.com> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <ccfcfb78-0af4-ca05-a5d6-09ed9bff78b0@solarflare.com> Date: Wed, 11 Apr 2018 15:57:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180410162022.9101-15-adrien.mazarguil@6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23776.003 X-TM-AS-Result: No--7.887000-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1523451471-5lKPkCsQBBSR Subject: Re: [dpdk-dev] [PATCH v3 14/16] ethdev: rename physical port item in flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 11 Apr 2018 12:57:51 -0000 On 04/10/2018 07:37 PM, Adrien Mazarguil wrote: > While RTE_FLOW_ITEM_TYPE_PORT refers to physical ports of the underlying > device using specific identifiers, these are often confused with DPDK port > IDs exposed to applications in the global name space. > > Since this pattern item is seldom used, rename it RTE_FLOW_ITEM_PHY_PORT > for better clarity. > > No ABI impact. > > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> > --- > app/test-pmd/cmdline_flow.c | 27 +++++++++++---------- > app/test-pmd/config.c | 2 +- > doc/guides/prog_guide/rte_flow.rst | 22 ++++++++--------- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- > lib/librte_ether/rte_flow.c | 2 +- > lib/librte_ether/rte_flow.h | 31 ++++++++++-------------- > 6 files changed, 41 insertions(+), 45 deletions(-) Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>