From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 908DDA0547; Thu, 28 Oct 2021 20:44:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5076840DDB; Thu, 28 Oct 2021 20:44:26 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 3FA734067B for ; Thu, 28 Oct 2021 20:44:24 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10151"; a="254064037" X-IronPort-AV: E=Sophos;i="5.87,190,1631602800"; d="scan'208";a="254064037" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 11:44:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,190,1631602800"; d="scan'208";a="724316920" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP; 28 Oct 2021 11:44:21 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 11:44:19 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 11:44:18 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 28 Oct 2021 11:44:18 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 28 Oct 2021 11:44:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XmDqgUTZWyKAc4gkelY9C/MGpbZm9y2Qi+NBXGCy3AUA7UMVNOEPgV9sitrtXHcrlP65WuyJB68cGJ4gK+s9DbHEpB9+EGzqRdVmcU40GswpYur9UFkCU5SzrHq7ZAC3L1MAFI4Co6Ks+qQuDy8VQBrUFc6dKC9jYlPdmHKs8ahnYczchweyz2S+56BFda4GSCEMAPSVAxxvDr37nxWXHhtqztVp1xQZwzVmD+Km20lwDsr9Bk1R7PQOTyx/rLX3h80AqGhpdtqoPKgguc+PCvToOjsxqo9MtKSulYTzNTvKO4yXUIzkb3kerS+yI5QnA1hIzZTQBxMWzoGVLmcDVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dXtute9n3K7DJ4rI/7NNETOH30gXvZ92CA8C2Fvoy10=; b=hH9xOxmwplQ/GdoCNR18lw9SOGsIVQKFIRjLK9LUp7FI4yjG9/qZlU0S8T12AHZEAsQPdM8aK/yUARJa3YfONcNt8TRlJUssRXyyybeWS2ubUpnWHTPS/aHCGIHh4snD1d70ynsRjHdLQc5Bpo/r/tGiZC3XdCjQBphF3d2looFMTPPh6IdN/OhWmPpW/mIhCk3+SfdEum0CbPYYHBz5YaZtwIqa5tTmB0QjWYg7wq6AklC2zjP6txrTgH6TWeuiFrFx+TCgGlvrydG5Bds0xYJKd1TCkRcSJir0kW92yxT0Eu2TGnTIgCDcMMjFDLWVSrDjQBTFpnhpnrHDr30LYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dXtute9n3K7DJ4rI/7NNETOH30gXvZ92CA8C2Fvoy10=; b=J9UsChB+WigbtkT2idyxY6ZvyEwT5Gn4kutOwvSPpiQheWpNDw63xkanp1LWKQQyrpM6U/8xXjfa9LJYBJn92dIgd5nvek7ey9oN4/SgJzljcKugmz9ejVzYNWk8pgA69+7wR+VlYLzCmtuPjQAJquerzf/d8RGUuJLjORR/t6Y= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4871.namprd11.prod.outlook.com (2603:10b6:510:30::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13; Thu, 28 Oct 2021 18:44:18 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021 18:44:18 +0000 Message-ID: Date: Thu, 28 Oct 2021 19:44:10 +0100 Content-Language: en-US To: David Marchand , CC: Olivier Matz , Ori Kam , "Jie Wang" , Wenjun Wu , "Andrew Rybchenko" References: <20211025123107.1600-1-david.marchand@redhat.com> <20211028101428.15007-1-david.marchand@redhat.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211028101428.15007-1-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR03CA0094.eurprd03.prod.outlook.com (2603:10a6:10:72::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB7PR03CA0094.eurprd03.prod.outlook.com (2603:10a6:10:72::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.22 via Frontend Transport; Thu, 28 Oct 2021 18:44:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 985350e0-c52a-450d-b651-08d99a42f234 X-MS-TrafficTypeDiagnostic: PH0PR11MB4871: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1284; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bGMoyPUUIGUNjOwS5Am2hjDCuBpIITr3XSSEoytcFTz4JbsQ1mD2xbkBE/XZkUvrXsKAtI7pinMc8RSydxmJ8PFPp4XVrCevS5DeGg/DB8LQDbVQiuBiFUC7PQdtr4rqT1oMJtIeSkkcNqNyOWrz1KssSiof3A25aS6+8B6PTV+kIVNL/FSfk25EqAxKaMjTK269p18Exc078ifnNhKt8grjmAo9rkL0uaHnjJpjX8LD4dXozkIYqO4WKBvdXjTlMFAmSnjKEonaGo36o6+li+JEd/U3MeaN98pFL4LBHeNAvj7pw4bdPjrMI1N25rJxgom4a86Vsh9tXOEVbqL3JOsiIMop5ALtLFgwCrfwJEbWzk0SjI9h9zr7tVMOiInPv/sARV7KhOeCj9HHMnb2LSU9bNAZRd6B8ypuIhIWqLyLLYmXkEK07zr5vtpFUTquLFRR3RM9ozqzEFTbxswth5R/XawB9xK0oLnyM5TT+648HZL9RI0jgv3DrRR/NwV9UkzVHEf1vjhUURDPnQju24WkHE+qHENculpBueLYnyhdtxHXgR4tyLDQ+ozRTdCriP2DcnXDX60rTBhwsdcG4ZF4QCXgl/l3CwcjRH5vgXIpkxD/+jk4CQNJieL/n97uXpMBEbHCaWQeLunQ5Oz2ctmng3uiHIFlF2oY4lpsvmKdfQnwqWo05CWwEkwPw8NnKN7DBU/Iq6/LK/5O5no/1w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(16576012)(66946007)(8676002)(66476007)(66556008)(82960400001)(31686004)(54906003)(6486002)(508600001)(8936002)(4326008)(5660300002)(186003)(316002)(38100700002)(26005)(36756003)(2906002)(6666004)(31696002)(86362001)(44832011)(53546011)(2616005)(956004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUFJZkZaeVhReEFzMGhnK01DVFBsc3AvT0Z4WHF4emdnVWpMWElvcGFvTzBB?= =?utf-8?B?WFh4WDI4OTN1Wk1BdWszM0JUN0t4V3ZUYVZMeFplYk4rM29iQkpoSkJqVGJ6?= =?utf-8?B?emtiU1pWNHQyMFpYL2NZeGJiUTdsVmNyeHZMY1A4ZVpxdFdKeE14S2xVVFpL?= =?utf-8?B?bFRjb1hiNzFHcUJ6OS85V1lHaUFJZWxtb3ZFU0lXeU9rL0JKK3NYSno2VFFR?= =?utf-8?B?RklMcVpHM3pwRHpLSERSaXJ2cHBRZTV2NENETlhML3FlUVdQdHhOWUo4QTRl?= =?utf-8?B?TUdaRDE1QUtUZU1sZ1JISlBkNlhzSENxS0FBUHdBWElxbmlMVm0ydE9TWHli?= =?utf-8?B?MlpYUWcvQVRhcTVGQnNsc2dBMTRzbVprNjRBTW5tVnUzK1NiV0RCRG5XZVk4?= =?utf-8?B?SXlQaXJaRjdTY0VsL2ZkRWpRd1lrU3lyR3VjM0h0QXg5eGZzK3A5R3J4L2Mz?= =?utf-8?B?bWtVSEtWOG4zZDI4eVR3cDFMdjZvOCtZTDV6N3I1WUM5WFVJVXdaZ1phL0Nj?= =?utf-8?B?dHhZdnRDR3ZqdXY1LzZjajBIUEtCcXNMQVY3TXhMZmZFcHhsTHBweTdnY2RR?= =?utf-8?B?TkRpQmk2VXVMMXVEVlM3YkhYU0tTZVBrZXo2T0l5Rkd6SzUwLzR4TzUwS0hL?= =?utf-8?B?OXpKYWM4dmVhYXJVN1IvbjQvYU5vdUU5a0FOYjAvT0JaTTBZMmpZd1lkTElN?= =?utf-8?B?TVFJVkh5V0p1T0Z3bjBPMmRwUk15c1BBb09hRVFiNjlSYUs4SCtUTHBzR3hZ?= =?utf-8?B?enpYVFplZE11ZGZjTjVDdWNtcm9ualYxZDdid1pvZ05RSURIZkp6dDNkYTJS?= =?utf-8?B?Rkxqb0pIYWRSMUwwcEtiL1k2eTFiYldYYTA3dlZNbk5xS3BCMGZIMlBhands?= =?utf-8?B?b1czbHg1WGFJaVBqbGJGY3p4S3hrN3RTTW93bnl0RURRb0w0bmIzUFJOYlVJ?= =?utf-8?B?S1dHNDF1RXZIK2pvQTlpSXh2WUJjeFhqUG5HODdDNGM1bzdLMTQ4a29LdXdF?= =?utf-8?B?MzVVVW1EcnZ1dXlyRjNFd3VKRldpQ2ZnVXlCK1UzSXQ0eFZYN2lnWk5xV05W?= =?utf-8?B?a09qRGVseWhHVjA3M3RwRW93U29OODVoMnV0WHlESjA2Y25LWlAzRU9vWkpT?= =?utf-8?B?bTBBNXQ0TGx2TU9MYm82TXNYOWJIR3VZVnBFY1N0K0VVRFl2a3kvcmZWbjYx?= =?utf-8?B?dE4wLzBJVkZmcjYrV01XWFQ0OWtBWVdOUGFLUXE0TEVlaEJuY1FwNzVaZXkv?= =?utf-8?B?MHNDL3VVaXM1bDVHUDNoNHpZV3RocVZPbDlhRUFYSkNrS3NLWUJSRDVUZFFt?= =?utf-8?B?WGRvU2JZV0hqVHVwTS9QcWVicC9FVnYyVityeC9Gc1dZZnE1d0ZEd29ocnhz?= =?utf-8?B?S3YweG1BeHoya2RQZ295QWpjaVloM0JhOUE0R2c2MU9PMXpxeGE1MW5oL1ky?= =?utf-8?B?emNLayt2U1NhRVJSTFhKQ2ovaG03RXN3UkdEbWYrZDNjM2FvVGdORTczZlBr?= =?utf-8?B?MUNqSkpUL3lkRkhhNUZaWlM2eWVQckR1MkNmR1RsaFhlRmtuYlRGaStlZS93?= =?utf-8?B?d0J5a0JqWlNMOWVqVjZDaGxCMmgvdlZ6R2lKZ2ZsZEZpbU5uOGt5T3pUWmdI?= =?utf-8?B?NzRkZDFacXQ4QVJRakdibUJRUFZDL2NlRldEMjlYbTE3Zy8xNk1vVHNFeW1X?= =?utf-8?B?ZlN5MmkxTGNMZk52eFJEZkFROUgzdFNGcXVYNjk0bWJCZlZVVThManRJZzE5?= =?utf-8?B?Mk9aTUZ6bGdsWTUyV0JrbGdFMkhZUmZVV1dMbmxtUTZ0cTQzVllYcGZUdlRo?= =?utf-8?B?aTdvdEk0d0hoN3JDeDRuYmJRVmVqWkEydGlJTjdqVGFzWFlta1BoOXgyRXRy?= =?utf-8?B?eXRwemVGclBRU2tENTRWa3RBMHFQeFQzbzBCSWswaU5tZDZ6L01XL3hKYkE2?= =?utf-8?B?Qm9VK0dtRDhGZTBEZ3RsUGtDU1g5emgrZVFOSFFqZjR0Z05TQllSaTJuaklU?= =?utf-8?B?S29iOHduL3VvTUQ3VmVvS3czZERJQnVvZkdqYnZ3RlZvTUhTdHRUcHVDUUsx?= =?utf-8?B?SERSWjZDMlZDcmlkcGcrMVhVVS9ZNUhFV2JUZ0JMbnlHemd3bURuUUluOWx6?= =?utf-8?B?NGJiVW9XTlVSOHVZMWRPNzJ6T3QreGZESzI5eS9tV29xcUpzcWRNcWdjaUli?= =?utf-8?Q?/SAjwMKExm8mZZBWwfMFDFQ=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 985350e0-c52a-450d-b651-08d99a42f234 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 18:44:17.9421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8hx2ss8EQX9uNHKt70GpveYRJ0hrOv62JMod8NHad2u2PUOoCPtcU1BNx/eD6BZVIsLRt6FxxC3NfbWasEXiUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4871 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net: fix build with sparse on L2TPv2 bitfields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/28/2021 11:14 AM, David Marchand wrote: > An external project that wants to do additional checks on fields > endianness can remap rte_beXX types to instrumented types and use > sparse. > > The current code breaks OVS build with sparse: > ../../lib/ofp-packet.c: note: in included file (through > .../ovs/dpdk-dir/build/include/rte_flow.h, ../../lib/netdev-dpdk.h, > ../../lib/dp-packet.h): > .../ovs/dpdk-dir/build/include/rte_l2tpv2.h:92:37: > error: invalid bitfield specifier for type restricted ovs_be16. > .../ovs/dpdk-dir/build/include/rte_l2tpv2.h:93:37: > error: invalid bitfield specifier for type restricted ovs_be16. > .../ovs/dpdk-dir/build/include/rte_l2tpv2.h:94:40: > error: invalid bitfield specifier for type restricted ovs_be16. > .../ovs/dpdk-dir/build/include/rte_l2tpv2.h:95:37: > error: invalid bitfield specifier for type restricted ovs_be16. > .../ovs/dpdk-dir/build/include/rte_l2tpv2.h:96:40: > error: invalid bitfield specifier for type restricted ovs_be16. > .../ovs/dpdk-dir/build/include/rte_l2tpv2.h:97:37: > error: invalid bitfield specifier for type restricted ovs_be16. > .../ovs/dpdk-dir/build/include/rte_l2tpv2.h:98:37: > error: invalid bitfield specifier for type restricted ovs_be16. > .../ovs/dpdk-dir/build/include/rte_l2tpv2.h:99:40: > error: invalid bitfield specifier for type restricted ovs_be16. > .../ovs/dpdk-dir/build/include/rte_l2tpv2.h:100:39: > error: invalid bitfield specifier for type restricted ovs_be16. > make[3]: *** [lib/ofp-packet.lo] Error 1 > > Use simple uint16_t types for bitfields in L2TPv2 struct. > > Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.