From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45267A04B7; Fri, 18 Sep 2020 05:40:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 906AA1D70E; Fri, 18 Sep 2020 05:40:22 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6B5C61C128 for ; Fri, 18 Sep 2020 05:40:21 +0200 (CEST) IronPort-SDR: dM67Q1Mf1hEuiDNotSZMzv4YCH0fM1aPZIEFuTl3mS/rHU22tVolz4o1KCsq2QezXRuKoZLolI QZRNTDIrYzyg== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="139858180" X-IronPort-AV: E=Sophos;i="5.77,273,1596524400"; d="scan'208";a="139858180" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 20:40:19 -0700 IronPort-SDR: pECDQsv8JqHjotHFT9ZNMooZ+nQ8pPtDl0hDfzbFU91KOK711RBxHaBJcnMs8rA5rELeRuVuZ9 jOJEBo/0QGDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,273,1596524400"; d="scan'208";a="287823726" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 17 Sep 2020 20:40:18 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Sep 2020 20:40:18 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 18 Sep 2020 11:40:16 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Fri, 18 Sep 2020 11:40:16 +0800 From: "Guo, Jia" To: David Marchand , "dev@dpdk.org" CC: "arybchenko@solarflare.com" , Ray Kinsella , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" , Jianfeng Tan Thread-Topic: [PATCH v3 5/6] eal: hide internal device event structure Thread-Index: AQHWjOXLTdF4Sp+RjEmF7OoLoWzTfqltvjjQ Date: Fri, 18 Sep 2020 03:40:16 +0000 Message-ID: References: <20200914081727.12215-1-david.marchand@redhat.com> <20200917112823.10534-1-david.marchand@redhat.com> <20200917112823.10534-6-david.marchand@redhat.com> In-Reply-To: <20200917112823.10534-6-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 5/6] eal: hide internal device event structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, David > -----Original Message----- > From: David Marchand > Sent: Thursday, September 17, 2020 7:28 PM > To: dev@dpdk.org > Cc: arybchenko@solarflare.com; Ray Kinsella ; Neil > Horman ; Mcnamara, John > ; Kovacevic, Marko > ; Jianfeng Tan ; Guo, > Jia > Subject: [PATCH v3 5/6] eal: hide internal device event structure >=20 > This structure is not used in the public API. >=20 > Fixes: a753e53d517b ("eal: add device event monitor framework") >=20 > Signed-off-by: David Marchand Agree with the patch that the struct involve os platform specific, it is be= tter no public it. Acked-by: Jeff Guo > --- > doc/guides/rel_notes/deprecation.rst | 3 --- > doc/guides/rel_notes/release_20_11.rst | 3 +++ > lib/librte_eal/include/rte_dev.h | 6 ------ > lib/librte_eal/linux/eal_dev.c | 6 ++++++ > 4 files changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 8fca461045..3669d6533b 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -70,9 +70,6 @@ Deprecation Notices > * eal: The function ``rte_eal_remote_launch`` will return new error code= s > after read or write error on the pipe, instead of calling ``rte_panic`= `. >=20 > -* eal: The ``rte_dev_event`` structure will be made private to the EAL a= s no > - public API makes use of it. > - > * rte_atomicNN_xxx: These APIs do not take memory order parameter. This > does > not allow for writing optimized code for all the CPU architectures sup= ported > in DPDK. DPDK will adopt C11 atomic operations semantics and provide > wrappers diff --git a/doc/guides/rel_notes/release_20_11.rst > b/doc/guides/rel_notes/release_20_11.rst > index 185eeae731..e87509dfa7 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -87,6 +87,9 @@ API Changes > * eal: The ``rte_logs`` struct and global symbol was made private > and is no longer part of the API. >=20 > +* eal: Made the ``rte_dev_event`` structure private to the EAL as no > +public API > + used it. > + > * pci: Removed the ``rte_kernel_driver`` enum defined in rte_dev.h and > replaced with a private enum in the PCI subsystem. >=20 > diff --git a/lib/librte_eal/include/rte_dev.h > b/lib/librte_eal/include/rte_dev.h > index 53c8bc6fab..81905b3ae3 100644 > --- a/lib/librte_eal/include/rte_dev.h > +++ b/lib/librte_eal/include/rte_dev.h > @@ -33,12 +33,6 @@ enum rte_dev_event_type { > RTE_DEV_EVENT_MAX /**< max value of this enum */ > }; >=20 > -struct rte_dev_event { > - enum rte_dev_event_type type; /**< device event type */ > - int subsystem; /**< subsystem id */ > - char *devname; /**< device name */ > -}; > - > typedef void (*rte_dev_event_cb_fn)(const char *device_name, > enum rte_dev_event_type event, > void *cb_arg); > diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_de= v.c > index 83b6068264..2e15762b56 100644 > --- a/lib/librte_eal/linux/eal_dev.c > +++ b/lib/librte_eal/linux/eal_dev.c > @@ -133,6 +133,12 @@ dev_uev_socket_fd_create(void) > return ret; > } >=20 > +struct rte_dev_event { > + enum rte_dev_event_type type; /**< device event type */ > + int subsystem; /**< subsystem id */ > + char *devname; /**< device name */ > +}; > + > static int > dev_uev_parse(const char *buf, struct rte_dev_event *event, int length) = { > -- > 2.23.0