DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Kevin Traynor <ktraynor@redhat.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Fix various typos found by Lintian
Date: Sun, 26 Apr 2020 10:49:13 +0100	[thread overview]
Message-ID: <cd40360936543b850f39b4fcf4bd4545049ca295.camel@debian.org> (raw)
In-Reply-To: <4740923.upeRZZJTqa@thomas>

On Sat, 2020-04-25 at 19:47 +0200, Thomas Monjalon wrote:
> 04/03/2020 16:28, Luca Boccassi:
> > On Wed, 2020-03-04 at 14:34 +0000, Kevin Traynor wrote:
> > > On 29/02/2020 16:37, luca.boccassi@gmail.com  wrote:
> > > > Debian's linter is getting more and more annoy^^smart and now
> > > > parses binaries
> > > > for typos too - CC stable to get it off my back in the next
> > > > release
> > > 
> > > Minor: Probably linter is better trained in the Queen's English
> > > than
> > > me
> > > or it could be personal preference, but 'one' seems to be
> > > referring
> > > to
> > > the user and it reads a bit strange for me. e.g.
> > > 
> > > "Slave %d capabilities doesn't allow one to allocate additional
> > > queues"
> > > "hardware specifications that allow one to handle virtual memory"
> > > "Do not allow one to send packet if the maximum DMA.."
> > > 
> > > as opposed to
> > > 
> > > "Slave %d capabilities don't allow allocation of additional
> > > queues"
> > > "hardware specifications that allow handling of virtual memory"
> > > "Do not allow sending of a packet if the maximum DMA.."
> > 
> > You might be right - but the intent here is not to be correct, it's
> > to
> > get the linter to leave me alone :-)
> 
> I agree with Kevin that the wording "allow one to make" is strange.
> Would lintian leave you alone with "allow making"?
> 
> Anyway the "allow to" sentences are not typos.
> They could be reworded in a separate patch.
> 
> Patch partly applied, except the "allow one to" changes, thanks.

It probably would work - will check in the next cycle.

-- 
Kind regards,
Luca Boccassi

  reply	other threads:[~2020-04-26  9:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-29 16:37 luca.boccassi
2020-03-04 14:34 ` Kevin Traynor
2020-03-04 15:28   ` Luca Boccassi
2020-04-25 17:47     ` Thomas Monjalon
2020-04-26  9:49       ` Luca Boccassi [this message]
2020-06-16 12:44         ` Thomas Monjalon
2020-06-16 14:25           ` Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd40360936543b850f39b4fcf4bd4545049ca295.camel@debian.org \
    --to=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).