From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CF86454A7; Mon, 24 Jun 2024 09:49:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 143314026E; Mon, 24 Jun 2024 09:49:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4897D4014F for ; Mon, 24 Jun 2024 09:48:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719215290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=luEGWX7O0GMd0eOIokaQcEm1H+nzCc1/l9Xjlj95bWM=; b=CfvEkN6Ctvn4+w0ztVdEgcN/7NNPY8lNfwqkRZ3lLLOEhuB4rBOIJZd6CMfbPhjb8OdHDW 3hxsjFyQjDDK/eYO36E0m+0eaYCgtC0bvtFH22fzGt6d4kikW7cF76aereDBdhbWIMr9fX kMUx4LGqOSr3BjXb95x/bxIImZmzlyY= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-ccRqbg5APAuTiXCdRfJLdA-1; Mon, 24 Jun 2024 03:48:06 -0400 X-MC-Unique: ccRqbg5APAuTiXCdRfJLdA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 17F4419560AB; Mon, 24 Jun 2024 07:48:05 +0000 (UTC) Received: from [10.39.208.31] (unknown [10.39.208.31]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 254F41955E72; Mon, 24 Jun 2024 07:48:02 +0000 (UTC) Message-ID: Date: Mon, 24 Jun 2024 09:48:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 7/9] test/bbdev: check assumptions on fft window To: "Chautru, Nicolas" , "Vargas, Hernan" , "dev@dpdk.org" , "gakhil@marvell.com" , "trix@redhat.com" Cc: "Zhang, Qi Z" References: <20240422190800.123027-1-hernan.vargas@intel.com> <20240422190800.123027-8-hernan.vargas@intel.com> <3dad37e0-9953-414f-8ea0-d7834a433cf2@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Nicolas, On 6/20/24 20:11, Chautru, Nicolas wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Wednesday, June 12, 2024 4:11 AM >> To: Vargas, Hernan ; dev@dpdk.org; >> gakhil@marvell.com; trix@redhat.com >> Cc: Chautru, Nicolas ; Zhang, Qi Z >> >> Subject: Re: [PATCH v1 7/9] test/bbdev: check assumptions on fft window >> >> >> >> On 4/22/24 21:07, Hernan Vargas wrote: >>> Add check for FFT window width. >>> >>> Signed-off-by: Hernan Vargas >>> --- >>> app/test-bbdev/test_bbdev_perf.c | 26 ++++++++++++++++++++++---- >>> app/test-bbdev/test_bbdev_vector.c | 14 ++++++++++++++ >>> app/test-bbdev/test_bbdev_vector.h | 2 ++ >>> 3 files changed, 38 insertions(+), 4 deletions(-) >>> >>> diff --git a/app/test-bbdev/test_bbdev_perf.c >>> b/app/test-bbdev/test_bbdev_perf.c >>> index 28d78e73a9c1..57b21730cab2 100644 >>> --- a/app/test-bbdev/test_bbdev_perf.c >>> +++ b/app/test-bbdev/test_bbdev_perf.c >>> @@ -106,6 +106,8 @@ static int ldpc_llr_decimals; >>> static int ldpc_llr_size; >>> /* Keep track of the LDPC decoder device capability flag */ >>> static uint32_t ldpc_cap_flags; >>> +/* FFT window width predefined on device and on vector. */ static int >>> +fft_window_width_dev; >>> >>> /* Represents tested active devices */ >>> static struct active_device { >>> @@ -881,6 +883,13 @@ add_bbdev_dev(uint8_t dev_id, struct >> rte_bbdev_info *info, >>> rte_bbdev_info_get(dev_id, info); >>> if (info->drv.device_status == RTE_BBDEV_DEV_FATAL_ERR) >>> printf("Device Status %s\n", >>> rte_bbdev_device_status_str(info->drv.device_status)); >>> + if (info->drv.fft_window_width != NULL) >>> + fft_window_width_dev = info->drv.fft_window_width[0]; >>> + else >>> + fft_window_width_dev = 0; >>> + if (fft_window_width_dev != 0) >>> + printf(" FFT Window0 width %d\n", fft_window_width_dev); >> >> Why not print the value systematically? > > It would only be zero if the application was not able to get that information, hence that would be irrelevant. Ok, please send a V2 addressing my request on patch 2 so that I can apply the series this week. Thanks, Maxime >> >>> + >>> nb_queues = RTE_MIN(rte_lcore_count(), info- >>> drv.max_num_queues); >>> nb_queues = RTE_MIN(nb_queues, (unsigned int) MAX_QUEUES); >>> >>> @@ -2583,7 +2592,8 @@ validate_ldpc_enc_op(struct rte_bbdev_enc_op >> **ops, const uint16_t n, >>> } >>> >>> static inline int >>> -validate_op_fft_chain(struct rte_bbdev_op_data *op, struct >>> op_data_entries *orig_op) >>> +validate_op_fft_chain(struct rte_bbdev_op_data *op, struct >> op_data_entries *orig_op, >>> + bool skip_validate_output) >>> { >>> struct rte_mbuf *m = op->data; >>> uint8_t i, nb_dst_segments = orig_op->nb_segments; @@ -2613,7 >>> +2623,7 @@ validate_op_fft_chain(struct rte_bbdev_op_data *op, struct >> op_data_entries *orig >>> abs_delt = delt > 0 ? delt : -delt; >>> error_num += (abs_delt > thres_hold ? 1 : 0); >>> } >>> - if (error_num > 0) { >>> + if ((error_num > 0) && !skip_validate_output) { >>> rte_memdump(stdout, "Buffer A", ref_out, data_len); >>> rte_memdump(stdout, "Buffer B", op_out, data_len); >>> TEST_ASSERT(error_num == 0, >>> @@ -2686,16 +2696,24 @@ validate_fft_op(struct rte_bbdev_fft_op **ops, >> const uint16_t n, >>> int ret; >>> struct op_data_entries *fft_data_orig = >> &test_vector.entries[DATA_HARD_OUTPUT]; >>> struct op_data_entries *fft_pwr_orig = >>> &test_vector.entries[DATA_SOFT_OUTPUT]; >>> + bool skip_validate_output = false; >>> + >>> + if ((test_vector.fft_window_width_vec > 0) && >>> + (test_vector.fft_window_width_vec != >> fft_window_width_dev)) { >>> + printf("The vector FFT width doesn't match with device - skip >> %d %d\n", >>> + test_vector.fft_window_width_vec, >> fft_window_width_dev); >>> + skip_validate_output = true; >>> + } >>> >>> for (i = 0; i < n; ++i) { >>> ret = check_fft_status_and_ordering(ops[i], i, ref_op->status); >>> TEST_ASSERT_SUCCESS(ret, "Checking status and ordering for >> FFT failed"); >>> TEST_ASSERT_SUCCESS(validate_op_fft_chain( >>> - &ops[i]->fft.base_output, fft_data_orig), >>> + &ops[i]->fft.base_output, fft_data_orig, >> skip_validate_output), >>> "FFT Output buffers (op=%u) are not >> matched", i); >>> if (check_bit(ops[i]->fft.op_flags, >> RTE_BBDEV_FFT_POWER_MEAS)) >>> TEST_ASSERT_SUCCESS(validate_op_fft_chain( >>> - &ops[i]->fft.power_meas_output, >> fft_pwr_orig), >>> + &ops[i]->fft.power_meas_output, >> fft_pwr_orig, >>> +skip_validate_output), >>> "FFT Power Output buffers (op=%u) are not >> matched", i); >>> } >>> >>> diff --git a/app/test-bbdev/test_bbdev_vector.c >>> b/app/test-bbdev/test_bbdev_vector.c >>> index b3e9d4bb7504..e48947b211ac 100644 >>> --- a/app/test-bbdev/test_bbdev_vector.c >>> +++ b/app/test-bbdev/test_bbdev_vector.c >>> @@ -1050,6 +1050,20 @@ parse_fft_params(const char *key_token, char >> *token, >>> } >>> } >>> ret = ((err == NULL) || (*err != '\0')) ? -1 : 0; >>> + } else if (!strcmp(key_token, "fft_window_width")) { >>> + tok = strtok(token, VALUE_DELIMITER); >>> + if (tok == NULL) >>> + return -1; >>> + for (i = 0; i < FFT_WIN_SIZE; i++) { >>> + if (i == 0) >>> + vector->fft_window_width_vec = (uint32_t) >> strtoul(tok, &err, 0); >>> + if (i < (FFT_WIN_SIZE - 1)) { >>> + tok = strtok(NULL, VALUE_DELIMITER); >>> + if (tok == NULL) >>> + return -1; >>> + } >>> + } >>> + ret = ((err == NULL) || (*err != '\0')) ? -1 : 0; >>> } else if (!strcmp(key_token, "op_flags")) { >>> vector->mask |= TEST_BBDEV_VF_OP_FLAGS; >>> ret = parse_turbo_flags(token, &op_flags, vector->op_type); >> diff >>> --git a/app/test-bbdev/test_bbdev_vector.h >>> b/app/test-bbdev/test_bbdev_vector.h >>> index 14b8ef2764ad..ba1d0d20f9ea 100644 >>> --- a/app/test-bbdev/test_bbdev_vector.h >>> +++ b/app/test-bbdev/test_bbdev_vector.h >>> @@ -69,6 +69,8 @@ struct test_bbdev_vector { >>> }; >>> /* Additional storage for op data entries */ >>> struct op_data_entries entries[DATA_NUM_TYPES]; >>> + /* Vector FFT window width assumption. */ >>> + uint16_t fft_window_width_vec; >>> }; >>> >>> /* fills test vector parameters based on test file */ >