From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 55A8BA00C3;
	Tue, 20 Sep 2022 04:36:12 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3DA414069B;
	Tue, 20 Sep 2022 04:36:11 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id CB97140E0F
 for <dev@dpdk.org>; Tue, 20 Sep 2022 04:36:09 +0200 (CEST)
Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.57])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MWltV3D55zlVm3;
 Tue, 20 Sep 2022 10:32:02 +0800 (CST)
Received: from [10.67.103.235] (10.67.103.235) by
 kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.31; Tue, 20 Sep 2022 10:36:07 +0800
Subject: Re: [PATCH 1/6] app/procinfo: add version dump
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 "thomas@monjalon.net" <thomas@monjalon.net>, "ferruh.yigit@xilinx.com"
 <ferruh.yigit@xilinx.com>, "andrew.rybchenko@oktetlabs.ru"
 <andrew.rybchenko@oktetlabs.ru>
References: <20220722091236.15469-1-liudongdong3@huawei.com>
 <20220722091236.15469-2-liudongdong3@huawei.com>
 <BYAPR11MB33665C805922646D0E2069F3FF4D9@BYAPR11MB3366.namprd11.prod.outlook.com>
CC: "Min Hu (Connor)" <humin29@huawei.com>, Maryam Tahhan
 <maryam.tahhan@intel.com>
From: Dongdong Liu <liudongdong3@huawei.com>
Message-ID: <cd541064-30a3-05fb-2f82-f794915817ce@huawei.com>
Date: Tue, 20 Sep 2022 10:35:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <BYAPR11MB33665C805922646D0E2069F3FF4D9@BYAPR11MB3366.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.103.235]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
 kwepemi500017.china.huawei.com (7.221.188.110)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Pattan

Many thanks for you review.

On 2022/9/19 17:23, Pattan, Reshma wrote:
>
>
>> -----Original Message-----
>> From: Dongdong Liu <liudongdong3@huawei.com>
>> Subject: [PATCH 1/6] app/procinfo: add version dump
>
> If this is V2 version of patch, please add V2 in the patch heading.
> And can you mark the previous version of patches  "Superseded" in the patchwork.
Yes, will do, thanks for reminding this.

>
>> dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx -- -- show-version
>
>  --show-version? But not -- show-version.
Will fix.
>
>
>> --- a/app/proc-info/main.c
>> +		"  --show-version: to display DPDK version and firmware
>> version\n"
>
> Say ethdev firmware version.  Instead of just firmware version.
Will fix.
>
>>
>> +static void show_version(void)
>
> Divide this into 2 lines. "static void" should be in one line and "show_version(void)" should be in another line.
> Please check the other functions in the file for an example.
Will do.
>
>
>> +{
>> +#define ETHDEV_FWVERS_LEN 32
>
> Can this definition be moved to top of the file along with the other #defines.
Yes, Will do.
>
>
>> +
>> 	ETHDEV_FWVERS_LEN) == 0)
>> +			printf("Firmware version: %s\n", fw_version);
>
> Better to include Ethdev <port id> Firmware version.
Will do.

Thanks,
Dongdong
>
> Thanks,
> Reshma
> .
>