From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44BB3A04DC; Mon, 26 Oct 2020 15:34:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 22D4629C6; Mon, 26 Oct 2020 15:34:24 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by dpdk.org (Postfix) with ESMTP id 0CEC7100C for ; Mon, 26 Oct 2020 15:34:23 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B86247F567; Mon, 26 Oct 2020 17:34:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B86247F567 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1603722861; bh=lpHXHbH3YrmsRumkH+WlZoeFqMhPEG0Xjmgrc5RYX0M=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=LYSNw+pJIr+a+GLF8RmaG+hE9xpc9ALaW+bmlee3ZgGyrjWM0qEkgqdEUbdNkmnUS M+s6qBa9t1tUZL5yE7SE6bpZZMiRu+Ifhf0dRnRZvvhmqTTZKpUVdOtDoUvzkHmMQX uT1rQZPaidztdhjyi3YbsLNc/Si8hFdcpRjjyzNA= To: Thomas Monjalon , David Marchand Cc: dev , "Yigit, Ferruh" , Bruce Richardson , Olivier Matz , Akhil Goyal , Nithin Dabilpuram , Pavan Nikhilesh References: <20201026052105.1561859-1-thomas@monjalon.net> <20201026052105.1561859-5-thomas@monjalon.net> <2911701.ZJlzt3N5jF@thomas> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Mon, 26 Oct 2020 17:34:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <2911701.ZJlzt3N5jF@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 04/15] node: switch IPv4 metadata to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/20 5:29 PM, Thomas Monjalon wrote: > 26/10/2020 11:40, David Marchand: >> On Mon, Oct 26, 2020 at 6:21 AM Thomas Monjalon wrote: >>> + node_mbuf_priv1_dynfield_offset = rte_mbuf_dynfield_register( >>> + &node_mbuf_priv1_dynfield_desc); >>> + if (node_mbuf_priv1_dynfield_offset < 0) >>> + return -1; >> >> How about return -rte_errno like what is done in setup_lpm()? > > Yes, looks better > > [...] >>> +static const struct rte_mbuf_dynfield node_mbuf_priv1_dynfield_desc = { >>> + .name = "rte_node_dynfield_priv1", >>> + .size = sizeof(uint64_t), >>> + .align = __alignof__(uint64_t), >> >> s/uint64_t/struct node_mbuf_priv1/g ? > > Yes will do > Just to be sure - "struct node_mbuf_priv1 *"