From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CA20A053B; Thu, 6 Feb 2020 15:36:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 533EF1C118; Thu, 6 Feb 2020 15:36:18 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 784681C116 for ; Thu, 6 Feb 2020 15:36:17 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id a9so242484wmj.3 for ; Thu, 06 Feb 2020 06:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8nR1Un/PUC8bhoFCc7aZ4C9OcWP5qv9b2Bk7IOQxnxI=; b=BDIwxXAyor/Xlg9VIw75W696WjTDpMWuu2ZT2+GyxxGY87Q0MYp34RSi9DdmJEX5Vm poBvmhcpeFW78xUSxhZ1wgpAvdV5wy4G5NNB2U6rjpMNbsOQ0NTGTBb4AUuF96m8pu/g Z7S9jhuXlhA8C+LL8tlMZOgcsuKHiTUvzOnWDop/C5V9dE0LgVbkyQasXyDwQeU9H4gA zepIMW4Zf8dg1X2zIwf7C97RHYGxxyilavkO26zt+7gd65yHqXzQYmn2CdKqMFWrn0GF bb1F1Fuu3deur51+aoEnIFI59NADSbNo8ywwKQQh85+StFJb7GM2V2EAARWxbsFaY5zD ID/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8nR1Un/PUC8bhoFCc7aZ4C9OcWP5qv9b2Bk7IOQxnxI=; b=DVBATm2vjcqzAzEQQs88RIPoMlbRiDyF6dKDL/0cLF3zx1YMSPjCwHCR5LyqjtFgcy ssHa7RJ4i0Zz1YqJ//WzgtPOLMVmt1GAu4g/9swY0tM0+ic//Eg9oLKxRo7TcVQtKzEP G2GNT/x/cOn/DkdSvozuL8hJDTzmQtg/K6ACOE3eJ+WO3aWFUTObpOCv4giM71pCRSXn P7g6SnBa00oxyPcVsdad8++AI0vXdRd4EMOppIgzNBiQxIW8hNjHuNMoYEKzzbZMgtv7 FvwUVy480u3xBEfleeYPHMZS9laToL0TS+Y3BRyZCREkgNj+ecChOOwV8qirNpKxHyYB aAKA== X-Gm-Message-State: APjAAAXODbJ1bxXy034kzdZpd92Q+UmzH6JicyWLf5ID23sd/O0wzfLk qO0BaFl6SnJThhFMarVPKpvQ X-Google-Smtp-Source: APXvYqzLFDNgRz+wm0CMn18q5lZZgbTXbwY6cBg+RxbPP1FBYTOVd2kzTQgOHsexWgEn4a2rMBvDPQ== X-Received: by 2002:a7b:c651:: with SMTP id q17mr5147352wmk.5.1580999777162; Thu, 06 Feb 2020 06:36:17 -0800 (PST) Received: from [10.16.0.208] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id i4sm2055512wmd.23.2020.02.06.06.36.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2020 06:36:16 -0800 (PST) To: Bruce Richardson Cc: "dev@dpdk.org" , Anoob Joseph , Akhil Goyal References: <20200206142749.GA777@bricha3-MOBL.ger.corp.intel.com> From: Thierry Herbelot Message-ID: Date: Thu, 6 Feb 2020 15:36:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200206142749.GA777@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/6/20 3:27 PM, Bruce Richardson wrote: > On Thu, Feb 06, 2020 at 02:39:28PM +0100, Thierry Herbelot wrote: >> Hello, >> >> When RTE_LIBRTE_SECURITY is disabled, compilation fails for octeontx2 (on an >> Intel machine): >> >> git clone git://dpdk.org/dpdk >> cd dpdk >> make config T=x86_64-native-linux-gcc >> cd build >> vi .config >> => disable RTE_LIBRTE_IPSEC and RTE_LIBRTE_SECURITY >> make >> ... >> == Build drivers/net/octeontx2 >> CC otx2_rx.o >> In file included from .../dpdk/drivers/net/octeontx2/otx2_ethdev_sec.h:10, >> from .../dpdk/drivers/net/octeontx2/otx2_rx.h:11, >> from .../dpdk/drivers/net/octeontx2/otx2_ethdev.h:24, >> from .../dpdk/drivers/net/octeontx2/otx2_rx.c:7: >> .../dpdk/drivers/crypto/octeontx2/otx2_ipsec_fp.h:9:10: fatal error: >> rte_security.h: No such file or directory >> #include >> ^~~~~~~~~~~~~~~~ >> compilation terminated. >> >> This seems cause by f44e7163775537 ('net/octeontx2: add security session >> operations'). >> > Disabling parts of the build, particularly libraries, is always likely to > cause other build failures. I'm not sure we should, or even need to, > support the disabling of arbitrary libs in DPDK. Hello, On the other hand, there is no reason delivering unused code in a DPDK application: an application should be free to select its needed 'modules'. Thanks Thierry > > /Bruce >