From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7546445A68; Mon, 21 Oct 2024 09:00:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F865402C6; Mon, 21 Oct 2024 09:00:30 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 201C84028C for ; Mon, 21 Oct 2024 09:00:28 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4XX5kC5Wv2zpX8g; Mon, 21 Oct 2024 14:58:27 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 31D8014010D; Mon, 21 Oct 2024 15:00:25 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 21 Oct 2024 15:00:24 +0800 Message-ID: Date: Mon, 21 Oct 2024 15:00:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/6] refine argparse library To: Thomas Monjalon CC: , , Stephen Hemminger References: <20240220131502.47510-1-fengchengwen@huawei.com> <13bb1302-9e94-4526-913e-5a51c94d68aa@huawei.com> <5566b273-5c42-4d11-968c-b52648ff4732@huawei.com> <3466447.9LS3J3VOpE@thomas> Content-Language: en-US From: fengchengwen In-Reply-To: <3466447.9LS3J3VOpE@thomas> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/10/18 22:46, Thomas Monjalon wrote: > 18/10/2024 03:09, fengchengwen: >> Hi Thomas and David, >> >> This patchset was already acked by Stephen. >> It missed in DPDK 24.07, hope merge in 24.11. >> >> Thanks >> >> On 2024/10/10 9:35, fengchengwen wrote: >>> Hi Thomas and David, >>> >>> Kindly ping for merge. >>> >>> On 2024/10/10 3:33, Stephen Hemminger wrote: >>>> On Mon, 18 Mar 2024 11:18:32 +0000 >>>> Chengwen Feng wrote: >>>> >>>>> I found a couple of issues when I revisited the argparse_autotest >>>>> output, so got this patchset. >>>>> >>>>> Chengwen Feng (6): >>>>> argparse: refine error message >>>>> argparse: remove dead code >>>>> argparse: replace flag enum with marco >>>>> argparse: fix argument flags operate as uint32 type >>>>> test/argparse: refine testcases >>>>> argparse: fix doc don't display two hyphens >>>>> >>>>> --- >>>>> v4: address Thomas's comment on 4/6 commit: >>>>> - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and >>>>> TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. >>>>> v3: >>>>> - address Thomas's comment on 4/6 comit. >>>>> - add commit: fix doc don't display two hyphens. >>>>> v2: address David Marchand's comment: >>>>> - replace flag enum with marco. >>>>> - replace flag's hardcode with macro in test_argparse.c. >>>>> >>>>> app/test/test_argparse.c | 65 +++++++++++--------- >>>>> doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- >>>>> lib/argparse/rte_argparse.c | 61 +++++++++--------- >>>>> lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- >>>>> 4 files changed, 127 insertions(+), 131 deletions(-) >>>> >>>> The verb refine is not usually used for edits to documents or software >>>> that probably is a translation issue. >>>> >>>> Series-acked-by: Stephen Hemminger >>> >>> Thank Stephen > > Added Bugzilla ID, CC: stable, reworded as Stephen suggests, > and applied. Thanks > > Note that the lists in doxygen comments does not look nice. > You may look at this: https://www.doxygen.nl/manual/lists.html I'll look at it and push another commit if needed. > >