From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail01.napatech.com (mail01.napatech.com [188.120.77.121]) by dpdk.org (Postfix) with ESMTP id 555012951 for ; Fri, 5 Jan 2018 08:52:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; i=@napatech.com; q=dns/txt; s=mar2017; t=1515138738; x=1546674738; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6em/bRbw+zb/T2uzW/mtgyB55+YPYrMKGBf1w+oIJzw=; b=f3b02UGaT8Rr3LFDDWibsvUzzE0DdHdgns7wX0gl321m3QOIPhINqMTj 3xCA8fBaldRbo4qffRgp11tskpy7JkPtHIeLQurCvnXcBtQSePQ+L5jZK ah1wMG7ggkOFTQuZb8xkgh/QpaAc3nkl4xHpBAnA1gUwdVTUnHO26cOOB akZvIEUtj3ATFoxGwzSHaA6etPg75fAWpU5+EKhaDRGdXTsp0Ia5RuNuM CvmZ9ZBtJD9tQThWRca0E1Ld6cLSE/7wO7ayRyw9F1T/LSLICXhfJBiQR 9rVj0FACOSmq8OKfxboYQIcD0OoaY64YQbUvsdiAf55VhDCrtKZ3jRtj5 g==; IronPort-PHdr: =?us-ascii?q?9a23=3ATl+rjBE49LZolgbo4x/oKZ1GYnF86YWxBRYc798d?= =?us-ascii?q?s5kLTJ7zrsSwAkXT6L1XgUPTWs2DsrQY07OQ7P6rADVaqb+681k6OKRWUBEEjc?= =?us-ascii?q?hE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i764jEdAAjwOhRo?= =?us-ascii?q?LerpBIHSk9631+ev8JHPfglEnjWwba9vIBmsrwjct8YajZZ/Jqov1xDEvmZGd+?= =?us-ascii?q?NKyG1yOFmdhQz85sC+/J5i9yRfpfcs/NNeXKv5Yqo1U6VWACwpPG4p6sLrswLD?= =?us-ascii?q?TRaU6XsHTmoWiBtIDBPb4xz8Q5z8rzH1tut52CmdIM32UbU5Uims4qt3VBPljj?= =?us-ascii?q?oMOiUn+2/LlMN/kKNboAqgpxNhxY7UfJqVP+d6cq/EYN8WWXZNUsNXWidcAI2z?= =?us-ascii?q?cpEPAvIBM+hGsof9u1UAoxiwBQauBePg1jBGiXDt0K0myuQhEx3K0BA8E94Qtn?= =?us-ascii?q?nfsdX7NL0VUeCw1KTGzTTDb/VQ2Tzg9oXIcgohofCXXbJsb8XRz1IvGB3Djl6N?= =?us-ascii?q?roHlMS+a2/8Ls2eB9+pvT/6vhHA7pAFxuDSg2sAsiozQi48T11vK+yJ5wIMvKt?= =?us-ascii?q?25Tk52edmkEINOuCGcKYt2Wc0jQ2B0uCkmyr0Ko5m7fDIFyJkh2hXRaOSHfpCV?= =?us-ascii?q?7h7/TuqdPzh1iG5/dL6inRq/8ketxvXhWsWoylpGsCVInsXWunwQyxDf8NaLR/?= =?us-ascii?q?V580u51zaAyQPe5v1BLE0xlafWKIMtz7swm5YOq0vPAyr7l1/qg6KYeEUp/+ul?= =?us-ascii?q?5uv5bbjgu5SSLZV7ihvkPaQrgsG/BOM4PRUQUGWD4uS80aHj/VX+QLVXkv06iq?= =?us-ascii?q?nZv47eJcQcvqO5BhVa0ocn6xqlCTepyswYkmMbLF1bZB2Hj5LlNE3JIPD9Ffu/?= =?us-ascii?q?glKsnyl3x/3eI7HtHo/BImbMnbv9Z7px9lRQxQk8wNxH4pJbELABIPb9Wk/rs9?= =?us-ascii?q?zYCwc0MwKozOv8DtVyzJseVniTAqCHLKzSsUWE6f4oI+mJfIMVoiryK+A55/7y?= =?us-ascii?q?in80gUIScre33ZYMdX+4BulpI0aDbXrrmNcBHjRCgg1rcOztjVSZGRtUYXS7W6?= =?us-ascii?q?U6rmUnCIWjBJzrQ4ergrWF2yH9GJBKMCQOQFyBD1/kb4mHHfAWZ2jadsNsjBQI?= =?us-ascii?q?TbSiDYg72kf9mhX9zu9JL+zSsgYYr5P4yNVz/ODV3UU8/hRyBtyUz2yGTyd/mW?= =?us-ascii?q?ZeFGx+57x2vUEokgTL6qN/mfENUIULv/4=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2HyAgDsLU9a/1QB8ApdHAEBAQQBAQoBA?= =?us-ascii?q?YQkgRsHnzaXKoIVCiOFGAKEdBcBAQEBAQEBAQEBAoEQgjgkAQ54AQEBAQEBAQE?= =?us-ascii?q?BTAINXQEBAQECATo/DAQCAQgRBAEBHwkHMhQJCAIEAQ0FCIofGLJjij4BAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBAQEBAQEYBYQUgQ6CWoUXgzCBTgEBhhoFkiSROIgGjS2CIIY?= =?us-ascii?q?Yi1eNMok0AgICAgkCGoE8IQKBbxZvFRmCToRXeIZDgSWBFwEBAQ?= X-IPAS-Result: =?us-ascii?q?A2HyAgDsLU9a/1QB8ApdHAEBAQQBAQoBAYQkgRsHnzaXKoI?= =?us-ascii?q?VCiOFGAKEdBcBAQEBAQEBAQEBAoEQgjgkAQ54AQEBAQEBAQEBTAINXQEBAQECA?= =?us-ascii?q?To/DAQCAQgRBAEBHwkHMhQJCAIEAQ0FCIofGLJjij4BAQEBAQEBAQEBAQEBAQE?= =?us-ascii?q?BAQEBAQEYBYQUgQ6CWoUXgzCBTgEBhhoFkiSROIgGjS2CIIYYi1eNMok0AgICA?= =?us-ascii?q?gkCGoE8IQKBbxZvFRmCToRXeIZDgSWBFwEBAQ?= Received: from cph-gen-exch02.napatech.com (10.240.1.84) by cph-gen-exch02.napatech.com (10.240.1.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Fri, 5 Jan 2018 08:52:14 +0100 Received: from cph-gen-exch02.napatech.com ([fe80::581:51a1:ac3f:84e]) by cph-gen-exch02.napatech.com ([fe80::581:51a1:ac3f:84e%12]) with mapi id 15.01.1034.026; Fri, 5 Jan 2018 08:52:14 +0100 From: Finn Christensen To: Thomas Monjalon , "dev@dpdk.org" CC: Yuanhan Liu , Adrien Mazarguil , Ciara Loftus , "Kevin Traynor" , "stephen@networkplumber.org" , "ferruh.yigit@intel.com" Thread-Topic: [dpdk-dev] standardize device identification Thread-Index: AQHTed5wRSh3eSywGUykeeHF0l5SaqNj3zuA Date: Fri, 5 Jan 2018 07:52:14 +0000 Message-ID: References: <1512027330-30030-1-git-send-email-yliu@fridaylinux.org> <1743809.pZtjZi6UOT@xps> <7044959.u7szEIarlR@xps> In-Reply-To: <7044959.u7szEIarlR@xps> Accept-Language: da-DK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.240.10.239] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] standardize device identification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 07:52:18 -0000 -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon Sent: 20. december 2017 23:03 To: dev@dpdk.org Cc: Yuanhan Liu ; Adrien Mazarguil ; Ciara Loftus ; Kevin Traynor ; stephen@networkplumber.org; ferruh.yigit@intel.com Subject: Re: [dpdk-dev] standardize device identification =20 Changing the title and adding more comments inline: =20 19/12/2017 00:05, Thomas Monjalon: > Let's summarize and resume this thread. > > We need a generic syntax to describe a device. > This syntax can be used > - before initializing the device (i.e. whitelist/blacklist) > - or after the initialization (e.g. user config) > > We need to answer 4 questions: > 1/ what are the separators (comma, colon, etc)? > 2/ how to distinguish a device identification from a configuration? > 3/ what are the mandatory parts? > 4/ what can be the optional properties? > > 30/11/2017 08:35, Yuanhan Liu: > > What this patch proposes is to use "name[,mac]" syntax. "name" is > > the PCI id for pci device. For vdev, it's the vdev name given by > > user. The reason "mac" is needed is for some devices (say > > ConnectX-3), 2 ports (in a single NIC) have the same PCI id. > > Based on the feedbacks we had, I suggest a syntax where everything is > optional key/value pairs, and split in 3 categories: > - bus (pci, vdev, vmbus, fslmc, etc) > - class (eth, crypto) > - driver (i40e, mlx5, virtio, etc) =20 The key/value pair describing the category scope is mandatory and must be the first pair in the category properties. Example: bus=3Dpci, must be placed before id=3D0000:01:00.0 =20 > Between categories, the separator is a slash. > Inside a category, the separator is a comma. > Inside a key/value pair, the separator is an equal sign. > > It may look like this: > bus=3DBUS_NAME,id=3DBUS_ID/class=3DCLASS_NAME,dev_port=3DPORT_NUM,m ac=3DMAC_ADDR > ESS/driver=3DDRIVER_NAME,driverspecificproperty=3DVALUE > > A device is identified when every properties are matched. > Before device is probed, only the bus category is relevant. > For the simple PCI whitelist, it means moving from > -w 0000:01:00.0 > to > -w bus=3Dpci,id=3D0000:01:00.0 > > It is possible to mix some settings in these devargs syntax if the > keys are differents. Example: mac=3D is for identification by MAC, > whereas newmac=3D would be for specifying a MAC address to set. > > Agreement? =20 =20 We also need to distinguish between multiple ports sitting on same PCI bus = ID. and from our point of view, this will fully cover our needs. Thanks - great proposal. Regards, Finn Christensen, Napatech Yuanhan is proposing to use this syntax in OVS option dpdk-devargs: https://mail.openvswitch.org/pipermail/ovs-dev/2017- December/342273.html =20 Please, any feedback or approval that this syntax is good?