From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CF1CA0A02; Fri, 26 Mar 2021 12:52:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A50740685; Fri, 26 Mar 2021 12:52:04 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id B26714067B for ; Fri, 26 Mar 2021 12:52:02 +0100 (CET) IronPort-SDR: sR1+fEdBXl4XP/3gqpJcUZr6lsNjybjHYZCeia6kq1kRThyw7txldTEadYvehDAgU4FwvK+OmN mvapoe8HwIzA== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="276271900" X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="276271900" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 04:52:01 -0700 IronPort-SDR: 4gM3elNMh2/Q1RzIFwDw0/Vd2IXS2GylT/CNO8WIMK8QVL8MujL63apfaHX1J2oPAzaXsDC98T hJ2VuHV2WOxQ== X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="375460221" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.231.99]) ([10.213.231.99]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 04:51:59 -0700 To: Pallavi Kadam , dev@dpdk.org, thomas@monjalon.net Cc: dmitry.kozliuk@gmail.com, ranjit.menon@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com References: <20210303215929.5616-1-pallavi.kadam@intel.com> <20210311015848.4976-1-pallavi.kadam@intel.com> <20210311015848.4976-3-pallavi.kadam@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 26 Mar 2021 11:51:56 +0000 MIME-Version: 1.0 In-Reply-To: <20210311015848.4976-3-pallavi.kadam@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/11/2021 1:58 AM, Pallavi Kadam wrote: > - Add Intel ice PMD support on Windows. > - Remove #include sys/ioctl header file as it is not needed. > - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting > types. > - Replace POSIX usleep() API with rte API. > - Add a new macro for the access() API as the original function > has been deprecated on Windows. > - Add extra cflags '-fno-asynchronous-unwind-tables' > to avoid MinGW build error: > Error: invalid register for .seh_savexmm > - Add documentation to support ice PMD on Windows. > Update the release notes and features list for the same. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon <...> > --- a/drivers/net/ice/base/ice_switch.c > +++ b/drivers/net/ice/base/ice_switch.c > @@ -6684,7 +6684,7 @@ ice_fill_valid_words(struct ice_adv_lkup_elem *rule, > > for (j = 0; j < sizeof(rule->m_u) / sizeof(u16); j++) > if (((u16 *)&rule->m_u)[j] && > - rule->type < ARRAY_SIZE(ice_prot_ext)) { > + (unsigned long long)rule->type < ARRAY_SIZE(ice_prot_ext)) { isn't 'ARRAY_SIZE' return type is 'size_t', if 'size_t' is supported in Windows why not cast to it, instead of "unsigned long long". <...> > index b82d05fe7..01f8f409d 100644 > --- a/drivers/net/ice/base/meson.build > +++ b/drivers/net/ice/base/meson.build > @@ -29,6 +29,10 @@ foreach flag: error_cflags > endif > endforeach > > +if is_windows and cc.get_id() != 'clang' > + cflags += ['-fno-asynchronous-unwind-tables'] > +endif > + This seems not having affect [1], may be because 'cflags' is not used for build but 'c_args', moving the block above "c_args = cflags" assignment may work. [1] http://mails.dpdk.org/archives/test-report/2021-March/182218.html