From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8B7F2559C for ; Fri, 7 Apr 2017 17:44:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491579846; x=1523115846; h=subject:to:references:from:cc:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=qpJ9QAv/0n+2t+l+e0/uySBa3hykFUfeqs1JJPR7V+E=; b=OESZvEtg2t5it4K0/v5SRO8GODXqrneuPgaDD22MNeu5LbyiN3Jh1KEn sR/rKjhymKSucakFkHa78Ia8uNtd+g==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2017 08:44:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,166,1488873600"; d="scan'208";a="86437622" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 07 Apr 2017 08:44:04 -0700 To: Konstantin Ananyev References: <1488966121-22853-9-git-send-email-olivier.matz@6wind.com> <1491301790-22457-1-git-send-email-konstantin.ananyev@intel.com> From: Ferruh Yigit Cc: DPDK Message-ID: Date: Fri, 7 Apr 2017 16:44:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/2] reduce writes to mbuf in ixgbe vRX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 15:44:07 -0000 On 4/7/2017 4:13 PM, Ferruh Yigit wrote: > On 4/4/2017 11:29 AM, Konstantin Ananyev wrote: >> Pretty much the same as one from Bruce: >> http://dpdk.org/ml/archives/dev/2017-April/062936.html >> but now for ixgbe. >> Based on Olivier's mbuf rework patchset, and makes some >> improvement to the ixgbe driver taking account of the rework. >> It also removes a build-time option that seems unnecessary. >> >> Depends on: http://dpdk.org/ml/archives/dev/2017-March/059693.html >> >> Konstantin Ananyev (2): >> net/ixgbe: eliminate mbuf write on rearm >> net/ixgbe: remove option to disable offload flags >> >> config/common_base | 1 - >> doc/guides/nics/ixgbe.rst | 18 ---------- >> drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 7 ---- >> drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 11 ------ >> drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 58 +++++++++++++------------------ >> 5 files changed, 24 insertions(+), 71 deletions(-) > > Series applied to dpdk-next-net/master, thanks. Hi Konstantin, I talked a little early, getting following build error [1] with "default" machine type. Patches dropped from tree for now. [1] ...drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:217:11: error: implicit declaration of function '_mm_blend_epi16' is invalid in C99 [-Werror,-Wimplicit-function-declaration] rearm0 = _mm_blend_epi16(mbuf_init, _mm_slli_si128(vtag1, 8), 0x10); ^ ...drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:217:9: error: assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' rearm0 = _mm_blend_epi16(mbuf_init, _mm_slli_si128(vtag1, 8), 0x10); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ...drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:218:9: error: assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' rearm1 = _mm_blend_epi16(mbuf_init, _mm_slli_si128(vtag1, 6), 0x10); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ...drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:219:9: error: assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' rearm2 = _mm_blend_epi16(mbuf_init, _mm_slli_si128(vtag1, 4), 0x10); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ...drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:220:9: error: assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' rearm3 = _mm_blend_epi16(mbuf_init, _mm_slli_si128(vtag1, 2), 0x10); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~