From: Ferruh Yigit <ferruh.yigit@intel.com>
To: oulijun <oulijun@huawei.com>
Cc: dev@dpdk.org, linuxarm@huawei.com
Subject: Re: [dpdk-dev] [PATCH v2 3/5] net/hns3: adjust some code style
Date: Mon, 9 Nov 2020 10:51:46 +0000 [thread overview]
Message-ID: <cdffd3c8-b256-0091-ba32-795d5040733b@intel.com> (raw)
In-Reply-To: <fa4a3390-9fa6-338c-8e3f-fb6dcb420447@huawei.com>
On 11/9/2020 9:32 AM, oulijun wrote:
>
>
> 在 2020/11/7 0:44, Ferruh Yigit 写道:
>> On 11/6/2020 3:51 AM, Lijun Ou wrote:
>>> From: Hongbo Zheng <zhenghongbo3@huawei.com>
>>>
>>> Here adjusts some code style for making the lines more
>>> compact and removes some static check tool warnings.
>>>
>>> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>> ---
>>> V1->V2:
>>> - fix checkpatch warning
>>> ---
>>> drivers/net/hns3/hns3_cmd.c | 1 -
>>> drivers/net/hns3/hns3_ethdev.c | 6 +-
>>> drivers/net/hns3/hns3_ethdev.h | 1 -
>>> drivers/net/hns3/hns3_flow.c | 37 +-
>>> drivers/net/hns3/hns3_intr.c | 873 +++++++++++++++++++++++++++--------------
>>> drivers/net/hns3/hns3_rxtx.c | 1 -
>>> drivers/net/hns3/hns3_stats.c | 1 -
>>> 7 files changed, 597 insertions(+), 323 deletions(-)
>>
>> This is a big(ish) patch with just whitespace changes, looks like related to
>> the personal preferences.
>> This will create noise in the git history, and unnecessary conflict in
>> backporting patches.
>>
>> I know it is tempting to fix here or there :), but lets fix those when
>> updating those lines for a functional change, and drop this patch.
>> .
> Requirements for some static check tools:
> When struct and union members are initialized, each member is initialized on a
> separate line.
> We think this requirement can be a better code style.
> We can split the just whitespace changes with the above requirements?
> because the Redundant blank lines alarms.
>
I see, so the changes in 'hns3_intr.c' is coming from that requirement, yes can
you please separate each static analyzer warning into its patch with explanation
in the commit log why the change is done. And I think can drop the just
whitespace changes.
Thanks,
ferruh
next prev parent reply other threads:[~2020-11-09 10:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 14:23 [dpdk-dev] [PATCH 0/5] bugfix and cleanups for hns3 Lijun Ou
2020-11-05 14:23 ` [dpdk-dev] [PATCH 1/5] net/hns3: use correct logging format symbol Lijun Ou
2020-11-05 14:23 ` [dpdk-dev] [PATCH 2/5] net/hns3: use unsigned types for bit operator Lijun Ou
2020-11-05 14:23 ` [dpdk-dev] [PATCH 3/5] net/hns3: adjust some code style Lijun Ou
2020-11-05 14:23 ` [dpdk-dev] [PATCH 4/5] net/hns3: check PCI config space writes Lijun Ou
2020-11-05 14:23 ` [dpdk-dev] [PATCH 5/5] net/hns3: fix queue enabling status not store after FLR Lijun Ou
2020-11-06 3:51 ` [dpdk-dev] [PATCH v2 0/5] bugfix and cleanups for hns3 Lijun Ou
2020-11-06 3:51 ` [dpdk-dev] [PATCH v2 1/5] net/hns3: use correct logging format symbol Lijun Ou
2020-11-06 3:51 ` [dpdk-dev] [PATCH v2 2/5] net/hns3: use unsigned types for bit operator Lijun Ou
2020-11-06 16:38 ` Ferruh Yigit
2020-11-09 9:21 ` oulijun
2020-11-09 9:28 ` oulijun
2020-11-06 3:51 ` [dpdk-dev] [PATCH v2 3/5] net/hns3: adjust some code style Lijun Ou
2020-11-06 16:44 ` Ferruh Yigit
2020-11-09 9:32 ` oulijun
2020-11-09 10:51 ` Ferruh Yigit [this message]
2020-11-06 3:51 ` [dpdk-dev] [PATCH v2 4/5] net/hns3: check PCI config space writes Lijun Ou
2020-11-06 16:45 ` Ferruh Yigit
2020-11-09 13:44 ` oulijun
2020-11-06 3:51 ` [dpdk-dev] [PATCH v2 5/5] net/hns3: fix queue enabling status not store after FLR Lijun Ou
2020-11-06 16:57 ` Ferruh Yigit
2020-11-09 14:27 ` oulijun
2020-11-09 14:28 ` [dpdk-dev] [PATCH V3 0/6] bugfix and cleanups for hns3 Lijun Ou
2020-11-09 14:28 ` [dpdk-dev] [PATCH V3 1/6] net/hns3: use correct logging format symbol Lijun Ou
2020-11-09 14:28 ` [dpdk-dev] [PATCH V3 2/6] net/hns3: use unsigned types for bit operator Lijun Ou
2020-11-09 14:28 ` [dpdk-dev] [PATCH V3 3/6] net/hns3: adjust code style for initial struct Lijun Ou
2020-11-09 14:29 ` [dpdk-dev] [PATCH V3 4/6] net/hns3: check PCI config space writes Lijun Ou
2020-11-09 14:29 ` [dpdk-dev] [PATCH V3 5/6] net/hns3: fix queue enabling state not store after FLR Lijun Ou
2020-11-09 14:29 ` [dpdk-dev] [PATCH V3 6/6] net/hns3: remove some unnecessary blank lines Lijun Ou
2020-11-10 10:17 ` [dpdk-dev] [PATCH V3 0/6] bugfix and cleanups for hns3 Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdffd3c8-b256-0091-ba32-795d5040733b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=linuxarm@huawei.com \
--cc=oulijun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).